diff --git a/clang/lib/Sema/SemaStmt.cpp b/clang/lib/Sema/SemaStmt.cpp index 643dde437fc949..2ae27de9b20799 100644 --- a/clang/lib/Sema/SemaStmt.cpp +++ b/clang/lib/Sema/SemaStmt.cpp @@ -3483,7 +3483,12 @@ ExprResult Sema::PerformMoveOrCopyInitialization(const InitializedEntity &Entity, const NamedReturnInfo &NRInfo, Expr *Value) { - if (!getLangOpts().CPlusPlus2b && NRInfo.isMoveEligible()) { + // FIXME: We force P1825 implicit moves here in msvc compatibility mode + // because we are disabling simpler implicit moves as a temporary + // work around, as the MSVC STL has issues with this change. + // We will come back later with a more targeted approach. + if ((!getLangOpts().CPlusPlus2b || getLangOpts().MSVCCompat) && + NRInfo.isMoveEligible()) { ImplicitCastExpr AsRvalue(ImplicitCastExpr::OnStack, Value->getType(), CK_NoOp, Value, VK_XValue, FPOptionsOverride()); Expr *InitExpr = &AsRvalue; diff --git a/clang/test/SemaCXX/cxx2b-p2266-disable-with-msvc-compat.cpp b/clang/test/SemaCXX/cxx2b-p2266-disable-with-msvc-compat.cpp index 2143c0535e606b..07db9b8333fa61 100644 --- a/clang/test/SemaCXX/cxx2b-p2266-disable-with-msvc-compat.cpp +++ b/clang/test/SemaCXX/cxx2b-p2266-disable-with-msvc-compat.cpp @@ -48,3 +48,5 @@ void test5() try { throw x; // new-error {{no matching constructor for initialization}} } catch (...) { } + +MoveOnly test6(MoveOnly x) { return x; }