From 1e396affca6a0d21247d960c93a415e8f6fe0301 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Thu, 24 Feb 2022 14:19:19 +0100 Subject: [PATCH] [Symbolizer] Move ctor/dtor into .cpp file On some standard library configurations these have a dependency on the complete type of SymbolizableModule. They also do a lot of copying/freeing so no point in inlining them. --- llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h | 4 ++-- llvm/lib/DebugInfo/Symbolize/Symbolize.cpp | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h b/llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h index b1833d56db722..552f2d315c50b 100644 --- a/llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h +++ b/llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h @@ -61,9 +61,9 @@ class LLVMSymbolizer { }; LLVMSymbolizer() = default; - LLVMSymbolizer(const Options &Opts) : Opts(Opts) {} + LLVMSymbolizer(const Options &Opts); - ~LLVMSymbolizer() { flush(); } + ~LLVMSymbolizer(); // Overloads accepting ObjectFile does not support COFF currently Expected symbolizeCode(const ObjectFile &Obj, diff --git a/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp b/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp index 1a163d98e8402..dac96c084b276 100644 --- a/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp +++ b/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp @@ -39,6 +39,10 @@ namespace llvm { namespace symbolize { +LLVMSymbolizer::LLVMSymbolizer(const Options &Opts) : Opts(Opts) {} + +LLVMSymbolizer::~LLVMSymbolizer() = default; + template Expected LLVMSymbolizer::symbolizeCodeCommon(const T &ModuleSpecifier,