Skip to content

Commit

Permalink
[X86] Add ENQCMD instructions
Browse files Browse the repository at this point in the history
For more details about these instructions, please refer to the latest
ISE document:
https://software.intel.com/en-us/download/intel-architecture-instruction-set-extensions-programming-reference.

Patch by Tianqing Wang (tianqing)

Differential Revision: https://reviews.llvm.org/D62281

llvm-svn: 362053
  • Loading branch information
phoebewang committed May 30, 2019
1 parent 2632ebb commit 1f67d94
Show file tree
Hide file tree
Showing 15 changed files with 450 additions and 0 deletions.
10 changes: 10 additions & 0 deletions llvm/include/llvm/IR/IntrinsicsX86.td
Expand Up @@ -4872,3 +4872,13 @@ let TargetPrefix = "x86" in {
Intrinsic<[llvm_v16f32_ty],
[llvm_v16f32_ty, llvm_v16i32_ty, llvm_v16i32_ty], [IntrNoMem]>;
}

//===----------------------------------------------------------------------===//
// ENQCMD - Enqueue Stores Instructions

let TargetPrefix = "x86" in {
def int_x86_enqcmd : GCCBuiltin<"__builtin_ia32_enqcmd">,
Intrinsic<[llvm_i8_ty], [llvm_ptr_ty, llvm_ptr_ty], []>;
def int_x86_enqcmds : GCCBuiltin<"__builtin_ia32_enqcmds">,
Intrinsic<[llvm_i8_ty], [llvm_ptr_ty, llvm_ptr_ty], []>;
}
1 change: 1 addition & 0 deletions llvm/lib/Support/Host.cpp
Expand Up @@ -1380,6 +1380,7 @@ bool sys::getHostCPUFeatures(StringMap<bool> &Features) {
Features["cldemote"] = HasLeaf7 && ((ECX >> 25) & 1);
Features["movdiri"] = HasLeaf7 && ((ECX >> 27) & 1);
Features["movdir64b"] = HasLeaf7 && ((ECX >> 28) & 1);
Features["enqcmd"] = HasLeaf7 && ((ECX >> 29) & 1);

// There are two CPUID leafs which information associated with the pconfig
// instruction:
Expand Down
2 changes: 2 additions & 0 deletions llvm/lib/Target/X86/X86.td
Expand Up @@ -263,6 +263,8 @@ def FeatureRDPID : SubtargetFeature<"rdpid", "HasRDPID", "true",
"Support RDPID instructions">;
def FeatureWAITPKG : SubtargetFeature<"waitpkg", "HasWAITPKG", "true",
"Wait and pause enhancements">;
def FeatureENQCMD : SubtargetFeature<"enqcmd", "HasENQCMD", "true",
"Has ENQCMD instructions">;
// On some processors, instructions that implicitly take two memory operands are
// slow. In practice, this means that CALL, PUSH, and POP with memory operands
// should be avoided in favor of a MOV + register CALL/PUSH/POP.
Expand Down
2 changes: 2 additions & 0 deletions llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
Expand Up @@ -2071,6 +2071,8 @@ bool X86DAGToDAGISel::selectAddr(SDNode *Parent, SDValue N, SDValue &Base,
Parent->getOpcode() != ISD::INTRINSIC_W_CHAIN && // unaligned loads, fixme
Parent->getOpcode() != ISD::INTRINSIC_VOID && // nontemporal stores
Parent->getOpcode() != X86ISD::TLSCALL && // Fixme
Parent->getOpcode() != X86ISD::ENQCMD && // Fixme
Parent->getOpcode() != X86ISD::ENQCMDS && // Fixme
Parent->getOpcode() != X86ISD::EH_SJLJ_SETJMP && // setjmp
Parent->getOpcode() != X86ISD::EH_SJLJ_LONGJMP) { // longjmp
unsigned AddrSpace =
Expand Down
23 changes: 23 additions & 0 deletions llvm/lib/Target/X86/X86ISelLowering.cpp
Expand Up @@ -23290,6 +23290,27 @@ static SDValue LowerINTRINSIC_W_CHAIN(SDValue Op, const X86Subtarget &Subtarget,
return DAG.getNode(ISD::MERGE_VALUES, dl, Op->getVTList(), SetCC,
Operation.getValue(1));
}
case Intrinsic::x86_enqcmd:
case Intrinsic::x86_enqcmds: {
SDLoc dl(Op);
SDValue Chain = Op.getOperand(0);
SDVTList VTs = DAG.getVTList(MVT::i32, MVT::Other);
unsigned Opcode;
switch (IntNo) {
default: llvm_unreachable("Impossible intrinsic!");
case Intrinsic::x86_enqcmd:
Opcode = X86ISD::ENQCMD;
break;
case Intrinsic::x86_enqcmds:
Opcode = X86ISD::ENQCMDS;
break;
}
SDValue Operation = DAG.getNode(Opcode, dl, VTs, Chain, Op.getOperand(2),
Op.getOperand(3));
SDValue SetCC = getSETCC(X86::COND_E, Operation.getValue(0), dl, DAG);
return DAG.getNode(ISD::MERGE_VALUES, dl, Op->getVTList(), SetCC,
Operation.getValue(1));
}
}
return SDValue();
}
Expand Down Expand Up @@ -28270,6 +28291,8 @@ const char *X86TargetLowering::getTargetNodeName(unsigned Opcode) const {
case X86ISD::NT_BRIND: return "X86ISD::NT_BRIND";
case X86ISD::UMWAIT: return "X86ISD::UMWAIT";
case X86ISD::TPAUSE: return "X86ISD::TPAUSE";
case X86ISD::ENQCMD: return "X86ISD:ENQCMD";
case X86ISD::ENQCMDS: return "X86ISD:ENQCMDS";
}
return nullptr;
}
Expand Down
3 changes: 3 additions & 0 deletions llvm/lib/Target/X86/X86ISelLowering.h
Expand Up @@ -589,6 +589,9 @@ namespace llvm {
// User level wait
UMWAIT, TPAUSE,

// Enqueue Stores Instructions
ENQCMD, ENQCMDS,

// Compare and swap.
LCMPXCHG_DAG = ISD::FIRST_TARGET_MEMORY_OPCODE,
LCMPXCHG8_DAG,
Expand Down
40 changes: 40 additions & 0 deletions llvm/lib/Target/X86/X86InstrInfo.td
Expand Up @@ -127,6 +127,9 @@ def SDT_X86TCRET : SDTypeProfile<0, 2, [SDTCisPtrTy<0>, SDTCisVT<1, i32>]>;

def SDT_X86MEMBARRIER : SDTypeProfile<0, 0, []>;

def SDT_X86ENQCMD : SDTypeProfile<1, 2, [SDTCisVT<0, i32>,
SDTCisPtrTy<1>, SDTCisSameAs<1, 2>]>;

def X86MemBarrier : SDNode<"X86ISD::MEMBARRIER", SDT_X86MEMBARRIER,
[SDNPHasChain,SDNPSideEffect]>;
def X86MFence : SDNode<"X86ISD::MFENCE", SDT_X86MEMBARRIER,
Expand Down Expand Up @@ -307,6 +310,11 @@ def X86tpause : SDNode<"X86ISD::TPAUSE",
SDTCisVT<2, i32>, SDTCisVT<3, i32>]>,
[SDNPHasChain, SDNPSideEffect]>;

def X86enqcmd : SDNode<"X86ISD::ENQCMD", SDT_X86ENQCMD,
[SDNPHasChain, SDNPSideEffect]>;
def X86enqcmds : SDNode<"X86ISD::ENQCMDS", SDT_X86ENQCMD,
[SDNPHasChain, SDNPSideEffect]>;

//===----------------------------------------------------------------------===//
// X86 Operand Definitions.
//
Expand Down Expand Up @@ -900,6 +908,7 @@ def HasINVPCID : Predicate<"Subtarget->hasINVPCID()">;
def HasCmpxchg8b : Predicate<"Subtarget->hasCmpxchg8b()">;
def HasCmpxchg16b: Predicate<"Subtarget->hasCmpxchg16b()">;
def HasPCONFIG : Predicate<"Subtarget->hasPCONFIG()">;
def HasENQCMD : Predicate<"Subtarget->hasENQCMD()">;
def Not64BitMode : Predicate<"!Subtarget->is64Bit()">,
AssemblerPredicate<"!Mode64Bit", "Not 64-bit mode">;
def In64BitMode : Predicate<"Subtarget->is64Bit()">,
Expand Down Expand Up @@ -2755,6 +2764,37 @@ def MOVDIR64B64 : I<0xF8, MRMSrcMem, (outs), (ins GR64:$dst, i512mem:$src),
T8PD, AdSize64, Requires<[HasMOVDIR64B, In64BitMode]>;
} // SchedRW

//===----------------------------------------------------------------------===//
// ENQCMD/S - Enqueue 64-byte command as user with 64-byte write atomicity
//
let SchedRW = [WriteStore], Defs = [EFLAGS] in {
def ENQCMD16 : I<0xF8, MRMSrcMem, (outs), (ins GR16:$dst, i512mem:$src),
"enqcmd\t{$src, $dst|$dst, $src}",
[(set EFLAGS, (X86enqcmd GR16:$dst, addr:$src))]>,
T8XD, AdSize16, Requires<[HasENQCMD, Not64BitMode]>;
def ENQCMD32 : I<0xF8, MRMSrcMem, (outs), (ins GR32:$dst, i512mem:$src),
"enqcmd\t{$src, $dst|$dst, $src}",
[(set EFLAGS, (X86enqcmd GR32:$dst, addr:$src))]>,
T8XD, AdSize32, Requires<[HasENQCMD]>;
def ENQCMD64 : I<0xF8, MRMSrcMem, (outs), (ins GR64:$dst, i512mem:$src),
"enqcmd\t{$src, $dst|$dst, $src}",
[(set EFLAGS, (X86enqcmd GR64:$dst, addr:$src))]>,
T8XD, AdSize64, Requires<[HasENQCMD, In64BitMode]>;

def ENQCMDS16 : I<0xF8, MRMSrcMem, (outs), (ins GR16:$dst, i512mem:$src),
"enqcmds\t{$src, $dst|$dst, $src}",
[(set EFLAGS, (X86enqcmds GR16:$dst, addr:$src))]>,
T8XS, AdSize16, Requires<[HasENQCMD, Not64BitMode]>;
def ENQCMDS32 : I<0xF8, MRMSrcMem, (outs), (ins GR32:$dst, i512mem:$src),
"enqcmds\t{$src, $dst|$dst, $src}",
[(set EFLAGS, (X86enqcmds GR32:$dst, addr:$src))]>,
T8XS, AdSize32, Requires<[HasENQCMD]>;
def ENQCMDS64 : I<0xF8, MRMSrcMem, (outs), (ins GR64:$dst, i512mem:$src),
"enqcmds\t{$src, $dst|$dst, $src}",
[(set EFLAGS, (X86enqcmds GR64:$dst, addr:$src))]>,
T8XS, AdSize64, Requires<[HasENQCMD, In64BitMode]>;
}

//===----------------------------------------------------------------------===//
// CLZERO Instruction
//
Expand Down
4 changes: 4 additions & 0 deletions llvm/lib/Target/X86/X86Subtarget.h
Expand Up @@ -356,6 +356,9 @@ class X86Subtarget final : public X86GenSubtargetInfo {
/// Processor has AVX-512 bfloat16 floating-point extensions
bool HasBF16 = false;

/// Processor supports ENQCMD instructions
bool HasENQCMD = false;

/// Processor has AVX-512 Bit Algorithms instructions
bool HasBITALG = false;

Expand Down Expand Up @@ -688,6 +691,7 @@ class X86Subtarget final : public X86GenSubtargetInfo {
bool hasSGX() const { return HasSGX; }
bool threewayBranchProfitable() const { return ThreewayBranchProfitable; }
bool hasINVPCID() const { return HasINVPCID; }
bool hasENQCMD() const { return HasENQCMD; }
bool useRetpolineIndirectCalls() const { return UseRetpolineIndirectCalls; }
bool useRetpolineIndirectBranches() const {
return UseRetpolineIndirectBranches;
Expand Down
57 changes: 57 additions & 0 deletions llvm/test/CodeGen/X86/enqcmd-intrinsics.ll
@@ -0,0 +1,57 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+enqcmd | FileCheck %s --check-prefix=X64
; RUN: llc < %s -mtriple=i386-unknown-unknown -mattr=+enqcmd | FileCheck %s --check-prefix=X86
; RUN: llc < %s -mtriple=x86_64-linux-gnux32 -mattr=+enqcmd | FileCheck %s --check-prefix=X32

define i8 @test_enqcmd(i8* %dst, i8* %src) {
entry:
; X64-LABEL: test_enqcmd:
; X64: # %bb.0: # %entry
; X64-NEXT: enqcmd (%rsi), %rdi
; X64-NEXT: sete %al
; X64-NEXT: retq

; X86-LABEL: test_enqcmd:
; X86: # %bb.0: # %entry
; X86-NEXT: movl {{[0-9+]}}(%esp), %eax
; X86-NEXT: movl {{[0-9+]}}(%esp), %ecx
; X86-NEXT: enqcmd (%eax), %ecx
; X86-NEXT: sete %al
; X86-NEXT: retl

; X32-LABEL: test_enqcmd:
; X32: # %bb.0: # %entry
; X32: enqcmd (%esi), %edi
; X32-NEXT: sete %al
; X32-NEXT: retq
%0 = call i8 @llvm.x86.enqcmd(i8* %dst, i8* %src)
ret i8 %0
}

define i8 @test_enqcmds(i8* %dst, i8* %src) {
entry:
; X64-LABEL: test_enqcmds:
; X64: # %bb.0: # %entry
; X64-NEXT: enqcmds (%rsi), %rdi
; X64-NEXT: sete %al
; X64-NEXT: retq

; X86-LABEL: test_enqcmds:
; X86: # %bb.0: # %entry
; X86-NEXT: movl {{[0-9+]}}(%esp), %eax
; X86-NEXT: movl {{[0-9+]}}(%esp), %ecx
; X86-NEXT: enqcmds (%eax), %ecx
; X86-NEXT: sete %al
; X86-NEXT: retl

; X32-LABEL: test_enqcmds:
; X32: # %bb.0: # %entry
; X32: enqcmds (%esi), %edi
; X32-NEXT: sete %al
; X32-NEXT: retq
%0 = call i8 @llvm.x86.enqcmds(i8* %dst, i8* %src)
ret i8 %0
}

declare i8 @llvm.x86.enqcmd(i8*, i8*)
declare i8 @llvm.x86.enqcmds(i8*, i8*)
30 changes: 30 additions & 0 deletions llvm/test/MC/Disassembler/X86/x86-16.txt
Expand Up @@ -806,3 +806,33 @@

#CHECK: movdir64b (%si), %ax
0x66 0x0f 0x38 0xf8 0x04

# CHECK: enqcmd (%bx), %di
0xf2,0x0f,0x38,0xf8,0x3f

# CHECK: enqcmd 8128(%si), %ax
0xf2,0x0f,0x38,0xf8,0x84,0xc0,0x1f

# CHECK: enqcmd -8192(%di), %bx
0xf2,0x0f,0x38,0xf8,0x9d,0x00,0xe0

# CHECK: enqcmd 7408, %cx
0xf2,0x0f,0x38,0xf8,0x0e,0xf0,0x1c

# CHECK: enqcmds (%bx), %di
0xf3,0x0f,0x38,0xf8,0x3f

# CHECK: enqcmds 8128(%si), %ax
0xf3,0x0f,0x38,0xf8,0x84,0xc0,0x1f

# CHECK: enqcmds -8192(%di), %bx
0xf3,0x0f,0x38,0xf8,0x9d,0x00,0xe0

# CHECK: enqcmds 7408, %cx
0xf3,0x0f,0x38,0xf8,0x0e,0xf0,0x1c

# CHECK: enqcmd (%edi), %edi
0x67,0xf2,0x0f,0x38,0xf8,0x3f

# CHECK: enqcmds (%edi), %edi
0x67,0xf3,0x0f,0x38,0xf8,0x3f
42 changes: 42 additions & 0 deletions llvm/test/MC/Disassembler/X86/x86-32.txt
Expand Up @@ -901,3 +901,45 @@

# CHECK: addb $0, 305419896(,%eiz)
0x80 0x04 0x25 0x78 0x56 0x34 0x12 0x00

# CHECK: enqcmd 268435456(%ebp,%eax,8), %esi
0xf2,0x0f,0x38,0xf8,0xb4,0xc5,0x00,0x00,0x00,0x10

# CHECK: enqcmd (%ecx), %edi
0xf2,0x0f,0x38,0xf8,0x39

# CHECK: enqcmd 8128(%ecx), %eax
0xf2,0x0f,0x38,0xf8,0x81,0xc0,0x1f,0x00,0x00

# CHECK: enqcmd -8192(%edx), %ebx
0xf2,0x0f,0x38,0xf8,0x9a,0x00,0xe0,0xff,0xff

# CHECK: enqcmd 485498096, %eax
0xf2,0x0f,0x38,0xf8,0x05,0xf0,0x1c,0xf0,0x1c

# CHECK: enqcmds 268435456(%ebp,%eax,8), %esi
0xf3,0x0f,0x38,0xf8,0xb4,0xc5,0x00,0x00,0x00,0x10

# CHECK: enqcmds (%ecx), %edi
0xf3,0x0f,0x38,0xf8,0x39

# CHECK: enqcmds 8128(%ecx), %eax
0xf3,0x0f,0x38,0xf8,0x81,0xc0,0x1f,0x00,0x00

# CHECK: enqcmds -8192(%edx), %ebx
0xf3,0x0f,0x38,0xf8,0x9a,0x00,0xe0,0xff,0xff

# CHECK: enqcmds 485498096, %eax
0xf3,0x0f,0x38,0xf8,0x05,0xf0,0x1c,0xf0,0x1c

# CHECK: enqcmd (%bx,%di), %di
0x67,0xf2,0x0f,0x38,0xf8,0x39

# CHECK: enqcmd 8128(%bx,%di), %ax
0x67,0xf2,0x0f,0x38,0xf8,0x81,0xc0,0x1f

# CHECK: enqcmds (%bx,%di), %di
0x67,0xf3,0x0f,0x38,0xf8,0x39

# CHECK: enqcmds 8128(%bx,%di), %ax
0x67,0xf3,0x0f,0x38,0xf8,0x81,0xc0,0x1f
60 changes: 60 additions & 0 deletions llvm/test/MC/Disassembler/X86/x86-64.txt
Expand Up @@ -631,3 +631,63 @@
0x63 0x08
# CHECK: movslq (%rax), %cx
0x66 0x63 0x08

# CHECK: enqcmd 485498096, %eax
0x67,0xf2,0x0f,0x38,0xf8,0x04,0x25,0xf0,0x1c,0xf0,0x1c

# CHECK: enqcmd 268435456(%ebp,%r14d,8), %esi
0x67,0xf2,0x42,0x0f,0x38,0xf8,0xb4,0xf5,0x00,0x00,0x00,0x10

# CHECK: enqcmd (%r9d), %edi
0x67,0xf2,0x41,0x0f,0x38,0xf8,0x39

# CHECK: enqcmd 8128(%ecx), %eax
0x67,0xf2,0x0f,0x38,0xf8,0x81,0xc0,0x1f,0x00,0x00

# CHECK: enqcmd -8192(%edx), %ebx
0x67,0xf2,0x0f,0x38,0xf8,0x9a,0x00,0xe0,0xff,0xff

# CHECK: enqcmds 268435456(%ebp,%r14d,8), %esi
0x67,0xf3,0x42,0x0f,0x38,0xf8,0xb4,0xf5,0x00,0x00,0x00,0x10

# CHECK: enqcmds (%r9d), %edi
0x67,0xf3,0x41,0x0f,0x38,0xf8,0x39

# CHECK: enqcmds 8128(%ecx), %eax
0x67,0xf3,0x0f,0x38,0xf8,0x81,0xc0,0x1f,0x00,0x00

# CHECK: enqcmds -8192(%edx), %ebx
0x67,0xf3,0x0f,0x38,0xf8,0x9a,0x00,0xe0,0xff,0xff

# CHECK: enqcmds 485498096, %eax
0x67,0xf3,0x0f,0x38,0xf8,0x04,0x25,0xf0,0x1c,0xf0,0x1c

# CHECK: enqcmd 268435456(%rbp,%r14,8), %rsi
0xf2,0x42,0x0f,0x38,0xf8,0xb4,0xf5,0x00,0x00,0x00,0x10

# CHECK: enqcmd (%r9), %rdi
0xf2,0x41,0x0f,0x38,0xf8,0x39

# CHECK: enqcmd 8128(%rcx), %rax
0xf2,0x0f,0x38,0xf8,0x81,0xc0,0x1f,0x00,0x00

# CHECK: enqcmd -8192(%rdx), %rbx
0xf2,0x0f,0x38,0xf8,0x9a,0x00,0xe0,0xff,0xff

# CHECK: enqcmd 485498096, %rax
0xf2,0x0f,0x38,0xf8,0x04,0x25,0xf0,0x1c,0xf0,0x1c

# CHECK: enqcmds 268435456(%rbp,%r14,8), %rsi
0xf3,0x42,0x0f,0x38,0xf8,0xb4,0xf5,0x00,0x00,0x00,0x10

# CHECK: enqcmds (%r9), %rdi
0xf3,0x41,0x0f,0x38,0xf8,0x39

# CHECK: enqcmds 8128(%rcx), %rax
0xf3,0x0f,0x38,0xf8,0x81,0xc0,0x1f,0x00,0x00

# CHECK: enqcmds -8192(%rdx), %rbx
0xf3,0x0f,0x38,0xf8,0x9a,0x00,0xe0,0xff,0xff

# CHECK: enqcmds 485498096, %rax
0xf3,0x0f,0x38,0xf8,0x04,0x25,0xf0,0x1c,0xf0,0x1c

0 comments on commit 1f67d94

Please sign in to comment.