diff --git a/lldb/include/lldb/Symbol/ClangASTImporter.h b/lldb/include/lldb/Symbol/ClangASTImporter.h index e0448249eba81e..9c0a95beb1e8bc 100644 --- a/lldb/include/lldb/Symbol/ClangASTImporter.h +++ b/lldb/include/lldb/Symbol/ClangASTImporter.h @@ -287,9 +287,8 @@ class ClangASTImporter { ASTContextMetadataSP(new ASTContextMetadata(dst_ctx)); m_metadata_map[dst_ctx] = context_md; return context_md; - } else { - return context_md_iter->second; } + return context_md_iter->second; } ASTContextMetadataSP MaybeGetContextMetadata(clang::ASTContext *dst_ctx) { @@ -297,8 +296,7 @@ class ClangASTImporter { if (context_md_iter != m_metadata_map.end()) return context_md_iter->second; - else - return ASTContextMetadataSP(); + return ASTContextMetadataSP(); } ImporterDelegateSP GetDelegate(clang::ASTContext *dst_ctx, @@ -313,9 +311,8 @@ class ClangASTImporter { ImporterDelegateSP(new ASTImporterDelegate(*this, dst_ctx, src_ctx)); delegates[src_ctx] = delegate; return delegate; - } else { - return delegate_iter->second; } + return delegate_iter->second; } public: diff --git a/lldb/source/Symbol/ClangASTImporter.cpp b/lldb/source/Symbol/ClangASTImporter.cpp index de5448d4317df7..d856443b268aca 100644 --- a/lldb/source/Symbol/ClangASTImporter.cpp +++ b/lldb/source/Symbol/ClangASTImporter.cpp @@ -674,9 +674,8 @@ bool ClangASTImporter::CompleteAndFetchChildren(clang::QualType type) { } } - if (RecordDecl *record_decl = dyn_cast(origin_tag_decl)) { + if (RecordDecl *record_decl = dyn_cast(origin_tag_decl)) record_decl->setHasLoadedFieldsFromExternalStorage(true); - } return true; } @@ -706,9 +705,8 @@ bool ClangASTImporter::CompleteAndFetchChildren(clang::QualType type) { } return true; - } else { - return false; } + return false; } return true; @@ -730,15 +728,12 @@ bool ClangASTImporter::RequireCompleteType(clang::QualType type) { if (ObjCInterfaceDecl *objc_interface_decl = objc_object_type->getInterface()) return CompleteObjCInterfaceDecl(objc_interface_decl); - else - return false; + return false; } - if (const ArrayType *array_type = type->getAsArrayTypeUnsafe()) { + if (const ArrayType *array_type = type->getAsArrayTypeUnsafe()) return RequireCompleteType(array_type->getElementType()); - } - if (const AtomicType *atomic_type = type->getAs()) { + if (const AtomicType *atomic_type = type->getAs()) return RequireCompleteType(atomic_type->getPointeeType()); - } return true; } @@ -748,8 +743,7 @@ ClangASTMetadata *ClangASTImporter::GetDeclMetadata(const clang::Decl *decl) { if (decl_origin.Valid()) return ClangASTContext::GetMetadata(decl_origin.ctx, decl_origin.decl); - else - return ClangASTContext::GetMetadata(&decl->getASTContext(), decl); + return ClangASTContext::GetMetadata(&decl->getASTContext(), decl); } ClangASTImporter::DeclOrigin @@ -762,8 +756,7 @@ ClangASTImporter::GetDeclOrigin(const clang::Decl *decl) { if (iter != origins.end()) return iter->second; - else - return DeclOrigin(); + return DeclOrigin(); } void ClangASTImporter::SetDeclOrigin(const clang::Decl *decl, @@ -777,9 +770,9 @@ void ClangASTImporter::SetDeclOrigin(const clang::Decl *decl, if (iter != origins.end()) { iter->second.decl = original_decl; iter->second.ctx = &original_decl->getASTContext(); - } else { - origins[decl] = DeclOrigin(&original_decl->getASTContext(), original_decl); + return; } + origins[decl] = DeclOrigin(&original_decl->getASTContext(), original_decl); } void ClangASTImporter::RegisterNamespaceMap(const clang::NamespaceDecl *decl, @@ -799,8 +792,7 @@ ClangASTImporter::GetNamespaceMap(const clang::NamespaceDecl *decl) { if (iter != namespace_maps.end()) return iter->second; - else - return NamespaceMapSP(); + return NamespaceMapSP(); } void ClangASTImporter::BuildNamespaceMap(const clang::NamespaceDecl *decl) {