diff --git a/llvm/include/llvm/IR/IRBuilder.h b/llvm/include/llvm/IR/IRBuilder.h index cc84cd1dfd14f..93e1af639b4db 100644 --- a/llvm/include/llvm/IR/IRBuilder.h +++ b/llvm/include/llvm/IR/IRBuilder.h @@ -703,6 +703,19 @@ class IRBuilder : public IRBuilderBase, public Inserter { BranchWeights, Unpredictable)); } + /// \brief Create a conditional 'br Cond, TrueDest, FalseDest' + /// instruction. Copy branch meta data if available. + BranchInst *CreateCondBr(Value *Cond, BasicBlock *True, BasicBlock *False, + Instruction *MDSrc) { + BranchInst *Br = BranchInst::Create(True, False, Cond); + if (MDSrc) { + unsigned WL[4] = {LLVMContext::MD_prof, LLVMContext::MD_unpredictable, + LLVMContext::MD_make_implicit, LLVMContext::MD_dbg}; + Br->copyMetadata(*MDSrc, makeArrayRef(&WL[0], 4)); + } + return Insert(Br); + } + /// \brief Create a switch instruction with the specified value, default dest, /// and with a hint for the number of cases that will be added (for efficient /// allocation). diff --git a/llvm/lib/CodeGen/CodeGenPrepare.cpp b/llvm/lib/CodeGen/CodeGenPrepare.cpp index c87f3bc907306..c6972ec3b33f2 100644 --- a/llvm/lib/CodeGen/CodeGenPrepare.cpp +++ b/llvm/lib/CodeGen/CodeGenPrepare.cpp @@ -4676,15 +4676,20 @@ bool CodeGenPrepare::optimizeSelectInst(SelectInst *SI) { // of the condition, it means that side of the branch goes to the end block // directly and the path originates from the start block from the point of // view of the new PHI. + BasicBlock *TT, *FT; if (TrueBlock == nullptr) { - BranchInst::Create(EndBlock, FalseBlock, SI->getCondition(), SI); + TT = EndBlock; + FT = FalseBlock; TrueBlock = StartBlock; } else if (FalseBlock == nullptr) { - BranchInst::Create(TrueBlock, EndBlock, SI->getCondition(), SI); + TT = TrueBlock; + FT = EndBlock; FalseBlock = StartBlock; } else { - BranchInst::Create(TrueBlock, FalseBlock, SI->getCondition(), SI); + TT = TrueBlock; + FT = FalseBlock; } + IRBuilder<>(SI).CreateCondBr(SI->getCondition(), TT, FT, SI); // The select itself is replaced with a PHI Node. PHINode *PN = PHINode::Create(SI->getType(), 2, "", &EndBlock->front()); diff --git a/llvm/test/CodeGen/X86/cmov-into-branch.ll b/llvm/test/CodeGen/X86/cmov-into-branch.ll index acb5a2bb51f15..c0c6fc4ac2265 100644 --- a/llvm/test/CodeGen/X86/cmov-into-branch.ll +++ b/llvm/test/CodeGen/X86/cmov-into-branch.ll @@ -103,11 +103,11 @@ define i32 @weighted_select3(i32 %a, i32 %b) { ; CHECK-LABEL: weighted_select3: ; CHECK: # BB#0: ; CHECK-NEXT: testl %edi, %edi -; CHECK-NEXT: jne [[LABEL_BB6:.*]] -; CHECK: movl %esi, %edi -; CHECK-NEXT: [[LABEL_BB6]] -; CHECK-NEXT: movl %edi, %eax -; CHECK-NEXT: retq +; CHECK-NEXT: je [[LABEL_BB6:.*]] +; CHECK: movl %edi, %eax +; CHECK: [[LABEL_BB6]] +; CHECK-NEXT: movl %esi, %edi +; CHECK-NEXT: jmp ; %cmp = icmp ne i32 %a, 0 %sel = select i1 %cmp, i32 %a, i32 %b, !prof !2 diff --git a/llvm/test/CodeGen/X86/select_meta.ll b/llvm/test/CodeGen/X86/select_meta.ll new file mode 100644 index 0000000000000..0b2b344114d9e --- /dev/null +++ b/llvm/test/CodeGen/X86/select_meta.ll @@ -0,0 +1,16 @@ +; RUN: llc -mtriple=x86_64-unknown-unknown -print-after-all < %s 2>&1 | FileCheck %s + +; Function Attrs: norecurse nounwind readnone uwtable +define i32 @foo(i32, i32, i32) { + %4 = and i32 %0, 3 + %5 = icmp eq i32 %4, 1 + %6 = select i1 %5, i32 %1, i32 %2, !prof !1 +; CHECK: br {{.*}}label{{.*}}, label{{.*}}, !prof ![[WT:.*]] + ret i32 %6 +} + +!llvm.ident = !{!0} + +!0 = !{!"clang version 4.0.0 (trunk 279683)"} +!1 = !{!"branch_weights", i32 1000, i32 1 } +; CHECK ![[WT]] = !{!"branch_weights", i32 1000, i32 1 }