From 3d4f49fa78aefef333fff8bf0c49bc0fd184b197 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Mon, 28 Jan 2019 19:53:52 +0000 Subject: [PATCH] gn build: Make cmake sync script work on Windows if git is a bat file Differential Revision: https://reviews.llvm.org/D57338 llvm-svn: 352419 --- llvm/utils/gn/build/sync_source_lists_from_cmake.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/llvm/utils/gn/build/sync_source_lists_from_cmake.py b/llvm/utils/gn/build/sync_source_lists_from_cmake.py index 21abe7ef91493..e580f0dfce76e 100755 --- a/llvm/utils/gn/build/sync_source_lists_from_cmake.py +++ b/llvm/utils/gn/build/sync_source_lists_from_cmake.py @@ -18,8 +18,9 @@ def sync_source_lists(): - gn_files = subprocess.check_output( - ['git', 'ls-files', '*BUILD.gn']).splitlines() + # Use shell=True on Windows in case git is a bat file. + gn_files = subprocess.check_output(['git', 'ls-files', '*BUILD.gn'], + shell=os.name == 'nt').splitlines() # Matches e.g. | "foo.cpp",|, captures |foo| in group 1. gn_cpp_re = re.compile(r'^\s*"([^"]+\.(?:cpp|h))",$', re.MULTILINE)