From 430ca14af835a4d8ea927ed6550a99242bebf255 Mon Sep 17 00:00:00 2001 From: Michael Jones Date: Mon, 7 Nov 2022 14:02:32 -0800 Subject: [PATCH] [libc][obvious] fix tests using wrong size for string In the code const char *str = "abc" if you do sizeof(str) you get the size of the pointer, not the string. This patch fixes that mistake. Differential Revision: https://reviews.llvm.org/D137586 --- libc/test/src/stdio/scanf_core/string_reader_test.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libc/test/src/stdio/scanf_core/string_reader_test.cpp b/libc/test/src/stdio/scanf_core/string_reader_test.cpp index 43e65cc1bab6e..4331d488be06a 100644 --- a/libc/test/src/stdio/scanf_core/string_reader_test.cpp +++ b/libc/test/src/stdio/scanf_core/string_reader_test.cpp @@ -23,7 +23,7 @@ TEST(LlvmLibcScanfStringReaderTest, SimpleRead) { __llvm_libc::scanf_core::StringReader str_reader(str); __llvm_libc::scanf_core::Reader reader(&str_reader); - for (size_t i = 0; i < sizeof(str); ++i) { + for (size_t i = 0; i < sizeof("abc"); ++i) { ASSERT_EQ(str[i], reader.getc()); } } @@ -60,7 +60,7 @@ TEST(LlvmLibcScanfStringReaderTest, ReadAndReverse) { } // Check the whole string. - for (size_t i = 0; i < sizeof(str); ++i) { + for (size_t i = 0; i < sizeof("abcDEF123"); ++i) { ASSERT_EQ(str[i], reader.getc()); } }