diff --git a/clang/lib/StaticAnalyzer/Core/SVals.cpp b/clang/lib/StaticAnalyzer/Core/SVals.cpp index bc9c1e40d808a8..2a43a01ff88618 100644 --- a/clang/lib/StaticAnalyzer/Core/SVals.cpp +++ b/clang/lib/StaticAnalyzer/Core/SVals.cpp @@ -174,6 +174,9 @@ class TypeRetrievingVisitor QualType VisitSymbolicRegion(const SymbolicRegion *SR) { return Visit(SR->getSymbol()); } + QualType VisitAllocaRegion(const AllocaRegion *) { + return QualType{Context.VoidPtrTy}; + } QualType VisitTypedRegion(const TypedRegion *TR) { return TR->getLocationType(); } diff --git a/clang/test/Analysis/taint-generic.c b/clang/test/Analysis/taint-generic.c index 84b7cc51dd6df8..9199b3510516e0 100644 --- a/clang/test/Analysis/taint-generic.c +++ b/clang/test/Analysis/taint-generic.c @@ -359,6 +359,25 @@ void testTaintedVLASize(void) { int vla[x]; // expected-warning{{Declared variable-length array (VLA) has tainted size}} } +int testTaintedAllocaMem() { + char x; + void * p; + scanf("%c", &x); + p = __builtin_alloca(1); + __builtin_memcpy(p, &x, 1); + return 5 / *(char*)p; // expected-warning {{Division by a tainted value, possibly zero}} +} + +int testTaintedMallocMem() { + char x; + void * p; + scanf("%c", &x); + p = malloc(1); + __builtin_memcpy(p, &x, 1); + return 5 / *(char*)p; // expected-warning {{Division by a tainted value, possibly zero}} +} + + // This computation used to take a very long time. #define longcmp(a,b,c) { \ a -= c; a ^= c; c += b; b -= a; b ^= (a<<6) | (a >> (32-b)); a += c; c -= b; c ^= b; b += a; \