Skip to content
Permalink
Browse files

Revert r373056: [clang-format] Reference qualifiers in member templat…

…es causing extra indentation

Reason: this breaks unit tests.
llvm-svn: 373059
  • Loading branch information
ilya-biryukov committed Sep 27, 2019
1 parent b8cf059 commit 4627bdedd90de9b5fb9115ac2ffae83f5ce9096e
Showing with 4 additions and 47 deletions.
  1. +4 −12 clang/lib/Format/TokenAnnotator.cpp
  2. +0 −35 clang/unittests/Format/FormatTest.cpp
@@ -65,7 +65,7 @@ class AnnotatingParser {
AnnotatingParser(const FormatStyle &Style, AnnotatedLine &Line,
const AdditionalKeywords &Keywords)
: Style(Style), Line(Line), CurrentToken(Line.First), AutoFound(false),
TrailingReturnFound(false), Keywords(Keywords) {
Keywords(Keywords) {
Contexts.push_back(Context(tok::unknown, 1, /*IsExpression=*/false));
resetTokenMetadata(CurrentToken);
}
@@ -1389,10 +1389,7 @@ class AnnotatingParser {
} else if (Current.is(tok::arrow) && AutoFound && Line.MustBeDeclaration &&
Current.NestingLevel == 0) {
Current.Type = TT_TrailingReturnArrow;
TrailingReturnFound = true;
} else if (Current.is(tok::star) ||
(Current.isOneOf(tok::amp, tok::ampamp) &&
(!Line.MightBeFunctionDecl || TrailingReturnFound))) {
} else if (Current.isOneOf(tok::star, tok::amp, tok::ampamp)) {
Current.Type = determineStarAmpUsage(Current,
Contexts.back().CanBeExpression &&
Contexts.back().IsExpression,
@@ -1415,8 +1412,6 @@ class AnnotatingParser {
Current.Type = TT_ConditionalExpr;
}
} else if (Current.isBinaryOperator() &&
!(Line.MightBeFunctionDecl &&
Current.isOneOf(tok::amp, tok::ampamp)) &&
(!Current.Previous || Current.Previous->isNot(tok::l_square)) &&
(!Current.is(tok::greater) &&
Style.Language != FormatStyle::LK_TextProto)) {
@@ -1491,12 +1486,10 @@ class AnnotatingParser {
// colon after this, this is the only place which annotates the identifier
// as a selector.)
Current.Type = TT_SelectorName;
} else if (Current.isOneOf(tok::identifier, tok::kw_const, tok::amp,
tok::ampamp) &&
} else if (Current.isOneOf(tok::identifier, tok::kw_const) &&
Current.Previous &&
!Current.Previous->isOneOf(tok::equal, tok::at) &&
Line.MightBeFunctionDecl && !TrailingReturnFound &&
Contexts.size() == 1) {
Line.MightBeFunctionDecl && Contexts.size() == 1) {
// Line.MightBeFunctionDecl can only be true after the parentheses of a
// function declaration have been found.
Current.Type = TT_TrailingAnnotation;
@@ -1774,7 +1767,6 @@ class AnnotatingParser {
AnnotatedLine &Line;
FormatToken *CurrentToken;
bool AutoFound;
bool TrailingReturnFound;
const AdditionalKeywords &Keywords;

// Set of "<" tokens that do not open a template parameter list. If parseAngle
verifyFormat("auto lambda = [&a = a]() { a = 2; };", AlignStyle);
}

TEST_F(FormatTest, RefQualifiedTemplateMember) {
FormatStyle AlignStyle = getLLVMStyle();
AlignStyle.AlwaysBreakTemplateDeclarations = FormatStyle::BTDS_Yes;

verifyFormat("struct f {\n"
" template <class T>\n"
" int &foo() & noexcept {}\n"
"};",
AlignStyle);

verifyFormat("struct f {\n"
" template <class T>\n"
" int &foo() && noexcept {}\n"
"};",
AlignStyle);

verifyFormat("struct f {\n"
" template <class T>\n"
" int &foo() const & noexcept {}\n"
"};",
AlignStyle);

verifyFormat("struct f {\n"
" template <class T>\n"
" int &foo() const & noexcept {}\n"
"};",
AlignStyle);

verifyFormat("struct f {\n"
" template <class T>\n"
" auto foo() && noexcept -> int & {}\n"
"};",
AlignStyle);
}

} // end namespace
} // end namespace format
} // end namespace clang

0 comments on commit 4627bde

Please sign in to comment.
You can’t perform that action at this time.