From 4eafb5f57c9dc140a3bc32fd13a36619bcf360d0 Mon Sep 17 00:00:00 2001 From: Yusuke MINATO Date: Fri, 15 Sep 2023 18:30:06 +0900 Subject: [PATCH] [flang][hlfir] Add hlfir.minval intrinsic (#66306) Adds a new HLFIR operation for the MINVAL intrinsic according to the design set out in flang/docs/HighLevelFIR.md. --- .../include/flang/Optimizer/HLFIR/HLFIROps.td | 27 ++ flang/lib/Lower/HlfirIntrinsics.cpp | 4 + flang/lib/Optimizer/HLFIR/IR/HLFIROps.cpp | 25 ++ .../HLFIR/Transforms/LowerHLFIRIntrinsics.cpp | 12 +- flang/test/HLFIR/invalid.fir | 78 ++++++ flang/test/HLFIR/memory-effects.fir | 15 + flang/test/HLFIR/minval-lowering.fir | 218 +++++++++++++++ flang/test/HLFIR/minval.fir | 249 +++++++++++++++++ flang/test/Lower/HLFIR/minval.f90 | 262 ++++++++++++++++++ 9 files changed, 887 insertions(+), 3 deletions(-) create mode 100644 flang/test/HLFIR/minval-lowering.fir create mode 100644 flang/test/HLFIR/minval.fir create mode 100644 flang/test/Lower/HLFIR/minval.f90 diff --git a/flang/include/flang/Optimizer/HLFIR/HLFIROps.td b/flang/include/flang/Optimizer/HLFIR/HLFIROps.td index aef3b1d976f16..1f584d6afd8fb 100644 --- a/flang/include/flang/Optimizer/HLFIR/HLFIROps.td +++ b/flang/include/flang/Optimizer/HLFIR/HLFIROps.td @@ -431,6 +431,33 @@ def hlfir_MaxvalOp : hlfir_Op<"maxval", [AttrSizedOperandSegments, let hasVerifier = 1; } +def hlfir_MinvalOp : hlfir_Op<"minval", [AttrSizedOperandSegments, + DeclareOpInterfaceMethods, + DeclareOpInterfaceMethods]> { + let summary = "MINVAL transformational intrinsic"; + let description = [{ + Minimum value(s) of an array. + If DIM is absent, the result is a scalar. + If DIM is present, the result is an array of rank n-1, where n is the rank of ARRAY. + }]; + + let arguments = (ins + AnyFortranArrayObject:$array, + Optional:$dim, + Optional:$mask, + DefaultValuedAttr:$fastmath + ); + + let results = (outs AnyFortranValue); + + let assemblyFormat = [{ + $array (`dim` $dim^)? (`mask` $mask^)? attr-dict `:` functional-type(operands, results) + }]; + + let hasVerifier = 1; +} + def hlfir_ProductOp : hlfir_Op<"product", [AttrSizedOperandSegments, DeclareOpInterfaceMethods, DeclareOpInterfaceMethods]> { diff --git a/flang/lib/Lower/HlfirIntrinsics.cpp b/flang/lib/Lower/HlfirIntrinsics.cpp index 4d25c59bf79ca..62f63e376c815 100644 --- a/flang/lib/Lower/HlfirIntrinsics.cpp +++ b/flang/lib/Lower/HlfirIntrinsics.cpp @@ -89,6 +89,7 @@ class HlfirReductionIntrinsic : public HlfirTransformationalIntrinsic { using HlfirSumLowering = HlfirReductionIntrinsic; using HlfirProductLowering = HlfirReductionIntrinsic; using HlfirMaxvalLowering = HlfirReductionIntrinsic; +using HlfirMinvalLowering = HlfirReductionIntrinsic; using HlfirAnyLowering = HlfirReductionIntrinsic; using HlfirAllLowering = HlfirReductionIntrinsic; @@ -356,6 +357,9 @@ std::optional Fortran::lower::lowerHlfirIntrinsic( if (name == "maxval") return HlfirMaxvalLowering{builder, loc}.lower(loweredActuals, argLowering, stmtResultType); + if (name == "minval") + return HlfirMinvalLowering{builder, loc}.lower(loweredActuals, argLowering, + stmtResultType); if (mlir::isa(stmtResultType)) { if (name == "min") return HlfirCharExtremumLowering{builder, loc, diff --git a/flang/lib/Optimizer/HLFIR/IR/HLFIROps.cpp b/flang/lib/Optimizer/HLFIR/IR/HLFIROps.cpp index 531a40c8dd4f9..760f7b343bdc7 100644 --- a/flang/lib/Optimizer/HLFIR/IR/HLFIROps.cpp +++ b/flang/lib/Optimizer/HLFIR/IR/HLFIROps.cpp @@ -845,6 +845,31 @@ void hlfir::MaxvalOp::getEffects( getIntrinsicEffects(getOperation(), effects); } +//===----------------------------------------------------------------------===// +// MinvalOp +//===----------------------------------------------------------------------===// + +mlir::LogicalResult hlfir::MinvalOp::verify() { + mlir::Operation *op = getOperation(); + + auto results = op->getResultTypes(); + assert(results.size() == 1); + + auto resultExpr = mlir::dyn_cast(results[0]); + if (resultExpr && mlir::isa(resultExpr.getEleTy())) { + return verifyCharacterReductionOp(this); + } else { + return verifyNumericalReductionOp(this); + } +} + +void hlfir::MinvalOp::getEffects( + llvm::SmallVectorImpl< + mlir::SideEffects::EffectInstance> + &effects) { + getIntrinsicEffects(getOperation(), effects); +} + //===----------------------------------------------------------------------===// // SetLengthOp //===----------------------------------------------------------------------===// diff --git a/flang/lib/Optimizer/HLFIR/Transforms/LowerHLFIRIntrinsics.cpp b/flang/lib/Optimizer/HLFIR/Transforms/LowerHLFIRIntrinsics.cpp index b6045fdef0987..f2628fcb970bc 100644 --- a/flang/lib/Optimizer/HLFIR/Transforms/LowerHLFIRIntrinsics.cpp +++ b/flang/lib/Optimizer/HLFIR/Transforms/LowerHLFIRIntrinsics.cpp @@ -222,6 +222,8 @@ class HlfirReductionIntrinsicConversion : public HlfirIntrinsicConversion { opName = "product"; } else if constexpr (std::is_same_v) { opName = "maxval"; + } else if constexpr (std::is_same_v) { + opName = "minval"; } else if constexpr (std::is_same_v) { opName = "any"; } else if constexpr (std::is_same_v) { @@ -241,7 +243,8 @@ class HlfirReductionIntrinsicConversion : public HlfirIntrinsicConversion { if constexpr (std::is_same_v || std::is_same_v || - std::is_same_v) { + std::is_same_v || + std::is_same_v) { args = buildNumericalArgs(operation, i32, logicalType, rewriter, opName); } else { args = buildLogicalArgs(operation, i32, logicalType, rewriter, opName); @@ -264,6 +267,8 @@ using ProductOpConversion = HlfirReductionIntrinsicConversion; using MaxvalOpConversion = HlfirReductionIntrinsicConversion; +using MinvalOpConversion = HlfirReductionIntrinsicConversion; + using AnyOpConversion = HlfirReductionIntrinsicConversion; using AllOpConversion = HlfirReductionIntrinsicConversion; @@ -440,7 +445,8 @@ class LowerHLFIRIntrinsics .insert(context); + DotProductOpConversion, MaxvalOpConversion, MinvalOpConversion>( + context); mlir::ConversionTarget target(*context); target.addLegalDialect(); + hlfir::MaxvalOp, hlfir::MinvalOp>(); target.markUnknownOpDynamicallyLegal( [](mlir::Operation *) { return true; }); if (mlir::failed( diff --git a/flang/test/HLFIR/invalid.fir b/flang/test/HLFIR/invalid.fir index 00fe309884395..112ab4be57f6b 100644 --- a/flang/test/HLFIR/invalid.fir +++ b/flang/test/HLFIR/invalid.fir @@ -470,6 +470,84 @@ func.func @bad_maxval13(%arg0: !hlfir.expr>, %arg1: i32){ %0 = hlfir.maxval %arg0 dim %arg1 : (!hlfir.expr>, i32) -> !hlfir.expr> } +// ----- +func.func @bad_minval1(%arg0: !hlfir.expr, %arg1: i32, %arg2: !fir.box>) { + // expected-error@+1 {{'hlfir.minval' op result must have the same element type as ARRAY argument}} + %0 = hlfir.minval %arg0 dim %arg1 mask %arg2 : (!hlfir.expr, i32, !fir.box>) -> f32 +} + +// ----- +func.func @bad_minval2(%arg0: !hlfir.expr, %arg1: i32, %arg2: !fir.box>>) { + // expected-warning@+1 {{MASK must be conformable to ARRAY}} + %0 = hlfir.minval %arg0 dim %arg1 mask %arg2 : (!hlfir.expr, i32, !fir.box>>) -> !hlfir.expr +} + +// ----- +func.func @bad_minval3(%arg0: !hlfir.expr, %arg1: i32, %arg2: !fir.box>>) { + // expected-warning@+1 {{MASK must be conformable to ARRAY}} + %0 = hlfir.minval %arg0 dim %arg1 mask %arg2 : (!hlfir.expr, i32, !fir.box>>) -> !hlfir.expr +} + +// ----- +func.func @bad_minval4(%arg0: !hlfir.expr, %arg1: i32, %arg2: !fir.box>) { + // expected-error@+1 {{'hlfir.minval' op result rank must be one less than ARRAY}} + %0 = hlfir.minval %arg0 dim %arg1 mask %arg2 : (!hlfir.expr, i32, !fir.box>) -> !hlfir.expr +} + +// ----- +func.func @bad_minval5(%arg0: !hlfir.expr, %arg1: i32, %arg2: !fir.box>) { + // expected-error@+1 {{'hlfir.minval' op result must be of numerical scalar type}} + %0 = hlfir.minval %arg0 dim %arg1 mask %arg2 : (!hlfir.expr, i32, !fir.box>) -> !fir.logical<4> +} + +// ----- +func.func @bad_minval6(%arg0: !hlfir.expr, %arg1: i32){ + // expected-error@+1 {{'hlfir.minval' op result must be an array}} + %0 = hlfir.minval %arg0 dim %arg1 : (!hlfir.expr, i32) -> !hlfir.expr +} + +// ----- +func.func @bad_minval7(%arg0: !hlfir.expr){ + // expected-error@+1 {{'hlfir.minval' op result must be of numerical scalar type}} + %0 = hlfir.minval %arg0 : (!hlfir.expr) -> !hlfir.expr +} + +// ----- +func.func @bad_minval8(%arg0: !hlfir.expr>, %arg1: i32, %arg2: !fir.box>) { + // expected-error@+1 {{'hlfir.minval' op result must have the same element type as ARRAY argument}} + %0 = hlfir.minval %arg0 dim %arg1 mask %arg2 : (!hlfir.expr>, i32, !fir.box>) -> i32 +} + +// ----- +func.func @bad_minval9(%arg0: !hlfir.expr>, %arg1: i32, %arg2: !fir.box>>) { + // expected-warning@+1 {{MASK must be conformable to ARRAY}} + %0 = hlfir.minval %arg0 dim %arg1 mask %arg2 : (!hlfir.expr>, i32, !fir.box>>) -> !hlfir.expr> +} + +// ----- +func.func @bad_minval10(%arg0: !hlfir.expr>, %arg1: i32, %arg2: !fir.box>>) { + // expected-warning@+1 {{MASK must be conformable to ARRAY}} + %0 = hlfir.minval %arg0 dim %arg1 mask %arg2 : (!hlfir.expr>, i32, !fir.box>>) -> !hlfir.expr> +} + +// ----- +func.func @bad_minval11(%arg0: !hlfir.expr>, %arg1: i32, %arg2: !fir.box>) { + // expected-error@+1 {{'hlfir.minval' op result rank must be one less than ARRAY}} + %0 = hlfir.minval %arg0 dim %arg1 mask %arg2 : (!hlfir.expr>, i32, !fir.box>) -> !hlfir.expr> +} + +// ----- +func.func @bad_minval12(%arg0: !hlfir.expr>, %arg1: i32, %arg2: !fir.box>) { + // expected-error@+1 {{'hlfir.minval' op result must be scalar character}} + %0 = hlfir.minval %arg0 dim %arg1 mask %arg2 : (!hlfir.expr>, i32, !fir.box>) -> !hlfir.expr> +} + +// ----- +func.func @bad_minval13(%arg0: !hlfir.expr>, %arg1: i32){ + // expected-error@+1 {{'hlfir.minval' op result must be an array}} + %0 = hlfir.minval %arg0 dim %arg1 : (!hlfir.expr>, i32) -> !hlfir.expr> +} + // ----- func.func @bad_product1(%arg0: !hlfir.expr, %arg1: i32, %arg2: !fir.box>) { // expected-error@+1 {{'hlfir.product' op result must have the same element type as ARRAY argument}} diff --git a/flang/test/HLFIR/memory-effects.fir b/flang/test/HLFIR/memory-effects.fir index f30d1b86c4d86..4b2a0d575db1a 100644 --- a/flang/test/HLFIR/memory-effects.fir +++ b/flang/test/HLFIR/memory-effects.fir @@ -107,6 +107,21 @@ func.func @maxval_effects(%arg0: !fir.ref>, %arg1: i32) { return } +func.func @minval_no_effects(%arg0: !hlfir.expr) { +// expected-remark@+1 {{operation has no memory effects}} + %minval = hlfir.minval %arg0 : (!hlfir.expr) -> f32 +// expected-remark@+1 {{operation has no memory effects}} + return +} + +func.func @minval_effects(%arg0: !fir.ref>, %arg1: i32) { +// expected-remark@+2 {{found an instance of 'allocate' on a value, on resource ''}} +// expected-remark@+1 {{found an instance of 'read' on a value, on resource ''}} + %minval = hlfir.minval %arg0 dim %arg1 : (!fir.ref>, i32) -> !hlfir.expr<2xf32> +// expected-remark@+1 {{operation has no memory effects}} + return +} + func.func @dot_product_no_effects(%arg0: !hlfir.expr, %arg1: !hlfir.expr) { // expected-remark@+1 {{operation has no memory effects}} %0 = hlfir.dot_product %arg0 %arg1 : (!hlfir.expr, !hlfir.expr) -> f32 diff --git a/flang/test/HLFIR/minval-lowering.fir b/flang/test/HLFIR/minval-lowering.fir new file mode 100644 index 0000000000000..fc8fe92dc08a2 --- /dev/null +++ b/flang/test/HLFIR/minval-lowering.fir @@ -0,0 +1,218 @@ +// Test hlfir.minval operation lowering to fir runtime call +// RUN: fir-opt %s -lower-hlfir-intrinsics | FileCheck %s + +// simple one argument minval +func.func @_QPminval1(%arg0: !fir.box> {fir.bindc_name = "a"}, %arg1: !fir.ref {fir.bindc_name = "s"}) { + %0:2 = hlfir.declare %arg0 {uniq_name = "_QFminval1Ea"} : (!fir.box>) -> (!fir.box>, !fir.box>) + %1:2 = hlfir.declare %arg1 {uniq_name = "_QFminval1Es"} : (!fir.ref) -> (!fir.ref, !fir.ref) + %2 = hlfir.minval %0#0 {fastmath = #arith.fastmath} : (!fir.box>) -> i32 + hlfir.assign %2 to %1#0 : i32, !fir.ref + return +} +// CHECK-LABEL: func.func @_QPminval1( +// CHECK: %[[ARG0:.*]]: !fir.box> +// CHECK: %[[ARG1:.*]]: !fir.ref +// CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +// CHECK-DAG: %[[RES:.*]]:2 = hlfir.declare %[[ARG1]] +// CHECK-DAG: %[[MASK:.*]] = fir.absent !fir.box +// CHECK-DAG: %[[ARRAY_ARG:.*]] = fir.convert %[[ARRAY]]#1 : (!fir.box>) -> !fir.box +// CHECK-DAG: %[[MASK_ARG:.*]] = fir.convert %[[MASK]] : (!fir.box) -> !fir.box +// CHECK: %[[RET:.*]] = fir.call @_FortranAMinvalInteger4(%[[ARRAY_ARG]], %[[LOC_STR:.*]], %[[LOC_N:.*]], %[[INT:.*]], %[[MASK_ARG]]) fastmath : (!fir.box, !fir.ref, i32, i32, !fir.box) -> i32 +// CHECK-NEXT: hlfir.assign %[[RET]] to %[[RES]]#0 : i32, !fir.ref +// CHECK-NEXT: return +// CHECK-NEXT: } + +// minval with a by-ref dimension of index type +func.func @_QPminval2(%arg0: !fir.box> {fir.bindc_name = "a"}, %arg1: !fir.box> {fir.bindc_name = "s"}, %arg2: !fir.ref {fir.bindc_name = "d"}) { + %0:2 = hlfir.declare %arg0 {uniq_name = "_QFminval2Ea"} : (!fir.box>) -> (!fir.box>, !fir.box>) + %1:2 = hlfir.declare %arg2 {uniq_name = "_QFminval2Ed"} : (!fir.ref) -> (!fir.ref, !fir.ref) + %2:2 = hlfir.declare %arg1 {uniq_name = "_QFminval2Es"} : (!fir.box>) -> (!fir.box>, !fir.box>) + %3 = fir.load %1#0 : !fir.ref + %4 = hlfir.minval %0#0 dim %3#0 {fastmath = #arith.fastmath} : (!fir.box>, index) -> !hlfir.expr + hlfir.assign %4 to %2#0 : !hlfir.expr, !fir.box> + hlfir.destroy %4 : !hlfir.expr + return +} +// CHECK-LABEL: func.func @_QPminval2( +// CHECK: %[[ARG0:.*]]: !fir.box> +// CHECK: %[[ARG1:.*]]: !fir.box> +// CHECK: %[[ARG2:.*]]: !fir.ref +// CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +// CHECK-DAG: %[[RES:.*]]:2 = hlfir.declare %[[ARG1]] +// CHECK-DAG: %[[DIM_VAR:.*]]:2 = hlfir.declare %[[ARG2]] + +// CHECK-DAG: %[[RET_BOX:.*]] = fir.alloca !fir.box>> +// CHECK-DAG: %[[RET_ADDR:.*]] = fir.zero_bits !fir.heap> +// CHECK-DAG: %[[C0:.*]] = arith.constant 0 : index +// CHECK-DAG: %[[RET_SHAPE:.*]] = fir.shape %[[C0]] : (index) -> !fir.shape<1> +// CHECK-DAG: %[[RET_EMBOX:.*]] = fir.embox %[[RET_ADDR]](%[[RET_SHAPE]]) +// CHECK-DAG: fir.store %[[RET_EMBOX]] to %[[RET_BOX]] + +// CHECK-DAG: %[[MASK:.*]] = fir.absent !fir.box +// CHECK-DAG: %[[DIM_IDX:.*]] = fir.load %[[DIM_VAR]]#0 : !fir.ref +// CHECK-DAG: %[[DIM:.*]] = fir.convert %[[DIM_IDX]] : (index) -> i32 + +// CHECK-DAG: %[[RET_ARG:.*]] = fir.convert %[[RET_BOX]] +// CHECK-DAG: %[[ARRAY_ARG:.*]] = fir.convert %[[ARRAY]]#1 : (!fir.box>) -> !fir.box +// CHECK-DAG: %[[MASK_ARG:.*]] = fir.convert %[[MASK]] : (!fir.box) -> !fir.box +// CHECK: %[[NONE:.*]] = fir.call @_FortranAMinvalDim(%[[RET_ARG]], %[[ARRAY_ARG]], %[[DIM]], %[[LOC_STR:.*]], %[[LOC_N:.*]], %[[MASK_ARG]]) fastmath : (!fir.ref>, !fir.box, i32, !fir.ref, i32, !fir.box) -> none + +// CHECK: %[[RET:.*]] = fir.load %[[RET_BOX]] +// CHECK: %[[BOX_DIMS:.*]]:3 = fir.box_dims %[[RET]] +// CHECK-NEXT: %[[ADDR:.*]] = fir.box_addr %[[RET]] +// CHECK-NEXT: %[[SHIFT:.*]] = fir.shape_shift %[[BOX_DIMS]]#0, %[[BOX_DIMS]]#1 +// TODO: fix alias analysis in hlfir.assign bufferization +// CHECK-NEXT: %[[TMP:.*]]:2 = hlfir.declare %[[ADDR]](%[[SHIFT]]) {uniq_name = ".tmp.intrinsic_result"} +// CHECK: %[[TRUE:.*]] = arith.constant true +// CHECK: %[[ASEXPR:.*]] = hlfir.as_expr %[[TMP]]#0 move %[[TRUE]] : (!fir.box>, i1) -> !hlfir.expr +// CHECK: hlfir.assign %[[ASEXPR]] to %[[RES]]#0 +// CHECK: hlfir.destroy %[[ASEXPR]] +// CHECK-NEXT: return +// CHECK-NEXT: } + +// minval with scalar mask +func.func @_QPminval3(%arg0: !fir.box> {fir.bindc_name = "a"}, %arg1: !fir.ref {fir.bindc_name = "s"}, %arg2: !fir.ref> {fir.bindc_name = "m"}) { + %0:2 = hlfir.declare %arg0 {uniq_name = "_QFminval3Ea"} : (!fir.box>) -> (!fir.box>, !fir.box>) + %1:2 = hlfir.declare %arg2 {uniq_name = "_QFminval3Em"} : (!fir.ref>) -> (!fir.ref>, !fir.ref>) + %2:2 = hlfir.declare %arg1 {uniq_name = "_QFminval3Es"} : (!fir.ref) -> (!fir.ref, !fir.ref) + %3 = hlfir.minval %0#0 mask %1#0 {fastmath = #arith.fastmath} : (!fir.box>, !fir.ref>) -> i32 + hlfir.assign %3 to %2#0 : i32, !fir.ref + return +} +// CHECK-LABEL: func.func @_QPminval3( +// CHECK: %[[ARG0:.*]]: !fir.box> +// CHECK: %[[ARG1:.*]]: !fir.ref +// CHECK: %[[ARG2:.*]]: !fir.ref> +// CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +// CHECK-DAG: %[[RES:.*]]:2 = hlfir.declare %[[ARG1]] +// CHECK-DAG: %[[MASK:.*]]:2 = hlfir.declare %[[ARG2]] +// CHECK-DAG: %[[MASK_BOX:.*]] = fir.embox %[[MASK]]#1 : (!fir.ref>) -> !fir.box> +// CHECK-DAG: %[[ARRAY_ARG:.*]] = fir.convert %[[ARRAY]]#1 : (!fir.box>) -> !fir.box +// CHECK-DAG: %[[MASK_ARG:.*]] = fir.convert %[[MASK_BOX]] : (!fir.box>) -> !fir.box +// CHECK: %[[RET:.*]] = fir.call @_FortranAMinvalInteger4(%[[ARRAY_ARG]], %[[LOC_STR:.*]], %[[LOC_N:.*]], %[[INT:.*]], %[[MASK_ARG]]) fastmath : (!fir.box, !fir.ref, i32, i32, !fir.box) -> i32 +// CHECK-NEXT: hlfir.assign %[[RET]] to %[[RES]]#0 : i32, !fir.ref +// CHECK-NEXT: return +// CHECK-NEXT: } + +// minval with array mask +func.func @_QPminval4(%arg0: !fir.box> {fir.bindc_name = "a"}, %arg1: !fir.ref {fir.bindc_name = "s"}, %arg2: !fir.box>> {fir.bindc_name = "m"}) { + %0:2 = hlfir.declare %arg0 {uniq_name = "_QFminval4Ea"} : (!fir.box>) -> (!fir.box>, !fir.box>) + %1:2 = hlfir.declare %arg2 {uniq_name = "_QFminval4Em"} : (!fir.box>>) -> (!fir.box>>, !fir.box>>) + %2:2 = hlfir.declare %arg1 {uniq_name = "_QFminval4Es"} : (!fir.ref) -> (!fir.ref, !fir.ref) + %3 = hlfir.minval %0#0 mask %1#0 {fastmath = #arith.fastmath} : (!fir.box>, !fir.box>>) -> i32 + hlfir.assign %3 to %2#0 : i32, !fir.ref + return +} +// CHECK-LABEL: func.func @_QPminval4( +// CHECK: %[[ARG0:.*]]: !fir.box> +// CHECK: %[[ARG1:.*]]: !fir.ref +// CHECK: %[[ARG2:.*]]: !fir.box>> +// CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +// CHECK-DAG: %[[RES:.*]]:2 = hlfir.declare %[[ARG1]] +// CHECK-DAG: %[[MASK:.*]]:2 = hlfir.declare %[[ARG2]] +// CHECK-DAG: %[[ARRAY_ARG:.*]] = fir.convert %[[ARRAY]]#1 : (!fir.box>) -> !fir.box +// CHECK-DAG: %[[MASK_ARG:.*]] = fir.convert %[[MASK]]#1 : (!fir.box>>) -> !fir.box +// CHECK: %[[RET:.*]] = fir.call @_FortranAMinvalInteger4(%[[ARRAY_ARG]], %[[LOC_STR:.*]], %[[LOC_N:.*]], %[[INT:.*]], %[[MASK_ARG]]) fastmath : (!fir.box, !fir.ref, i32, i32, !fir.box) -> i32 +// CHECK-NEXT: hlfir.assign %[[RET]] to %[[RES]]#0 : i32, !fir.ref +// CHECK-NEXT: return +// CHECK-NEXT: } + +fir.global internal @_QFminval5Ea : !fir.array<2x2xi32> { + %0 = fir.undefined !fir.array<2x2xi32> + %c1_i32 = arith.constant 1 : i32 + %1 = fir.insert_value %0, %c1_i32, [0 : index, 0 : index] : (!fir.array<2x2xi32>, i32) -> !fir.array<2x2xi32> + %c2_i32 = arith.constant 2 : i32 + %2 = fir.insert_value %1, %c2_i32, [1 : index, 0 : index] : (!fir.array<2x2xi32>, i32) -> !fir.array<2x2xi32> + %c3_i32 = arith.constant 3 : i32 + %3 = fir.insert_value %2, %c3_i32, [0 : index, 1 : index] : (!fir.array<2x2xi32>, i32) -> !fir.array<2x2xi32> + %c4_i32 = arith.constant 4 : i32 + %4 = fir.insert_value %3, %c4_i32, [1 : index, 1 : index] : (!fir.array<2x2xi32>, i32) -> !fir.array<2x2xi32> + %c2 = arith.constant 2 : index + %c2_0 = arith.constant 2 : index + fir.has_value %4 : !fir.array<2x2xi32> +} + +// 3 argument minval, using local variables +func.func @_QPminval5(%arg0: !fir.ref> {fir.bindc_name = "s"}) { + %0 = fir.address_of(@_QFminval5Ea) : !fir.ref> + %c2 = arith.constant 2 : index + %c2_0 = arith.constant 2 : index + %1 = fir.shape %c2, %c2_0 : (index, index) -> !fir.shape<2> + %2:2 = hlfir.declare %0(%1) {uniq_name = "_QFminval5Ea"} : (!fir.ref>, !fir.shape<2>) -> (!fir.ref>, !fir.ref>) + %c2_1 = arith.constant 2 : index + %3 = fir.shape %c2_1 : (index) -> !fir.shape<1> + %4:2 = hlfir.declare %arg0(%3) {uniq_name = "_QFminval5Es"} : (!fir.ref>, !fir.shape<1>) -> (!fir.ref>, !fir.ref>) + %c1_i32 = arith.constant 1 : i32 + %true = arith.constant true + %5 = hlfir.minval %2#0 dim %c1_i32 mask %true {fastmath = #arith.fastmath} : (!fir.ref>, i32, i1) -> !hlfir.expr<2xi32> + hlfir.assign %5 to %4#0 : !hlfir.expr<2xi32>, !fir.ref> + hlfir.destroy %5 : !hlfir.expr<2xi32> + return +} +// CHECK-LABEL: func.func @_QPminval5( +// CHECK: %[[ARG0:.*]]: !fir.ref> +// CHECK-DAG: %[[RET_BOX:.*]] = fir.alloca !fir.box>> +// CHECK-DAG: %[[RET_ADDR:.*]] = fir.zero_bits !fir.heap> +// CHECK-DAG: %[[C0:.*]] = arith.constant 0 : index +// CHECK-DAG: %[[RET_SHAPE:.*]] = fir.shape %[[C0]] : (index) -> !fir.shape<1> +// CHECK-DAG: %[[RET_EMBOX:.*]] = fir.embox %[[RET_ADDR]](%[[RET_SHAPE]]) +// CHECK-DAG: fir.store %[[RET_EMBOX]] to %[[RET_BOX]] + +// CHECK-DAG: %[[RES_VAR:.*]] = hlfir.declare %[[ARG0]](%[[RES_SHAPE:.*]]) + +// CHECK-DAG: %[[MASK_ALLOC:.*]] = fir.alloca !fir.logical<4> +// CHECK-DAG: %[[TRUE:.*]] = arith.constant true +// CHECK-DAG: %[[MASK_VAL:.*]] = fir.convert %[[TRUE]] : (i1) -> !fir.logical<4> +// CHECK-DAG: fir.store %[[MASK_VAL]] to %[[MASK_ALLOC]] : !fir.ref> +// CHECK-DAG: %[[MASK_BOX:.*]] = fir.embox %[[MASK_ALLOC]] + +// CHECK-DAG: %[[ARRAY_ADDR:.*]] = fir.address_of +// CHECK-DAG: %[[ARRAY_VAR:.*]]:2 = hlfir.declare %[[ARRAY_ADDR]](%[[ARRAY_SHAPE:.*]]) +// CHECK-DAG: %[[ARRAY_BOX:.*]] = fir.embox %[[ARRAY_VAR]]#1(%[[ARRAY_SHAPE:.*]]) + +// CHECK-DAG: %[[DIM:.*]] = arith.constant 1 : i32 + +// CHECK-DAG: %[[RET_ARG:.*]] = fir.convert %[[RET_BOX]] +// CHECK-DAG: %[[ARRAY_ARG:.*]] = fir.convert %[[ARRAY_BOX]] : (!fir.box>) -> !fir.box +// CHECK-DAG: %[[MASK_ARG:.*]] = fir.convert %[[MASK_BOX]] : (!fir.box>) -> !fir.box +// CHECK: %[[NONE:.*]] = fir.call @_FortranAMinvalDim(%[[RET_ARG]], %[[ARRAY_ARG]], %[[DIM]], %[[LOC_STR:.*]], %[[LOC_N:.*]], %[[MASK_ARG]]) fastmath : (!fir.ref>, !fir.box, i32, !fir.ref, i32, !fir.box) -> none + +// simple one argument minval for character +func.func @_QPminval6(%arg0: !fir.box>> {fir.bindc_name = "a"}, %arg1: !fir.boxchar<1> {fir.bindc_name = "s"}) { + %0:2 = hlfir.declare %arg0 {uniq_name = "_QFminval6Ea"} : (!fir.box>>) -> (!fir.box>>, !fir.box>>) + %1:2 = fir.unboxchar %arg1 : (!fir.boxchar<1>) -> (!fir.ref>, index) + %2:2 = hlfir.declare %1#0 typeparams %1#1 {uniq_name = "_QFminval6Es"} : (!fir.ref>, index) -> (!fir.boxchar<1>, !fir.ref>) + %3 = hlfir.minval %0#0 {fastmath = #arith.fastmath} : (!fir.box>>) -> !hlfir.expr> + hlfir.assign %3 to %2#0 : !hlfir.expr>, !fir.boxchar<1> + hlfir.destroy %3 : !hlfir.expr> + return +} +// CHECK-LABEL: func.func @_QPminval6( +// CHECK: %[[ARG0:.*]]: !fir.box>> +// CHECK: %[[ARG1:.*]]: !fir.boxchar<1> +// CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +// CHECK-DAG: %[[UNBOXED:.*]]:2 = fir.unboxchar %[[ARG1]] +// CHECK-DAG: %[[RES:.*]]:2 = hlfir.declare %[[UNBOXED]]#0 typeparams %[[UNBOXED]]#1 + +// CHECK-DAG: %[[MASK:.*]] = fir.absent !fir.box +// CHECK-DAG: %[[RET_BOX:.*]] = fir.alloca !fir.box>> +// CHECK-DAG: %[[RET_ADDR:.*]] = fir.zero_bits !fir.heap> +// CHECK-DAG: %[[C0:.*]] = arith.constant 0 : index +// CHECK-DAG: %[[RET_EMBOX:.*]] = fir.embox %[[RET_ADDR]] typeparams %[[C0]] +// CHECK-DAG: fir.store %[[RET_EMBOX]] to %[[RET_BOX]] + +// CHECK-DAG: %[[RET_ARG:.*]] = fir.convert %[[RET_BOX]] +// CHECK-DAG: %[[ARRAY_ARG:.*]] = fir.convert %[[ARRAY]]#1 : (!fir.box>>) -> !fir.box +// CHECK-DAG: %[[MASK_ARG:.*]] = fir.convert %[[MASK]] : (!fir.box) -> !fir.box +// CHECK: %[[NONE:.*]] = fir.call @_FortranAMinvalCharacter(%[[RET_ARG]], %[[ARRAY_ARG]], %[[LOC_STR:.*]], %[[LOC_N:.*]], %[[MASK_ARG]]) fastmath : (!fir.ref>, !fir.box, !fir.ref, i32, !fir.box) -> none + +// CHECK: %[[RET:.*]] = fir.load %[[RET_BOX]] +// CHECK: %[[BOX_ELESIZE:.*]] = fir.box_elesize %[[RET]] +// CHECK-NEXT: %[[ADDR:.*]] = fir.box_addr %[[RET]] +// CHECK-NEXT: %[[TMP:.*]]:2 = hlfir.declare %[[ADDR]] typeparams %[[BOX_ELESIZE]] {uniq_name = ".tmp.intrinsic_result"} +// CHECK: %[[TRUE:.*]] = arith.constant true +// CHECK: %[[ASEXPR:.*]] = hlfir.as_expr %[[TMP]]#0 move %[[TRUE]] : (!fir.boxchar<1>, i1) -> !hlfir.expr> +// CHECK: hlfir.assign %[[ASEXPR]] to %[[RES]]#0 +// CHECK: hlfir.destroy %[[ASEXPR]] +// CHECK-NEXT: return +// CHECK-NEXT: } diff --git a/flang/test/HLFIR/minval.fir b/flang/test/HLFIR/minval.fir new file mode 100644 index 0000000000000..368cfd9660baa --- /dev/null +++ b/flang/test/HLFIR/minval.fir @@ -0,0 +1,249 @@ +// Test hlfir.minval operation parse, verify (no errors), and unparse + +// RUN: fir-opt %s | fir-opt | FileCheck %s + +// array is an expression of known shape +func.func @minval0(%arg0: !hlfir.expr<42xi32>) { + %mask = fir.alloca !fir.logical<4> + %c_1 = arith.constant 1 : index + %true = arith.constant true + %true_logical = fir.convert %true : (i1) -> !fir.logical<4> + fir.store %true_logical to %mask : !fir.ref> + %mask_box = fir.embox %mask : (!fir.ref>) -> !fir.box> + %0 = hlfir.minval %arg0 dim %c_1 mask %mask_box : (!hlfir.expr<42xi32>, index, !fir.box>) -> i32 + return +} +// CHECK: func.func @minval0(%[[ARRAY:.*]]: !hlfir.expr<42xi32>) { +// CHECK-NEXT: %[[MASK:.*]] = fir.alloca !fir.logical<4> +// CHECK-NEXT: %[[C1:.*]] = arith.constant 1 : index +// CHECK-NEXT: %[[TRUE:.*]] = arith.constant true +// CHECK-NEXT: %[[LOGICAL:.*]] = fir.convert %[[TRUE]] : (i1) -> !fir.logical<4> +// CHECK-NEXT: fir.store %[[LOGICAL]] to %[[MASK]] : !fir.ref> +// CHECK-NEXT: %[[BOX:.*]] = fir.embox %0 : (!fir.ref>) -> !fir.box> +// CHECK-NEXT: hlfir.minval %[[ARRAY]] dim %[[C1]] mask %[[BOX]] : (!hlfir.expr<42xi32>, index, !fir.box>) -> i32 +// CHECK-NEXT: return +// CHECK-NEXT: } + +// array is an expression of assumed shape +func.func @minval1(%arg0: !hlfir.expr) { + %mask = fir.alloca !fir.logical<4> + %c_1 = arith.constant 1 : index + %true = arith.constant true + %true_logical = fir.convert %true : (i1) -> !fir.logical<4> + fir.store %true_logical to %mask : !fir.ref> + %mask_box = fir.embox %mask : (!fir.ref>) -> !fir.box> + %0 = hlfir.minval %arg0 dim %c_1 mask %mask_box : (!hlfir.expr, index, !fir.box>) -> i32 + return +} +// CHECK: func.func @minval1(%[[ARRAY:.*]]: !hlfir.expr) { +// CHECK-NEXT: %[[MASK:.*]] = fir.alloca !fir.logical<4> +// CHECK-NEXT: %[[C1:.*]] = arith.constant 1 : index +// CHECK-NEXT: %[[TRUE:.*]] = arith.constant true +// CHECK-NEXT: %[[LOGICAL:.*]] = fir.convert %[[TRUE]] : (i1) -> !fir.logical<4> +// CHECK-NEXT: fir.store %[[LOGICAL:.*]] to %[[MASK:.*]] : !fir.ref> +// CHECK-NEXT: %[[BOX:.*]] = fir.embox %[[MASK:.*]] : (!fir.ref>) -> !fir.box> +// CHECK-NEXT: hlfir.minval %[[ARRAY:.*]] dim %[[C1]] mask %[[BOX]] : (!hlfir.expr, index, !fir.box>) -> i32 +// CHECK-NEXT: return +// CHECK-NEXT: } + +// boxed array +func.func @minval2(%arg0: !fir.box>) { + %mask = fir.alloca !fir.logical<4> + %c_1 = arith.constant 1 : index + %true = arith.constant true + %true_logical = fir.convert %true : (i1) -> !fir.logical<4> + fir.store %true_logical to %mask : !fir.ref> + %mask_box = fir.embox %mask : (!fir.ref>) -> !fir.box> + %0 = hlfir.minval %arg0 dim %c_1 mask %mask_box : (!fir.box>, index, !fir.box>) -> i32 + return +} +// CHECK: func.func @minval2(%[[ARRAY:.*]]: !fir.box>) { +// CHECK-NEXT: %[[MASK:.*]] = fir.alloca !fir.logical<4> +// CHECK-NEXT: %[[C1:.*]] = arith.constant 1 : index +// CHECK-NEXT: %[[TRUE:.*]] = arith.constant true +// CHECK-NEXT: %[[LOGICAL:.*]] = fir.convert %[[TRUE]] : (i1) -> !fir.logical<4> +// CHECK-NEXT: fir.store %[[LOGICAL:.*]] to %[[MASK:.*]] : !fir.ref> +// CHECK-NEXT: %[[BOX:.*]] = fir.embox %[[MASK:.*]] : (!fir.ref>) -> !fir.box> +// CHECK-NEXT: hlfir.minval %[[ARRAY:.*]] dim %[[C1]] mask %[[BOX]] : (!fir.box>, index, !fir.box>) -> i32 +// CHECK-NEXT: return +// CHECK-NEXT: } + +// assumed shape boxed array +func.func @minval3(%arg0: !fir.box>) { + %mask = fir.alloca !fir.logical<4> + %c_1 = arith.constant 1 : index + %true = arith.constant true + %true_logical = fir.convert %true : (i1) -> !fir.logical<4> + fir.store %true_logical to %mask : !fir.ref> + %mask_box = fir.embox %mask : (!fir.ref>) -> !fir.box> + %0 = hlfir.minval %arg0 dim %c_1 mask %mask_box : (!fir.box>, index, !fir.box>) -> i32 + return +} +// CHECK: func.func @minval3(%[[ARRAY:.*]]: !fir.box>) { +// CHECK-NEXT: %[[MASK:.*]] = fir.alloca !fir.logical<4> +// CHECK-NEXT: %[[C1:.*]] = arith.constant 1 : index +// CHECK-NEXT: %[[TRUE:.*]] = arith.constant true +// CHECK-NEXT: %[[LOGICAL:.*]] = fir.convert %[[TRUE]] : (i1) -> !fir.logical<4> +// CHECK-NEXT: fir.store %[[LOGICAL:.*]] to %[[MASK:.*]] : !fir.ref> +// CHECK-NEXT: %[[BOX:.*]] = fir.embox %[[MASK:.*]] : (!fir.ref>) -> !fir.box> +// CHECK-NEXT: hlfir.minval %[[ARRAY:.*]] dim %[[C1]] mask %[[BOX]] : (!fir.box>, index, !fir.box>) -> i32 +// CHECK-NEXT: return +// CHECK-NEXT: } + +// known shape expr mask +func.func @minval4(%arg0: !fir.box>, %arg1: !hlfir.expr<42x!fir.logical<4>>) { + %c_1 = arith.constant 1 : index + %0 = hlfir.minval %arg0 dim %c_1 mask %arg1 : (!fir.box>, index, !hlfir.expr<42x!fir.logical<4>>) -> i32 + return +} +// CHECK: func.func @minval4(%[[ARRAY:.*]]: !fir.box>, %[[MASK:.*]]: !hlfir.expr<42x!fir.logical<4>>) { +// CHECK-NEXT: %[[C1:.*]] = arith.constant 1 : index +// CHECK-NEXT: hlfir.minval %[[ARRAY]] dim %[[C1]] mask %[[MASK]] : (!fir.box>, index, !hlfir.expr<42x!fir.logical<4>>) -> i32 +// CHECK-NEXT: return +// CHECK-NEXT: } + +// assumed shape expr mask +func.func @minval5(%arg0: !fir.box>, %arg1: !hlfir.expr>) { + %c_1 = arith.constant 1 : index + %0 = hlfir.minval %arg0 dim %c_1 mask %arg1 : (!fir.box>, index, !hlfir.expr>) -> i32 + return +} +// CHECK: func.func @minval5(%[[ARRAY:.*]]: !fir.box>, %[[MASK:.*]]: !hlfir.expr>) { +// CHECK-NEXT: %[[C1:.*]] = arith.constant 1 : index +// CHECK-NEXT: hlfir.minval %[[ARRAY]] dim %[[C1]] mask %[[MASK]] : (!fir.box>, index, !hlfir.expr>) -> i32 +// CHECK-NEXT: return +// CHECK-NEXT: } + +// known shape array mask +func.func @minval6(%arg0: !fir.box>, %arg1: !fir.box>>) { + %c_1 = arith.constant 1 : index + %0 = hlfir.minval %arg0 dim %c_1 mask %arg1 : (!fir.box>, index, !fir.box>>) -> i32 + return +} +// CHECK: func.func @minval6(%[[ARRAY:.*]]: !fir.box>, %[[MASK:.*]]: !fir.box>>) { +// CHECK-NEXT: %[[C1:.*]] = arith.constant 1 : index +// CHECK-NEXT: hlfir.minval %[[ARRAY]] dim %[[C1]] mask %[[MASK]] : (!fir.box>, index, !fir.box>>) -> i32 +// CHECK-NEXT: return +// CHECK-NEXT: } + +// assumed shape array mask +func.func @minval7(%arg0: !fir.box>, %arg1: !fir.box>>) { + %c_1 = arith.constant 1 : index + %0 = hlfir.minval %arg0 dim %c_1 mask %arg1 : (!fir.box>, index, !fir.box>>) -> i32 + return +} +// CHECK: func.func @minval7(%[[ARRAY:.*]]: !fir.box>, %[[MASK:.*]]: !fir.box>>) { +// CHECK-NEXT: %[[C1:.*]] = arith.constant 1 : index +// CHECK-NEXT: hlfir.minval %[[ARRAY]] dim %[[C1]] mask %[[MASK]] : (!fir.box>, index, !fir.box>>) -> i32 +// CHECK-NEXT: return +// CHECK-NEXT: } + +// known shape expr return +func.func @minval8(%arg0: !fir.box>, %arg1: i32) { + %mask = fir.alloca !fir.logical<4> + %true = arith.constant true + %true_logical = fir.convert %true : (i1) -> !fir.logical<4> + fir.store %true_logical to %mask : !fir.ref> + %mask_box = fir.embox %mask : (!fir.ref>) -> !fir.box> + %0 = hlfir.minval %arg0 dim %arg1 mask %mask_box : (!fir.box>, i32, !fir.box>) -> !hlfir.expr<2xi32> + return +} +// CHECK: func.func @minval8(%[[ARRAY:.*]]: !fir.box>, %[[DIM:.*]]: i32) { +// CHECK-NEXT: %[[MASK:.*]] = fir.alloca !fir.logical<4> +// CHECK-NEXT: %[[TRUE:.*]] = arith.constant true +// CHECK-NEXT: %[[LOGICAL:.*]] = fir.convert %[[TRUE]] : (i1) -> !fir.logical<4> +// CHECK-NEXT: fir.store %[[LOGICAL]] to %[[MASK]] : !fir.ref> +// CHECK-NEXT: %[[BOX:.*]] = fir.embox %0 : (!fir.ref>) -> !fir.box> +// CHECK-NEXT: hlfir.minval %[[ARRAY]] dim %[[DIM]] mask %[[BOX]] : (!fir.box>, i32, !fir.box>) -> !hlfir.expr<2xi32> +// CHECK-NEXT: return +// CHECK-NEXT: } + +// assumed shape expr return +func.func @minval9(%arg0: !fir.box>, %arg1: i32) { + %mask = fir.alloca !fir.logical<4> + %true = arith.constant true + %true_logical = fir.convert %true : (i1) -> !fir.logical<4> + fir.store %true_logical to %mask : !fir.ref> + %mask_box = fir.embox %mask : (!fir.ref>) -> !fir.box> + %0 = hlfir.minval %arg0 dim %arg1 mask %mask_box : (!fir.box>, i32, !fir.box>) -> !hlfir.expr + return +} +// CHECK: func.func @minval9(%[[ARRAY:.*]]: !fir.box>, %[[DIM:.*]]: i32) { +// CHECK-NEXT: %[[MASK:.*]] = fir.alloca !fir.logical<4> +// CHECK-NEXT: %[[TRUE:.*]] = arith.constant true +// CHECK-NEXT: %[[LOGICAL:.*]] = fir.convert %[[TRUE]] : (i1) -> !fir.logical<4> +// CHECK-NEXT: fir.store %[[LOGICAL]] to %[[MASK]] : !fir.ref> +// CHECK-NEXT: %[[BOX:.*]] = fir.embox %0 : (!fir.ref>) -> !fir.box> +// CHECK-NEXT: hlfir.minval %[[ARRAY]] dim %[[DIM]] mask %[[BOX]] : (!fir.box>, i32, !fir.box>) -> !hlfir.expr +// CHECK-NEXT: return +// CHECK-NEXT: } + +// hlfir.minval with only an array argument +func.func @minval10(%arg0: !fir.box>) { + %minval = hlfir.minval %arg0 : (!fir.box>) -> i32 + return +} +// CHECK: func.func @minval10(%[[ARRAY:.*]]: !fir.box> +// CHECK-NEXT: %[[minval:.*]] = hlfir.minval %[[ARRAY]] : (!fir.box>) -> i32 +// CHECK-NEXT: return +// CHECK-NEXT: } + +// hlfir.minval with only a character array argument +func.func @minval11(%arg0: !fir.box>>) { + %minval = hlfir.minval %arg0 : (!fir.box>>) -> !hlfir.expr> + return +} +// CHECK: func.func @minval11(%[[ARRAY:.*]]: !fir.box>> +// CHECK-NEXT: %[[minval:.*]] = hlfir.minval %[[ARRAY]] : (!fir.box>>) -> !hlfir.expr> +// CHECK-NEXT: return +// CHECK-NEXT: } + +// hlfir.minval with array and dim argument +func.func @minval12(%arg0: !fir.box>, %arg1: i32) { + %minval = hlfir.minval %arg0 dim %arg1 : (!fir.box>, i32) -> !hlfir.expr + return +} +// CHECK: func.func @minval12(%[[ARRAY:.*]]: !fir.box>, %[[DIM:.*]]: i32 +// CHECK-NEXT: %[[minval:.*]] = hlfir.minval %[[ARRAY]] dim %[[DIM]] : (!fir.box>, i32) -> !hlfir.expr +// CHECK-NEXT: return +// CHECK-NEXT: } + +// hlfir.minval with array and mask argument +func.func @minval13(%arg0: !fir.box>, %arg1: !fir.logical<4>) { + %minval = hlfir.minval %arg0 mask %arg1 : (!fir.box>, !fir.logical<4>) -> i32 + return +} +// CHECK: func.func @minval13(%[[ARRAY:.*]]: !fir.box>, %[[MASK:.*]]: !fir.logical<4> +// CHECK-NEXT: %[[minval:.*]] = hlfir.minval %[[ARRAY]] mask %[[MASK]] : (!fir.box>, !fir.logical<4>) -> i32 +// CHECK-NEXT: return +// CHECK-NEXT: } + +// hlfir.minval with dim argument with an unusual type +func.func @minval14(%arg0: !fir.box>, %arg1: index) { + %minval = hlfir.minval %arg0 dim %arg1 : (!fir.box>, index) -> !hlfir.expr + return +} +// CHECK: func.func @minval14(%[[ARRAY:.*]]: !fir.box>, %[[DIM:.*]]: index +// CHECK-NEXT: %[[minval:.*]] = hlfir.minval %[[ARRAY]] dim %[[DIM]] : (!fir.box>, index) -> !hlfir.expr +// CHECK-NEXT: return +// CHECK-NEXT: } + +// hlfir.minval with mask argument of unusual type +func.func @minval15(%arg0: !fir.box>, %arg1: i1) { + %minval = hlfir.minval %arg0 mask %arg1 : (!fir.box>, i1) -> i32 + return +} +// CHECK: func.func @minval15(%[[ARRAY:.*]]: !fir.box>, %[[MASK:.*]]: i1 +// CHECK-NEXT: %[[minval:.*]] = hlfir.minval %[[ARRAY]] mask %[[MASK]] : (!fir.box>, i1) -> i32 +// CHECK-NEXT: return +// CHECK-NEXT: } + +// hlfir.minval with mask argument of ref> type +func.func @minval16(%arg0: !fir.box>, %arg1: !fir.ref>>) { + %minval = hlfir.minval %arg0 mask %arg1 : (!fir.box>, !fir.ref>>) -> i32 + return +} +// CHECK: func.func @minval16(%[[ARRAY:.*]]: !fir.box>, %[[MASK:.*]]: !fir.ref>> +// CHECK-NEXT: %[[minval:.*]] = hlfir.minval %[[ARRAY]] mask %[[MASK]] : (!fir.box>, !fir.ref>>) -> i32 +// CHECK-NEXT: return +// CHECK-NEXT: } diff --git a/flang/test/Lower/HLFIR/minval.f90 b/flang/test/Lower/HLFIR/minval.f90 new file mode 100644 index 0000000000000..806c9c2a8a011 --- /dev/null +++ b/flang/test/Lower/HLFIR/minval.f90 @@ -0,0 +1,262 @@ +! Test lowering of MINVAL intrinsic to HLFIR +! RUN: bbc -emit-hlfir -o - %s 2>&1 | FileCheck %s + +! simple 1 argument MINVAL +subroutine minval1(a, s) + integer :: a(:), s + s = MINVAL(a) +end subroutine +! CHECK-LABEL: func.func @_QPminval1( +! CHECK: %[[ARG0:.*]]: !fir.box> {fir.bindc_name = "a"}, %[[ARG1:.*]]: !fir.ref +! CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +! CHECK-DAG: %[[OUT:.*]]:2 = hlfir.declare %[[ARG1]] +! CHECK-NEXT: %[[EXPR:.*]] = hlfir.minval %[[ARRAY]]#0 {fastmath = #arith.fastmath} : (!fir.box>) -> i32 +! CHECK-NEXT: hlfir.assign %[[EXPR]] to %[[OUT]]#0 : i32, !fir.ref +! CHECK-NEXT: return +! CHECK-NEXT: } + +! minval with by-ref DIM argument +subroutine minval2(a, s, d) + integer :: a(:,:), s(:), d + s = MINVAL(a, d) +end subroutine +! CHECK-LABEL: func.func @_QPminval2( +! CHECK: %[[ARG0:.*]]: !fir.box> {fir.bindc_name = "a"}, %[[ARG1:.*]]: !fir.box> {fir.bindc_name = "s"}, %[[ARG2:.*]]: !fir.ref +! CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +! CHECK-DAG: %[[OUT:.*]]:2 = hlfir.declare %[[ARG1]] +! CHECK-DAG: %[[DIM_REF:.*]]:2 = hlfir.declare %[[ARG2]] +! CHECK-NEXT: %[[DIM:.*]] = fir.load %[[DIM_REF]]#0 : !fir.ref +! CHECK-NEXT: %[[EXPR:.*]] = hlfir.minval %[[ARRAY]]#0 dim %[[DIM]] {fastmath = #arith.fastmath} : (!fir.box>, i32) -> !hlfir.expr +! CHECK-NEXT: hlfir.assign %[[EXPR]] to %[[OUT]]#0 : !hlfir.expr, !fir.box> +! CHECK-NEXT: hlfir.destroy %[[EXPR]] +! CHECK-NEXT: return +! CHECK-NEXT: } + +! minval with scalar mask argument +subroutine minval3(a, s, m) + integer :: a(:), s + logical :: m + s = MINVAL(a, m) +end subroutine +! CHECK-LABEL: func.func @_QPminval3( +! CHECK: %[[ARG0:.*]]: !fir.box> {fir.bindc_name = "a"}, %[[ARG1:.*]]: !fir.ref {fir.bindc_name = "s"}, %[[ARG2:.*]]: !fir.ref> +! CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +! CHECK-DAG: %[[OUT:.*]]:2 = hlfir.declare %[[ARG1]] +! CHECK-DAG: %[[MASK:.*]]:2 = hlfir.declare %[[ARG2]] +! CHECK-NEXT: %[[EXPR:.*]] = hlfir.minval %[[ARRAY]]#0 mask %[[MASK]]#0 {fastmath = #arith.fastmath} : (!fir.box>, !fir.ref>) -> i32 +! CHECK-NEXT: hlfir.assign %[[EXPR]] to %[[OUT]]#0 : i32, !fir.ref +! CHECK-NEXT: return +! CHECK-NEXT: } + +! minval with array mask argument +subroutine minval4(a, s, m) + integer :: a(:), s + logical :: m(:) + s = MINVAL(a, m) +end subroutine +! CHECK-LABEL: func.func @_QPminval4( +! CHECK: %[[ARG0:.*]]: !fir.box> {fir.bindc_name = "a"}, %[[ARG1:.*]]: !fir.ref {fir.bindc_name = "s"}, %[[ARG2:.*]]: !fir.box>> +! CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +! CHECK-DAG: %[[OUT:.*]]:2 = hlfir.declare %[[ARG1]] +! CHECK-DAG: %[[MASK:.*]]:2 = hlfir.declare %[[ARG2]] +! CHECK-NEXT: %[[EXPR:.*]] = hlfir.minval %[[ARRAY]]#0 mask %[[MASK]]#0 {fastmath = #arith.fastmath} : (!fir.box>, !fir.box>>) -> i32 +! CHECK-NEXT: hlfir.assign %[[EXPR]] to %[[OUT]]#0 : i32, !fir.ref +! CHECK-NEXT: return +! CHECK-NEXT: } + +! minval with all 3 arguments, dim is by-val, array isn't boxed +subroutine minval5(s) + integer :: s(2) + integer :: a(2,2) = reshape((/1, 2, 3, 4/), [2,2]) + s = minval(a, 1, .true.) +end subroutine +! CHECK-LABEL: func.func @_QPminval5 +! CHECK: %[[ARG0:.*]]: !fir.ref> +! CHECK-DAG: %[[ADDR:.*]] = fir.address_of({{.*}}) : !fir.ref> +! CHECK-DAG: %[[ARRAY_SHAPE:.*]] = fir.shape {{.*}} -> !fir.shape<2> +! CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ADDR]](%[[ARRAY_SHAPE]]) +! CHECK-DAG: %[[OUT_SHAPE:.*]] = fir.shape {{.*}} -> !fir.shape<1> +! CHECK-DAG: %[[OUT:.*]]:2 = hlfir.declare %[[ARG0]](%[[OUT_SHAPE]]) +! CHECK-DAG: %[[TRUE:.*]] = arith.constant true +! CHECK-DAG: %[[C1:.*]] = arith.constant 1 : i32 +! CHECK-NEXT: %[[EXPR:.*]] = hlfir.minval %[[ARRAY]]#0 dim %[[C1]] mask %[[TRUE]] {fastmath = #arith.fastmath} : (!fir.ref>, i32, i1) -> !hlfir.expr<2xi32> +! CHECK-NEXT: hlfir.assign %[[EXPR]] to %[[OUT]]#0 : !hlfir.expr<2xi32>, !fir.ref> +! CHECK-NEXT: hlfir.destroy %[[EXPR]] : !hlfir.expr<2xi32> +! CHECK-NEXT: return +! CHECK-nEXT: } + +subroutine minval6(a, s, d) + integer, pointer :: d + real :: a(:,:), s(:) + s = minval(a, (d)) +end subroutine +! CHECK-LABEL: func.func @_QPminval6( +! CHECK: %[[ARG0:.*]]: !fir.box> +! CHECK: %[[ARG1:.*]]: !fir.box> +! CHECK: %[[ARG2:.*]]: !fir.ref>> +! CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +! CHECK-DAG: %[[OUT:.*]]:2 = hlfir.declare %[[ARG1]] +! CHECK-DAG: %[[DIM_VAR:.*]]:2 = hlfir.declare %[[ARG2]] +! CHECK-NEXT: %[[DIM_BOX:.*]] = fir.load %[[DIM_VAR]]#0 : !fir.ref>> +! CHECK-NEXT: %[[DIM_ADDR:.*]] = fir.box_addr %[[DIM_BOX]] : (!fir.box>) -> !fir.ptr +! CHECK-NEXT: %[[DIM0:.*]] = fir.load %[[DIM_ADDR]] : !fir.ptr +! CHECK-NEXT: %[[DIM1:.*]] = hlfir.no_reassoc %[[DIM0]] : i32 +! CHECK-NEXT: %[[EXPR:.*]] = hlfir.minval %[[ARRAY]]#0 dim %[[DIM1]] {fastmath = #arith.fastmath} : (!fir.box>, i32) -> !hlfir.expr +! CHECK-NEXT: hlfir.assign %[[EXPR]] to %[[OUT]]#0 : !hlfir.expr, !fir.box> +! CHECK-NEXT: hlfir.destroy %[[EXPR]] +! CHECK-NEXT: return +! CHECK-NEXT: } + +! simple 1 argument MINVAL for character +subroutine minval7(a, s) + character(*) :: a(:), s + s = MINVAL(a) +end subroutine +! CHECK-LABEL: func.func @_QPminval7( +! CHECK: %[[ARG0:.*]]: !fir.box>> {fir.bindc_name = "a"}, %[[ARG1:.*]]: !fir.boxchar<1> +! CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +! CHECK-DAG: %[[UNBOXED:.*]]:2 = fir.unboxchar %[[ARG1]] +! CHECK-DAG: %[[OUT:.*]]:2 = hlfir.declare %[[UNBOXED]]#0 typeparams %[[UNBOXED]]#1 +! CHECK-NEXT: %[[EXPR:.*]] = hlfir.minval %[[ARRAY]]#0 {fastmath = #arith.fastmath} : (!fir.box>>) -> !hlfir.expr> +! CHECK-NEXT: hlfir.assign %[[EXPR]] to %[[OUT]]#0 : !hlfir.expr>, !fir.boxchar<1> +! CHECK-NEXT: hlfir.destroy %[[EXPR]] +! CHECK-NEXT: return +! CHECK-NEXT: } + +! minval for character with by-ref DIM argument +subroutine minval8(a, s, d) + character(*) :: a(:,:), s(:) + integer :: d + s = MINVAL(a, d) +end subroutine +! CHECK-LABEL: func.func @_QPminval8( +! CHECK: %[[ARG0:.*]]: !fir.box>> {fir.bindc_name = "a"}, %[[ARG1:.*]]: !fir.box>> {fir.bindc_name = "s"}, %[[ARG2:.*]]: !fir.ref +! CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +! CHECK-DAG: %[[OUT:.*]]:2 = hlfir.declare %[[ARG1]] +! CHECK-DAG: %[[DIM_REF:.*]]:2 = hlfir.declare %[[ARG2]] +! CHECK-NEXT: %[[DIM:.*]] = fir.load %[[DIM_REF]]#0 : !fir.ref +! CHECK-NEXT: %[[EXPR:.*]] = hlfir.minval %[[ARRAY]]#0 dim %[[DIM]] {fastmath = #arith.fastmath} : (!fir.box>>, i32) -> !hlfir.expr> +! CHECK-NEXT: hlfir.assign %[[EXPR]] to %[[OUT]]#0 : !hlfir.expr>, !fir.box>> +! CHECK-NEXT: hlfir.destroy %[[EXPR]] +! CHECK-NEXT: return +! CHECK-NEXT: } + +! minval for character with scalar mask argument +subroutine minval9(a, s, m) + character(*) :: a(:), s + logical :: m + s = MINVAL(a, m) +end subroutine +! CHECK-LABEL: func.func @_QPminval9( +! CHECK: %[[ARG0:.*]]: !fir.box>> {fir.bindc_name = "a"}, %[[ARG1:.*]]: !fir.boxchar<1> {fir.bindc_name = "s"}, %[[ARG2:.*]]: !fir.ref> +! CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +! CHECK-DAG: %[[UNBOXED:.*]]:2 = fir.unboxchar %[[ARG1]] +! CHECK-DAG: %[[MASK:.*]]:2 = hlfir.declare %[[ARG2]] +! CHECK-DAG: %[[OUT:.*]]:2 = hlfir.declare %[[UNBOXED]]#0 typeparams %[[UNBOXED]]#1 +! CHECK-NEXT: %[[EXPR:.*]] = hlfir.minval %[[ARRAY]]#0 mask %[[MASK]]#0 {fastmath = #arith.fastmath} : (!fir.box>>, !fir.ref>) -> !hlfir.expr> +! CHECK-NEXT: hlfir.assign %[[EXPR]] to %[[OUT]]#0 : !hlfir.expr>, !fir.boxchar<1> +! CHECK-NEXT: hlfir.destroy %[[EXPR]] +! CHECK-NEXT: return +! CHECK-NEXT: } + +subroutine testDynamicallyOptionalMask(array, mask, res) + integer :: array(:), res + logical, allocatable :: mask(:) + res = MINVAL(array, mask=mask) +end subroutine +! CHECK-LABEL: func.func @_QPtestdynamicallyoptionalmask( +! CHECK-SAME: %[[ARG0:.*]]: !fir.box> +! CHECK-SAME: %[[ARG1:.*]]: !fir.ref>>>> +! CHECK-SAME: %[[ARG2:.*]]: !fir.ref +! CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +! CHECK-DAG: %[[MASK:.*]]:2 = hlfir.declare %[[ARG1]] +! CHECK-DAG: %[[RES:.*]]:2 = hlfir.declare %[[ARG2]] +! CHECK-NEXT: %[[MASK_LOAD:.*]] = fir.load %[[MASK]]#1 +! CHECK-NEXT: %[[MASK_ADDR:.*]] = fir.box_addr %[[MASK_LOAD]] +! CHECK-NEXT: %[[MASK_ADDR_INT:.*]] = fir.convert %[[MASK_ADDR]] +! CHECK-NEXT: %[[C0:.*]] = arith.constant 0 : i64 +! CHECK-NEXT: %[[CMP:.*]] = arith.cmpi ne, %[[MASK_ADDR_INT]], %[[C0]] : i64 +! it is a shame there is a second load here. The first is generated for +! PreparedActualArgument::isPresent, the second is for optional handling +! CHECK-NEXT: %[[MASK_LOAD2:.*]] = fir.load %[[MASK]]#1 +! CHECK-NEXT: %[[ABSENT:.*]] = fir.absent !fir.box>>> +! CHECK-NEXT: %[[SELECT:.*]] = arith.select %[[CMP]], %[[MASK_LOAD2]], %[[ABSENT]] +! CHECK-NEXT: %[[MINVAL:.*]] = hlfir.minval %[[ARRAY]]#0 mask %[[SELECT]] +! CHECK-NEXT: hlfir.assign %[[MINVAL]] to %[[RES]]#0 +! CHECK-NEXT: return +! CHECK-NEXT: } + +subroutine testAllocatableArray(array, mask, res) + integer, allocatable :: array(:) + integer :: res + logical :: mask(:) + res = MINVAL(array, mask=mask) +end subroutine +! CHECK-LABEL: func.func @_QPtestallocatablearray( +! CHECK-SAME: %[[ARG0:.*]]: !fir.ref>>> +! CHECK-SAME: %[[ARG1:.*]]: !fir.box>> +! CHECK-SAME: %[[ARG2:.*]]: !fir.ref +! CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARG0]] +! CHECK-DAG: %[[MASK:.*]]:2 = hlfir.declare %[[ARG1]] +! CHECK-DAG: %[[RES:.*]]:2 = hlfir.declare %[[ARG2]] +! CHECK-NEXT: %[[LOADED_ARRAY:.*]] = fir.load %[[ARRAY]]#0 +! CHECK-NEXT: %[[MINVAL:.*]] = hlfir.minval %[[LOADED_ARRAY]] mask %[[MASK]]#0 +! CHECK-NEXT: hlfir.assign %[[MINVAL]] to %[[RES]]#0 +! CHECK-NEXT: return +! CHECK-NEXT: } + +function testOptionalScalar(array, mask) + integer :: array(:) + logical, optional :: mask + integer :: testOptionalScalar + testOptionalScalar = minval(array, mask) +end function +! CHECK-LABEL: func.func @_QPtestoptionalscalar( +! CHECK-SAME: %[[ARRAY_ARG:.*]]: !fir.box> {fir.bindc_name = "array"}, +! CHECK-SAME: %[[MASK_ARG:.*]]: !fir.ref> {fir.bindc_name = "mask", fir.optional}) -> i32 +! CHECK: %[[ARRAY_VAR:.*]]:2 = hlfir.declare %[[ARRAY_ARG]] +! CHECK: %[[MASK_VAR:.*]]:2 = hlfir.declare %[[MASK_ARG]] +! CHECK: %[[RET_ALLOC:.*]] = fir.alloca i32 {bindc_name = "testoptionalscalar", uniq_name = "_QFtestoptionalscalarEtestoptionalscalar"} +! CHECK: %[[RET_VAR:.*]]:2 = hlfir.declare %[[RET_ALLOC]] +! CHECK: %[[MASK_IS_PRESENT:.*]] = fir.is_present %[[MASK_VAR]]#0 : (!fir.ref>) -> i1 +! CHECK: %[[MASK_BOX:.*]] = fir.embox %[[MASK_VAR]]#1 +! CHECK: %[[ABSENT:.*]] = fir.absent !fir.box> +! CHECK: %[[MASK_SELECT:.*]] = arith.select %[[MASK_IS_PRESENT]], %[[MASK_BOX]], %[[ABSENT]] +! CHECK: %[[RES:.*]] = hlfir.minval %[[ARRAY_VAR]]#0 mask %[[MASK_SELECT]] {{.*}}: (!fir.box>, !fir.box>) -> i32 +! CHECK: hlfir.assign %[[RES]] to %[[RET_VAR]]#0 +! CHECK: %[[RET:.*]] = fir.load %[[RET_VAR]]#1 : !fir.ref +! CHECK: return %[[RET]] : i32 +! CHECK: } + +! Test that hlfir.minval lowering inherits constant +! character length from the argument, when the length +! is unknown from the Fortran::evaluate expression type. +subroutine test_unknown_char_len_result + character(len=3) :: array(3,3), res + res = minval(array(:,:)(:)) +end subroutine test_unknown_char_len_result +! CHECK-LABEL: func.func @_QPtest_unknown_char_len_result() { +! CHECK-DAG: %[[C3:.*]] = arith.constant 3 : index +! CHECK-DAG: %[[C3_0:.*]] = arith.constant 3 : index +! CHECK-DAG: %[[C3_1:.*]] = arith.constant 3 : index +! CHECK-DAG: %[[ARRAY_ALLOC:.*]] = fir.alloca !fir.array<3x3x!fir.char<1,3>> +! CHECK-DAG: %[[ARRAY_SHAPE:.*]] = fir.shape %[[C3_0]], %[[C3_1]] : (index, index) -> !fir.shape<2> +! CHECK-DAG: %[[ARRAY:.*]]:2 = hlfir.declare %[[ARRAY_ALLOC]](%[[ARRAY_SHAPE]]) typeparams %[[C3]] +! CHECK-DAG: %[[C3_2:.*]] = arith.constant 3 : index +! CHECK-DAG: %[[RES_ALLOC:.*]] = fir.alloca !fir.char<1,3> +! CHECK-DAG: %[[RES:.*]]:2 = hlfir.declare %[[RES_ALLOC]] typeparams %[[C3_2]] +! CHECK-DAG: %[[C1:.*]] = arith.constant 1 : index +! CHECK-DAG: %[[C1_3:.*]] = arith.constant 1 : index +! CHECK-DAG: %[[C3_4:.*]] = arith.constant 3 : index +! CHECK-DAG: %[[C1_5:.*]] = arith.constant 1 : index +! CHECK-DAG: %[[C3_6:.*]] = arith.constant 3 : index +! CHECK-DAG: %[[SHAPE:.*]] = fir.shape %[[C3_4]], %[[C3_6]] : (index, index) -> !fir.shape<2> +! CHECK-DAG: %[[C1_7:.*]] = arith.constant 1 : index +! CHECK-DAG: %[[C3_8:.*]] = arith.constant 3 : index +! CHECK-DAG: %[[C3_9:.*]] = arith.constant 3 : index +! CHECK-DAG: %[[ARRAY_BOX:.*]] = hlfir.designate %[[ARRAY]]#0 (%[[C1]]:%[[C3_0]]:%[[C1_3]], %[[C1]]:%[[C3_1]]:%[[C1_5]]) substr %[[C1_7]], %[[C3_8]] shape %[[SHAPE]] typeparams %[[C3_9]] +! CHECK: %[[EXPR:.*]] = hlfir.minval %[[ARRAY_BOX]] {fastmath = #arith.fastmath} : (!fir.box>>) -> !hlfir.expr> +! CHECK-NEXT: hlfir.assign %[[EXPR]] to %[[RES]]#0 : !hlfir.expr>, !fir.ref> +! CHECK-NEXT: hlfir.destroy %[[EXPR]] +! CHECK-NEXT: return +! CHECK-NEXT: }