diff --git a/llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp b/llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp index 2a830535a2aa1..027e4c2b46d87 100644 --- a/llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp +++ b/llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp @@ -597,8 +597,9 @@ void RequirementHandler::initAvailableCapabilitiesForVulkan( const SPIRVSubtarget &ST) { addAvailableCaps({Capability::Shader, Capability::Linkage}); - // Provided by Vulkan version 1.0. - addAvailableCaps({Capability::Int16, Capability::Int64, Capability::Float64}); + // Provided by all supported Vulkan versions. + addAvailableCaps({Capability::Int16, Capability::Int64, Capability::Float16, + Capability::Float64}); } } // namespace SPIRV @@ -733,7 +734,10 @@ void addInstrRequirements(const MachineInstr &MI, auto SC = MI.getOperand(1).getImm(); Reqs.getAndAddRequirements(SPIRV::OperandCategory::StorageClassOperand, SC, ST); - // If it's a type of pointer to float16, add Float16Buffer capability. + // If it's a type of pointer to float16 targeting OpenCL, add Float16Buffer + // capability. + if (!ST.isOpenCLEnv()) + break; assert(MI.getOperand(2).isReg()); const MachineRegisterInfo &MRI = MI.getMF()->getRegInfo(); SPIRVType *TypeDef = MRI.getVRegDef(MI.getOperand(2).getReg()); diff --git a/llvm/test/CodeGen/SPIRV/basic_float_types.ll b/llvm/test/CodeGen/SPIRV/basic_float_types.ll index 4287adc85cfd8..1c7a8a851f59c 100644 --- a/llvm/test/CodeGen/SPIRV/basic_float_types.ll +++ b/llvm/test/CodeGen/SPIRV/basic_float_types.ll @@ -1,12 +1,22 @@ ; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s ; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s ; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s +; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %} define void @main() { entry: + +; CHECK-DAG: OpCapability Float16 +; CHECK-DAG: OpCapability Float64 + +; CHECK-DAG: %[[#half:]] = OpTypeFloat 16 ; CHECK-DAG: %[[#float:]] = OpTypeFloat 32 ; CHECK-DAG: %[[#double:]] = OpTypeFloat 64 +; CHECK-DAG: %[[#v2half:]] = OpTypeVector %[[#half]] 2 +; CHECK-DAG: %[[#v3half:]] = OpTypeVector %[[#half]] 3 +; CHECK-DAG: %[[#v4half:]] = OpTypeVector %[[#half]] 4 + ; CHECK-DAG: %[[#v2float:]] = OpTypeVector %[[#float]] 2 ; CHECK-DAG: %[[#v3float:]] = OpTypeVector %[[#float]] 3 ; CHECK-DAG: %[[#v4float:]] = OpTypeVector %[[#float]] 4 @@ -15,8 +25,12 @@ entry: ; CHECK-DAG: %[[#v3double:]] = OpTypeVector %[[#double]] 3 ; CHECK-DAG: %[[#v4double:]] = OpTypeVector %[[#double]] 4 +; CHECK-DAG: %[[#ptr_Function_half:]] = OpTypePointer Function %[[#half]] ; CHECK-DAG: %[[#ptr_Function_float:]] = OpTypePointer Function %[[#float]] ; CHECK-DAG: %[[#ptr_Function_double:]] = OpTypePointer Function %[[#double]] +; CHECK-DAG: %[[#ptr_Function_v2half:]] = OpTypePointer Function %[[#v2half]] +; CHECK-DAG: %[[#ptr_Function_v3half:]] = OpTypePointer Function %[[#v3half]] +; CHECK-DAG: %[[#ptr_Function_v4half:]] = OpTypePointer Function %[[#v4half]] ; CHECK-DAG: %[[#ptr_Function_v2float:]] = OpTypePointer Function %[[#v2float]] ; CHECK-DAG: %[[#ptr_Function_v3float:]] = OpTypePointer Function %[[#v3float]] ; CHECK-DAG: %[[#ptr_Function_v4float:]] = OpTypePointer Function %[[#v4float]] @@ -24,12 +38,24 @@ entry: ; CHECK-DAG: %[[#ptr_Function_v3double:]] = OpTypePointer Function %[[#v3double]] ; CHECK-DAG: %[[#ptr_Function_v4double:]] = OpTypePointer Function %[[#v4double]] +; CHECK: %[[#]] = OpVariable %[[#ptr_Function_half]] Function + %half_Val = alloca half, align 2 + ; CHECK: %[[#]] = OpVariable %[[#ptr_Function_float]] Function %float_Val = alloca float, align 4 ; CHECK: %[[#]] = OpVariable %[[#ptr_Function_double]] Function %double_Val = alloca double, align 8 +; CHECK: %[[#]] = OpVariable %[[#ptr_Function_v2half]] Function + %half2_Val = alloca <2 x half>, align 4 + +; CHECK: %[[#]] = OpVariable %[[#ptr_Function_v3half]] Function + %half3_Val = alloca <3 x half>, align 8 + +; CHECK: %[[#]] = OpVariable %[[#ptr_Function_v4half]] Function + %half4_Val = alloca <4 x half>, align 8 + ; CHECK: %[[#]] = OpVariable %[[#ptr_Function_v2float]] Function %float2_Val = alloca <2 x float>, align 8