Skip to content
Permalink
Browse files

[libc++] Only build with -fvisibility=hidden on Clang

The visibility annotations in libc++ are not quite right for GCC, which
results in symbols not being exported when -fvisibility=hidden is used.
To fix the GCC build bots, this commit reverts to the previous state of
not building with hidden visibility on GCC.

In the future, we can build with hidden visibility all the time and
export symbols explicitly using a list. See https://llvm.org/D66970
for one take at this.

llvm-svn: 370926
  • Loading branch information...
ldionne committed Sep 4, 2019
1 parent 912edaf commit 5afc5a6c1b98f0c93eb1f9902d96e13b58b54a0c
Showing with 7 additions and 1 deletion.
  1. +7 −1 libcxx/src/CMakeLists.txt
@@ -204,7 +204,13 @@ function(cxx_set_common_defines name)
if(LIBCXX_CXX_ABI_HEADER_TARGET)
add_dependencies(${name} ${LIBCXX_CXX_ABI_HEADER_TARGET})
endif()
target_compile_options(${name} PRIVATE -fvisibility=hidden)
# Our visibility annotations are not quite right for non-Clang compilers,
# so we end up not exporting all the symbols we should. In the future, we
# can improve the situation by providing an explicit list of exported
# symbols on all compilers.
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
target_compile_options(${name} PRIVATE -fvisibility=hidden)
endif()
if(WIN32 AND NOT MINGW)
target_compile_definitions(${name}
PRIVATE

0 comments on commit 5afc5a6

Please sign in to comment.
You can’t perform that action at this time.