diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst index 07137e75c9f88..7a936051fe051 100644 --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -445,6 +445,9 @@ Bug Fixes in This Version (`#62789 `_). - Fix a crash when instantiating a non-type template argument in a dependent scope. (`#62533 `_). +- Fix crash when diagnosing default comparison method. + (`#62791 `_) and + (`#62102 `_). Bug Fixes to Compiler Builtins ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ diff --git a/clang/lib/Sema/SemaTemplateInstantiate.cpp b/clang/lib/Sema/SemaTemplateInstantiate.cpp index 32a8ba1a5c46d..b58d58ea1b052 100644 --- a/clang/lib/Sema/SemaTemplateInstantiate.cpp +++ b/clang/lib/Sema/SemaTemplateInstantiate.cpp @@ -961,11 +961,13 @@ void Sema::PrintInstantiationStack() { << MD->isExplicitlyDefaulted() << DFK.asSpecialMember() << Context.getTagDeclType(MD->getParent()); } else if (DFK.isComparison()) { + QualType RecordType = FD->getParamDecl(0) + ->getType() + .getNonReferenceType() + .getUnqualifiedType(); Diags.Report(Active->PointOfInstantiation, diag::note_comparison_synthesized_at) - << (int)DFK.asComparison() - << Context.getTagDeclType( - cast(FD->getLexicalDeclContext())); + << (int)DFK.asComparison() << RecordType; } break; } diff --git a/clang/test/CXX/class/class.compare/class.spaceship/p1.cpp b/clang/test/CXX/class/class.compare/class.spaceship/p1.cpp index c5e7226364660..cd5c8b155a9fa 100644 --- a/clang/test/CXX/class/class.compare/class.spaceship/p1.cpp +++ b/clang/test/CXX/class/class.compare/class.spaceship/p1.cpp @@ -227,5 +227,5 @@ namespace Preference { A a; std::strong_ordering operator<=>(const B&) const = default; // expected-error {{call to deleted constructor of 'A'}} }; - bool x = B() < B(); // expected-note {{in defaulted three-way comparison operator for 'Preference::B' first required here}} + bool x = B() < B(); // expected-note {{in defaulted three-way comparison operator for 'B' first required here}} } diff --git a/clang/test/SemaCXX/cxx20-default-compare.cpp b/clang/test/SemaCXX/cxx20-default-compare.cpp new file mode 100644 index 0000000000000..7074ee885ac4a --- /dev/null +++ b/clang/test/SemaCXX/cxx20-default-compare.cpp @@ -0,0 +1,17 @@ +// RUN: %clang_cc1 %s -std=c++23 -verify -Wfloat-equal + +struct Foo { + float val; + bool operator==(const Foo &) const; + friend bool operator==(const Foo &, const Foo &); + friend bool operator==(Foo, Foo ); +}; + +// Declare the defaulted comparison function as a member function. +bool Foo::operator==(const Foo &) const = default; // expected-warning {{comparing floating point with == or != is unsafe}} expected-note {{in defaulted equality comparison operator for 'Foo' first required here}} + +// Declare the defaulted comparison function as a non-member function. +bool operator==(const Foo &, const Foo &) = default; // expected-warning {{comparing floating point with == or != is unsafe}} expected-note {{in defaulted equality comparison operator for 'Foo' first required here}} + +// Declare the defaulted comparison function as a non-member function. Arguments are passed by value. +bool operator==(Foo, Foo) = default; // expected-warning {{comparing floating point with == or != is unsafe}} expected-note {{in defaulted equality comparison operator for 'Foo' first required here}}