diff --git a/clang/include/clang/Basic/FileEntry.h b/clang/include/clang/Basic/FileEntry.h index 93e84cf233a30e..d86191aaa0c7ba 100644 --- a/clang/include/clang/Basic/FileEntry.h +++ b/clang/include/clang/Basic/FileEntry.h @@ -118,10 +118,7 @@ class FileEntryRef { /// VFSs that use external names. In that case, the \c FileEntryRef /// returned by the \c FileManager will have the external name, and not the /// name that was used to lookup the file. - /// - /// The second type is really a `const MapEntry *`, but that confuses - /// gcc5.3. Once that's no longer supported, change this back. - llvm::PointerUnion V; + llvm::PointerUnion V; /// Directory the file was found in. Set if and only if V is a FileEntry. OptionalDirectoryEntryRef Dir; @@ -165,10 +162,10 @@ class FileEntryRef { /// Retrieve the base MapEntry after redirects. const MapEntry &getBaseMapEntry() const { - const MapEntry *ME = this->ME; - while (const void *Next = ME->second->V.dyn_cast()) - ME = static_cast(Next); - return *ME; + const MapEntry *Base = ME; + while (const auto *Next = Base->second->V.dyn_cast()) + Base = Next; + return *Base; } private: diff --git a/clang/lib/Basic/FileManager.cpp b/clang/lib/Basic/FileManager.cpp index e8d0f20019eba5..7d6fc47dbc3843 100644 --- a/clang/lib/Basic/FileManager.cpp +++ b/clang/lib/Basic/FileManager.cpp @@ -403,8 +403,7 @@ FileEntryRef FileManager::getVirtualFileRef(StringRef Filename, off_t Size, FileEntryRef::MapValue Value = *NamedFileEnt.second; if (LLVM_LIKELY(Value.V.is())) return FileEntryRef(NamedFileEnt); - return FileEntryRef(*reinterpret_cast( - Value.V.get())); + return FileEntryRef(*Value.V.get()); } // We've not seen this before, or the file is cached as non-existent.