diff --git a/llvm/include/llvm/MC/MCInstrAnalysis.h b/llvm/include/llvm/MC/MCInstrAnalysis.h index c3c675c39c559..e3ddf0b8b8939 100644 --- a/llvm/include/llvm/MC/MCInstrAnalysis.h +++ b/llvm/include/llvm/MC/MCInstrAnalysis.h @@ -37,6 +37,21 @@ class MCInstrAnalysis { MCInstrAnalysis(const MCInstrInfo *Info) : Info(Info) {} virtual ~MCInstrAnalysis() = default; + /// Clear the internal state. See updateState for more information. + virtual void resetState() {} + + /// Update internal state with \p Inst at \p Addr. + /// + /// For some types of analyses, inspecting a single instruction is not + /// sufficient. Some examples are auipc/jalr pairs on RISC-V or adrp/ldr pairs + /// on AArch64. To support inspecting multiple instructions, targets may keep + /// track of an internal state while analysing instructions. Clients should + /// call updateState for every instruction which allows later calls to one of + /// the analysis functions to take previous instructions into account. + /// Whenever state becomes irrelevant (e.g., when starting to disassemble a + /// new function), clients should call resetState to clear it. + virtual void updateState(const MCInst &Inst, uint64_t Addr) {} + virtual bool isBranch(const MCInst &Inst) const { return Info->get(Inst.getOpcode()).isBranch(); } diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp index 537c18bf3440d..f02bd6a9b531a 100644 --- a/llvm/tools/llvm-objdump/llvm-objdump.cpp +++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp @@ -860,7 +860,7 @@ class DisassemblerTarget { std::unique_ptr SubtargetInfo; std::shared_ptr Context; std::unique_ptr DisAsm; - std::shared_ptr InstrAnalysis; + std::shared_ptr InstrAnalysis; std::shared_ptr InstPrinter; PrettyPrinter *Printer; @@ -1283,14 +1283,19 @@ collectBBAddrMapLabels(const std::unordered_map &AddrToBBAd } } -static void collectLocalBranchTargets( - ArrayRef Bytes, const MCInstrAnalysis *MIA, MCDisassembler *DisAsm, - MCInstPrinter *IP, const MCSubtargetInfo *STI, uint64_t SectionAddr, - uint64_t Start, uint64_t End, std::unordered_map &Labels) { +static void +collectLocalBranchTargets(ArrayRef Bytes, MCInstrAnalysis *MIA, + MCDisassembler *DisAsm, MCInstPrinter *IP, + const MCSubtargetInfo *STI, uint64_t SectionAddr, + uint64_t Start, uint64_t End, + std::unordered_map &Labels) { // So far only supports PowerPC and X86. if (!STI->getTargetTriple().isPPC() && !STI->getTargetTriple().isX86()) return; + if (MIA) + MIA->resetState(); + Labels.clear(); unsigned LabelCount = 0; Start += SectionAddr; @@ -1316,6 +1321,7 @@ static void collectLocalBranchTargets( !Labels.count(Target) && !(STI->getTargetTriple().isPPC() && Target == Index)) Labels[Target] = ("L" + Twine(LabelCount++)).str(); + MIA->updateState(Inst, Index); } Index += Size; } @@ -1967,6 +1973,9 @@ disassembleObject(ObjectFile &Obj, const ObjectFile &DbgObj, BBAddrMapLabels); } + if (DT->InstrAnalysis) + DT->InstrAnalysis->resetState(); + while (Index < End) { // ARM and AArch64 ELF binaries can interleave data and text in the // same section. We rely on the markers introduced to understand what @@ -2183,6 +2192,8 @@ disassembleObject(ObjectFile &Obj, const ObjectFile &DbgObj, if (TargetOS == &CommentStream) *TargetOS << "\n"; } + + DT->InstrAnalysis->updateState(Inst, SectionAddr + Index); } }