diff --git a/clang-tools-extra/clang-rename/USRLocFinder.cpp b/clang-tools-extra/clang-rename/USRLocFinder.cpp index acb47bb41f635..f2d154eb277ff 100644 --- a/clang-tools-extra/clang-rename/USRLocFinder.cpp +++ b/clang-tools-extra/clang-rename/USRLocFinder.cpp @@ -60,6 +60,11 @@ class USRLocFindingASTVisitor bool VisitCXXConstructorDecl(clang::CXXConstructorDecl *ConstructorDecl) { for (clang::CXXConstructorDecl::init_const_iterator it = ConstructorDecl->init_begin(); it != ConstructorDecl->init_end(); ++it) { const clang::CXXCtorInitializer* Initializer = *it; + if (Initializer->getSourceOrder() == -1) { + // Ignore implicit initializers. + continue; + } + if (const clang::FieldDecl *FieldDecl = Initializer->getAnyMember()) { if (getUSRForDecl(FieldDecl) == USR) { // The initializer refers to a field that is to be renamed. diff --git a/clang-tools-extra/test/clang-rename/CtorInitializerTest.cpp b/clang-tools-extra/test/clang-rename/CtorInitializerTest.cpp new file mode 100644 index 0000000000000..dd5c790f763d6 --- /dev/null +++ b/clang-tools-extra/test/clang-rename/CtorInitializerTest.cpp @@ -0,0 +1,20 @@ +// RUN: cat %s > %t.cpp +// RUN: clang-rename -offset=162 -new-name=hector %t.cpp -i -- +// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s +class A +{ +}; + +class Cla +{ + A foo; // CHECK: hector; +public: + Cla(); +}; + +Cla::Cla() // CHECK: Cla::Cla() +{ +} + +// Use grep -FUbo 'foo' to get the correct offset of foo when changing +// this file.