Address comments.

Signed-off-by: MaheshRavishankar <mahesh.ravishankar@gmail.com>

Author: MaheshRavishankar

mlir/include/mlir/Interfaces/InferTypeOpInterface.td

@@ -401,7 +401,7 @@ def ReifyRankedShapedTypeOpInterface :
         ReifiedRankedShapedTypeDims reifiedShapes;
         if (failed(cast<ReifyRankedShapedTypeOpInterface>($_op.getOperation()).reifyResultShapes(builder, reifiedShapes)))
           return failure();
-        if (resultIndex < 0 || resultIndex >= (int)(reifiedShapes.size()))
+        if (resultIndex < 0 || resultIndex >= static_cast<int>(reifiedShapes.size()))
           return $_op.emitOpError("invalid result index");
         return reifiedShapes[resultIndex];
       }]
@@ -427,7 +427,7 @@ def ReifyRankedShapedTypeOpInterface :
         auto shapes = cast<ReifyRankedShapedTypeOpInterface>($_op.getOperation()).reifyShapeOfResult(builder, resultIndex);
         if (failed(shapes))
           return failure();
-        if (dim < 0 || dim >= (int)((*shapes).size()))
+        if (dim < 0 || dim >= static_cast<int>((*shapes).size()))
           return $_op.emitOpError("invalid dimension");
         return (*shapes)[dim];
       }]

mlir/test/Interfaces/InferShapedTypeOpInterface/resolve-shaped-type-result-dims.mlir

@@ -1,4 +1,5 @@
 // RUN: mlir-opt %s --pass-pipeline="builtin.module(func.func(resolve-shaped-type-result-dims{error-on-pattern-iteration-limit=false}))" -split-input-file | FileCheck %s
+// See %test_unreifiable_result_shape below for why `error-on-partition-iteration-limit` is set to false.
 
 func.func @result_shape(%arg0 : tensor<2x3x?xf32>, %arg1 : tensor<?x5xf32>)
     -> (index, index, index, index, index) {
@@ -114,6 +115,13 @@ func.func @reify_shaped_type_using_reify_dim_of_result(%arg0 : tensor<2x3x?xf32>
 
 // -----
 
+// This tests also indicates a problem with the approach of just using `reifyShapes`
+// without being specific about {result, dim} that needs to be resolved. The
+// `reifyShapes` implementations introduces `dim` operations that are effectively
+// dead, but it creates an infinite loop on pattern application (which eventually
+// bails on hitting the iteration limit). This is the pitfall of this legacy
+// mechanism.
+
 func.func @test_unreifiable_result_shapes(%arg0 : tensor<?x?xf32>)
     -> (index, index) {
   %c0 = arith.constant 0 : index