Skip to content

Commit

Permalink
[MLIR] Rename SideEffects.td -> SideEffectInterfaces.td
Browse files Browse the repository at this point in the history 
This normalize the name of the tablegen file with the name of the generated
files (SideEffectInterfaces.h.inc) and the other Interface tablegen files,
which all end in Interface(s).td

Differential Revision: https://reviews.llvm.org/D79517
  • Loading branch information
@stephenneuendorffer
stephenneuendorffer committed May 12, 2020
1 parent d9166ad commit 661b234
Show file tree
Hide file tree
Showing 35 changed files with 36 additions and 36 deletions.
2 changes: 1 addition & 1 deletion flang/include/flang/Optimizer/Dialect/FIROps.td
View file
Expand Up @@ -17,7 +17,7 @@
include "mlir/IR/SymbolInterfaces.td"
include "mlir/Interfaces/ControlFlowInterfaces.td"
include "mlir/Interfaces/LoopLikeInterface.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

def fir_Dialect : Dialect {
let name = "fir";
Expand Down
2 changes: 1 addition & 1 deletion mlir/examples/standalone/include/Standalone/StandaloneOps.td
View file
Expand Up @@ -10,7 +10,7 @@
#define STANDALONE_OPS

include "StandaloneDialect.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

def Standalone_FooOp : Standalone_Op<"foo", [NoSideEffect,
SameOperandsAndResultType]> {
Expand Down
2 changes: 1 addition & 1 deletion mlir/examples/toy/Ch2/include/toy/Ops.td
View file
Expand Up @@ -14,7 +14,7 @@
#define TOY_OPS

include "mlir/IR/OpBase.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

// Provide a definition of the 'toy' dialect in the ODS framework so that we
// can define our operations.
Expand Down
2 changes: 1 addition & 1 deletion mlir/examples/toy/Ch3/include/toy/Ops.td
View file
Expand Up @@ -13,7 +13,7 @@
#ifndef TOY_OPS
#define TOY_OPS

include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

// Provide a definition of the 'toy' dialect in the ODS framework so that we
// can define our operations.
Expand Down
2 changes: 1 addition & 1 deletion mlir/examples/toy/Ch4/include/toy/Ops.td
View file
Expand Up @@ -14,7 +14,7 @@
#define TOY_OPS

include "mlir/Interfaces/CallInterfaces.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"
include "toy/ShapeInferenceInterface.td"

// Provide a definition of the 'toy' dialect in the ODS framework so that we
Expand Down
2 changes: 1 addition & 1 deletion mlir/examples/toy/Ch5/include/toy/Ops.td
View file
Expand Up @@ -14,7 +14,7 @@
#define TOY_OPS

include "mlir/Interfaces/CallInterfaces.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"
include "toy/ShapeInferenceInterface.td"

// Provide a definition of the 'toy' dialect in the ODS framework so that we
Expand Down
2 changes: 1 addition & 1 deletion mlir/examples/toy/Ch6/include/toy/Ops.td
View file
Expand Up @@ -14,7 +14,7 @@
#define TOY_OPS

include "mlir/Interfaces/CallInterfaces.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"
include "toy/ShapeInferenceInterface.td"

// Provide a definition of the 'toy' dialect in the ODS framework so that we
Expand Down
2 changes: 1 addition & 1 deletion mlir/examples/toy/Ch7/include/toy/Ops.td
View file
Expand Up @@ -14,7 +14,7 @@
#define TOY_OPS

include "mlir/Interfaces/CallInterfaces.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"
include "toy/ShapeInferenceInterface.td"

// Provide a definition of the 'toy' dialect in the ODS framework so that we
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/AVX512/AVX512.td
View file
Expand Up @@ -13,7 +13,7 @@
#ifndef AVX512_OPS
#define AVX512_OPS

include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

//===----------------------------------------------------------------------===//
// AVX512 dialect definition
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/Affine/IR/AffineOps.td
View file
Expand Up @@ -15,7 +15,7 @@

include "mlir/Dialect/Affine/IR/AffineOpsBase.td"
include "mlir/Interfaces/LoopLikeInterface.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

def Affine_Dialect : Dialect {
let name = "affine";
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/GPU/GPUOps.td
View file
Expand Up @@ -16,7 +16,7 @@
include "mlir/Dialect/GPU/GPUBase.td"
include "mlir/Dialect/LLVMIR/LLVMOpBase.td"
include "mlir/IR/SymbolInterfaces.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

// Type constraint accepting standard integers, indices and wrapped LLVM integer
// types.
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
View file
Expand Up @@ -16,7 +16,7 @@
include "mlir/Dialect/LLVMIR/LLVMOpBase.td"
include "mlir/IR/SymbolInterfaces.td"
include "mlir/Interfaces/ControlFlowInterfaces.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

class LLVM_Builder<string builder> {
string llvmBuilder = builder;
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/LLVMIR/NVVMOps.td
View file
Expand Up @@ -14,7 +14,7 @@
#define NVVMIR_OPS

include "mlir/Dialect/LLVMIR/LLVMOpBase.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

//===----------------------------------------------------------------------===//
// NVVM dialect definitions
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td
View file
Expand Up @@ -14,7 +14,7 @@
#define ROCDLIR_OPS

include "mlir/Dialect/LLVMIR/LLVMOpBase.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

//===----------------------------------------------------------------------===//
// ROCDL dialect definitions
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td
View file
Expand Up @@ -15,7 +15,7 @@

include "mlir/Dialect/Affine/IR/AffineOpsBase.td"
include "mlir/Dialect/Linalg/IR/LinalgBase.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"
include "mlir/Interfaces/ViewLikeInterface.td"

// Base class for Linalg dialect ops that do not correspond to library calls.
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/Quant/QuantOps.td
View file
Expand Up @@ -14,7 +14,7 @@
#define DIALECT_QUANT_QUANT_OPS_

include "mlir/Dialect/Quant/QuantOpsBase.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

//===----------------------------------------------------------------------===//
// Base classes
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/SCF/SCFOps.td
View file
Expand Up @@ -15,7 +15,7 @@

include "mlir/Interfaces/ControlFlowInterfaces.td"
include "mlir/Interfaces/LoopLikeInterface.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

def SCF_Dialect : Dialect {
let name = "loop";
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/SPIRV/SPIRVArithmeticOps.td
View file
Expand Up @@ -15,7 +15,7 @@
#define SPIRV_ARITHMETIC_OPS

include "mlir/Dialect/SPIRV/SPIRVBase.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

class SPV_ArithmeticBinaryOp<string mnemonic, Type type,
list<OpTrait> traits = []> :
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/SPIRV/SPIRVBitOps.td
View file
Expand Up @@ -15,7 +15,7 @@
#define SPIRV_BIT_OPS

include "mlir/Dialect/SPIRV/SPIRVBase.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

class SPV_BitBinaryOp<string mnemonic, list<OpTrait> traits = []> :
// All the operands type used in bit instructions are SPV_Integer.
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/SPIRV/SPIRVCastOps.td
View file
Expand Up @@ -15,7 +15,7 @@
#define SPIRV_CAST_OPS

include "mlir/Dialect/SPIRV/SPIRVBase.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

class SPV_CastOp<string mnemonic, Type resultType, Type operandType,
list<OpTrait> traits = []> :
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/SPIRV/SPIRVCompositeOps.td
View file
Expand Up @@ -15,7 +15,7 @@
#define SPIRV_COMPOSITE_OPS

include "mlir/Dialect/SPIRV/SPIRVBase.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

// -----

Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/SPIRV/SPIRVControlFlowOps.td
View file
Expand Up @@ -17,7 +17,7 @@
include "mlir/Dialect/SPIRV/SPIRVBase.td"
include "mlir/Interfaces/CallInterfaces.td"
include "mlir/Interfaces/ControlFlowInterfaces.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

// -----

Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/SPIRV/SPIRVGLSLOps.td
View file
Expand Up @@ -14,7 +14,7 @@
#define SPIRV_GLSL_OPS

include "mlir/Dialect/SPIRV/SPIRVBase.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

//===----------------------------------------------------------------------===//
// SPIR-V GLSL 4.50 opcode specification.
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/SPIRV/SPIRVLogicalOps.td
View file
Expand Up @@ -15,7 +15,7 @@
#define SPIRV_LOGICAL_OPS

include "mlir/Dialect/SPIRV/SPIRVBase.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

class SPV_LogicalBinaryOp<string mnemonic, Type operandsType,
list<OpTrait> traits = []> :
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/SPIRV/SPIRVOps.td
View file
Expand Up @@ -33,7 +33,7 @@ include "mlir/Dialect/SPIRV/SPIRVGroupOps.td"
include "mlir/Dialect/SPIRV/SPIRVLogicalOps.td"
include "mlir/Dialect/SPIRV/SPIRVNonUniformOps.td"
include "mlir/Dialect/SPIRV/SPIRVStructureOps.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

// -----

Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/SPIRV/SPIRVStructureOps.td
View file
Expand Up @@ -18,7 +18,7 @@
include "mlir/Dialect/SPIRV/SPIRVBase.td"
include "mlir/IR/SymbolInterfaces.td"
include "mlir/Interfaces/CallInterfaces.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

// -----

Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
View file
Expand Up @@ -15,7 +15,7 @@

include "mlir/Dialect/Shape/IR/ShapeBase.td"
include "mlir/Interfaces/InferTypeOpInterface.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

//===----------------------------------------------------------------------===//
// Shape op definitions
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
View file
Expand Up @@ -16,7 +16,7 @@
include "mlir/IR/OpAsmInterface.td"
include "mlir/Interfaces/CallInterfaces.td"
include "mlir/Interfaces/ControlFlowInterfaces.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"
include "mlir/Interfaces/ViewLikeInterface.td"

def StandardOps_Dialect : Dialect {
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/Vector/VectorOps.td
View file
Expand Up @@ -14,7 +14,7 @@
#define VECTOR_OPS

include "mlir/Dialect/Affine/IR/AffineOpsBase.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

def Vector_Dialect : Dialect {
let name = "vector";
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Interfaces/CMakeLists.txt
View file
Expand Up @@ -28,7 +28,7 @@ mlir_tablegen(LoopLikeInterface.cpp.inc -gen-op-interface-defs)
add_public_tablegen_target(MLIRLoopLikeInterfaceIncGen)
add_dependencies(mlir-generic-headers MLIRLoopLikeInterfaceIncGen)

set(LLVM_TARGET_DEFINITIONS SideEffects.td)
set(LLVM_TARGET_DEFINITIONS SideEffectInterfaces.td)
mlir_tablegen(SideEffectInterfaces.h.inc -gen-op-interface-decls)
mlir_tablegen(SideEffectInterfaces.cpp.inc -gen-op-interface-defs)
add_public_tablegen_target(MLIRSideEffectOpInterfacesIncGen)
Expand Down
2 changes: 1 addition & 1 deletion mlir/include/mlir/Interfaces/SideEffects.td → ...e/mlir/Interfaces/SideEffectInterfaces.td
View file
@@ -1,4 +1,4 @@
//===-- SideEffects.td - Side Effect Interfaces ------------*- tablegen -*-===//
//===-- SideEffectInterfaces.td - Side Effect Interfaces ------------*- tablegen -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
Expand Down
4 changes: 2 additions & 2 deletions mlir/test/lib/Dialect/Test/TestOps.td
View file
Expand Up @@ -13,11 +13,11 @@ include "mlir/Dialect/Affine/IR/AffineOpsBase.td"
include "mlir/IR/OpBase.td"
include "mlir/IR/OpAsmInterface.td"
include "mlir/IR/SymbolInterfaces.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"
include "mlir/Interfaces/CallInterfaces.td"
include "mlir/Interfaces/ControlFlowInterfaces.td"
include "mlir/Interfaces/InferTypeOpInterface.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

def Test_Dialect : Dialect {
let name = "test";
Expand Down
2 changes: 1 addition & 1 deletion mlir/test/mlir-tblgen/op-decl.td
View file
@@ -1,7 +1,7 @@
// RUN: mlir-tblgen -gen-op-decls -I %S/../../include %s | FileCheck --dump-input-on-failure %s

include "mlir/IR/OpBase.td"
include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

def Test_Dialect : Dialect {
let name = "test";
Expand Down
2 changes: 1 addition & 1 deletion mlir/test/mlir-tblgen/op-side-effects.td
View file
@@ -1,6 +1,6 @@
// RUN: mlir-tblgen -gen-op-defs -I %S/../../include %s | FileCheck %s

include "mlir/Interfaces/SideEffects.td"
include "mlir/Interfaces/SideEffectInterfaces.td"

def TEST_Dialect : Dialect {
let name = "test";
Expand Down
2 changes: 1 addition & 1 deletion mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp
View file
Expand Up @@ -225,7 +225,7 @@ static bool emitIntrinsics(const llvm::RecordKeeper &records,
llvm::raw_ostream &os) {
llvm::emitSourceFileHeader("Operations for LLVM intrinsics", os);
os << "include \"mlir/Dialect/LLVMIR/LLVMOpBase.td\"\n";
os << "include \"mlir/Interfaces/SideEffects.td\"\n\n";
os << "include \"mlir/Interfaces/SideEffectInterfaces.td\"\n\n";

auto defs = records.getAllDerivedDefinitions("Intrinsic");
for (const llvm::Record *r : defs) {
Expand Down

0 comments on commit 661b234

Please sign in to comment.