diff --git a/lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp b/lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp index 87c17d44c1869..a78ca2aabe134 100644 --- a/lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp +++ b/lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp @@ -64,7 +64,7 @@ DebuggerThread::DebuggerThread(DebugDelegateSP debug_delegate) DebuggerThread::~DebuggerThread() { ::CloseHandle(m_debugging_ended_event); } Status DebuggerThread::DebugLaunch(const ProcessLaunchInfo &launch_info) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); LLDB_LOG(log, "launching '{0}'", launch_info.GetExecutableFile().GetPath()); Status result; @@ -83,7 +83,7 @@ Status DebuggerThread::DebugLaunch(const ProcessLaunchInfo &launch_info) { Status DebuggerThread::DebugAttach(lldb::pid_t pid, const ProcessAttachInfo &attach_info) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); LLDB_LOG(log, "attaching to '{0}'", pid); Status result; @@ -122,7 +122,7 @@ lldb::thread_result_t DebuggerThread::DebuggerThreadLaunchRoutine( // until after the thread routine has exited. std::shared_ptr this_ref(shared_from_this()); - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); LLDB_LOG(log, "preparing to launch '{0}' on background thread.", launch_info.GetExecutableFile().GetPath()); @@ -149,7 +149,7 @@ lldb::thread_result_t DebuggerThread::DebuggerThreadAttachRoutine( // until after the thread routine has exited. std::shared_ptr this_ref(shared_from_this()); - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); LLDB_LOG(log, "preparing to attach to process '{0}' on background thread.", pid); @@ -172,7 +172,7 @@ Status DebuggerThread::StopDebugging(bool terminate) { lldb::pid_t pid = m_process.GetProcessId(); - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); LLDB_LOG(log, "terminate = {0}, inferior={1}.", terminate, pid); // Set m_is_shutting_down to true if it was false. Return if it was already @@ -246,8 +246,7 @@ void DebuggerThread::ContinueAsyncException(ExceptionResult result) { if (!m_active_exception.get()) return; - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS | - WINDOWS_LOG_EXCEPTION); + Log *log = GetLog(WindowsLog::Process | WindowsLog::Exception); LLDB_LOG(log, "broadcasting for inferior process {0}.", m_process.GetProcessId()); @@ -265,7 +264,7 @@ void DebuggerThread::FreeProcessHandles() { } void DebuggerThread::DebugLoop() { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_EVENT); + Log *log = GetLog(WindowsLog::Event); DEBUG_EVENT dbe = {}; bool should_debug = true; LLDB_LOGV(log, "Entering WaitForDebugEvent loop"); @@ -346,8 +345,7 @@ void DebuggerThread::DebugLoop() { ExceptionResult DebuggerThread::HandleExceptionEvent(const EXCEPTION_DEBUG_INFO &info, DWORD thread_id) { - Log *log = - ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_EVENT | WINDOWS_LOG_EXCEPTION); + Log *log = GetLog(WindowsLog::Event | WindowsLog::Exception); if (m_is_shutting_down) { // A breakpoint that occurs while `m_pid_to_detach` is non-zero is a magic // exception that @@ -390,8 +388,7 @@ DebuggerThread::HandleExceptionEvent(const EXCEPTION_DEBUG_INFO &info, DWORD DebuggerThread::HandleCreateThreadEvent(const CREATE_THREAD_DEBUG_INFO &info, DWORD thread_id) { - Log *log = - ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_EVENT | WINDOWS_LOG_THREAD); + Log *log = GetLog(WindowsLog::Event | WindowsLog::Thread); LLDB_LOG(log, "Thread {0} spawned in process {1}", thread_id, m_process.GetProcessId()); HostThread thread(info.hThread); @@ -403,8 +400,7 @@ DebuggerThread::HandleCreateThreadEvent(const CREATE_THREAD_DEBUG_INFO &info, DWORD DebuggerThread::HandleCreateProcessEvent(const CREATE_PROCESS_DEBUG_INFO &info, DWORD thread_id) { - Log *log = - ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_EVENT | WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Event | WindowsLog::Process); uint32_t process_id = ::GetProcessId(info.hProcess); LLDB_LOG(log, "process {0} spawned", process_id); @@ -432,8 +428,7 @@ DebuggerThread::HandleCreateProcessEvent(const CREATE_PROCESS_DEBUG_INFO &info, DWORD DebuggerThread::HandleExitThreadEvent(const EXIT_THREAD_DEBUG_INFO &info, DWORD thread_id) { - Log *log = - ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_EVENT | WINDOWS_LOG_THREAD); + Log *log = GetLog(WindowsLog::Event | WindowsLog::Thread); LLDB_LOG(log, "Thread {0} exited with code {1} in process {2}", thread_id, info.dwExitCode, m_process.GetProcessId()); m_debug_delegate->OnExitThread(thread_id, info.dwExitCode); @@ -443,8 +438,7 @@ DebuggerThread::HandleExitThreadEvent(const EXIT_THREAD_DEBUG_INFO &info, DWORD DebuggerThread::HandleExitProcessEvent(const EXIT_PROCESS_DEBUG_INFO &info, DWORD thread_id) { - Log *log = - ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_EVENT | WINDOWS_LOG_THREAD); + Log *log = GetLog(WindowsLog::Event | WindowsLog::Thread); LLDB_LOG(log, "process {0} exited with code {1}", m_process.GetProcessId(), info.dwExitCode); @@ -456,7 +450,7 @@ DebuggerThread::HandleExitProcessEvent(const EXIT_PROCESS_DEBUG_INFO &info, DWORD DebuggerThread::HandleLoadDllEvent(const LOAD_DLL_DEBUG_INFO &info, DWORD thread_id) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_EVENT); + Log *log = GetLog(WindowsLog::Event); if (info.hFile == nullptr) { // Not sure what this is, so just ignore it. LLDB_LOG(log, "Warning: Inferior {0} has a NULL file handle, returning...", @@ -500,7 +494,7 @@ DebuggerThread::HandleLoadDllEvent(const LOAD_DLL_DEBUG_INFO &info, DWORD DebuggerThread::HandleUnloadDllEvent(const UNLOAD_DLL_DEBUG_INFO &info, DWORD thread_id) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_EVENT); + Log *log = GetLog(WindowsLog::Event); LLDB_LOG(log, "process {0} unloading DLL at addr {1:x}.", m_process.GetProcessId(), info.lpBaseOfDll); @@ -517,7 +511,7 @@ DebuggerThread::HandleODSEvent(const OUTPUT_DEBUG_STRING_INFO &info, DWORD DebuggerThread::HandleRipEvent(const RIP_INFO &info, DWORD thread_id) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_EVENT); + Log *log = GetLog(WindowsLog::Event); LLDB_LOG(log, "encountered error {0} (type={1}) in process {2} thread {3}", info.dwError, info.dwType, m_process.GetProcessId(), thread_id); diff --git a/lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp b/lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp index 3d2225ff0cb24..c007e2e4a69c9 100644 --- a/lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp +++ b/lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp @@ -84,7 +84,7 @@ NativeProcessWindows::NativeProcessWindows(lldb::pid_t pid, int terminal_fd, } Status NativeProcessWindows::Resume(const ResumeActionList &resume_actions) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); Status error; llvm::sys::ScopedLock lock(m_mutex); @@ -168,7 +168,7 @@ Status NativeProcessWindows::Halt() { Status NativeProcessWindows::Detach() { Status error; - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); StateType state = GetState(); if (state != eStateExited && state != eStateDetached) { error = DetachProcess(); @@ -403,7 +403,7 @@ NativeProcessWindows::GetFileLoadAddress(const llvm::StringRef &file_name, } void NativeProcessWindows::OnExitProcess(uint32_t exit_code) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); LLDB_LOG(log, "Process {0} exited with code {1}", GetID(), exit_code); ProcessDebugger::OnExitProcess(exit_code); @@ -417,7 +417,7 @@ void NativeProcessWindows::OnExitProcess(uint32_t exit_code) { } void NativeProcessWindows::OnDebuggerConnected(lldb::addr_t image_base) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); LLDB_LOG(log, "Debugger connected to process {0}. Image base = {1:x}", GetDebuggedProcessId(), image_base); @@ -445,7 +445,7 @@ void NativeProcessWindows::OnDebuggerConnected(lldb::addr_t image_base) { ExceptionResult NativeProcessWindows::OnDebugException(bool first_chance, const ExceptionRecord &record) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_EXCEPTION); + Log *log = GetLog(WindowsLog::Exception); llvm::sys::ScopedLock lock(m_mutex); // Let the debugger establish the internal status. diff --git a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp index d562c7df8bfa2..5c356979ca16b 100644 --- a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp +++ b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_WoW64.cpp @@ -60,7 +60,7 @@ static Status GetWoW64ThreadContextHelper(lldb::thread_t thread_handle, PWOW64_CONTEXT context_ptr, const DWORD control_flag = kWoW64ContextFlags) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); Status error; memset(context_ptr, 0, sizeof(::WOW64_CONTEXT)); context_ptr->ContextFlags = control_flag; @@ -75,7 +75,7 @@ GetWoW64ThreadContextHelper(lldb::thread_t thread_handle, static Status SetWoW64ThreadContextHelper(lldb::thread_t thread_handle, PWOW64_CONTEXT context_ptr) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); Status error; if (!::Wow64SetThreadContext(thread_handle, context_ptr)) { error.SetError(GetLastError(), eErrorTypeWin32); diff --git a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm.cpp b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm.cpp index 5cfd790c624a3..2cc16e9233310 100644 --- a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm.cpp +++ b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm.cpp @@ -88,7 +88,7 @@ CreateRegisterInfoInterface(const ArchSpec &target_arch) { static Status GetThreadContextHelper(lldb::thread_t thread_handle, PCONTEXT context_ptr, const DWORD control_flag) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); Status error; memset(context_ptr, 0, sizeof(::CONTEXT)); @@ -104,7 +104,7 @@ static Status GetThreadContextHelper(lldb::thread_t thread_handle, static Status SetThreadContextHelper(lldb::thread_t thread_handle, PCONTEXT context_ptr) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); Status error; // It's assumed that the thread has stopped. if (!::SetThreadContext(thread_handle, context_ptr)) { diff --git a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp index fc65945723218..479063d3066f2 100644 --- a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp +++ b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp @@ -105,7 +105,7 @@ CreateRegisterInfoInterface(const ArchSpec &target_arch) { static Status GetThreadContextHelper(lldb::thread_t thread_handle, PCONTEXT context_ptr, const DWORD control_flag) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); Status error; memset(context_ptr, 0, sizeof(::CONTEXT)); @@ -121,7 +121,7 @@ static Status GetThreadContextHelper(lldb::thread_t thread_handle, static Status SetThreadContextHelper(lldb::thread_t thread_handle, PCONTEXT context_ptr) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); Status error; // It's assumed that the thread has stopped. if (!::SetThreadContext(thread_handle, context_ptr)) { diff --git a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp index 45da4cd02cec3..da8db9afb3be9 100644 --- a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp +++ b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp @@ -55,7 +55,7 @@ CreateRegisterInfoInterface(const ArchSpec &target_arch) { static Status GetThreadContextHelper(lldb::thread_t thread_handle, PCONTEXT context_ptr, const DWORD control_flag) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); Status error; memset(context_ptr, 0, sizeof(::CONTEXT)); @@ -71,7 +71,7 @@ static Status GetThreadContextHelper(lldb::thread_t thread_handle, static Status SetThreadContextHelper(lldb::thread_t thread_handle, PCONTEXT context_ptr) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); Status error; if (!::SetThreadContext(thread_handle, context_ptr)) { diff --git a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp index 819cd8eb383bf..a189dbb3d4866 100644 --- a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp +++ b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_x86_64.cpp @@ -67,7 +67,7 @@ CreateRegisterInfoInterface(const ArchSpec &target_arch) { static Status GetThreadContextHelper(lldb::thread_t thread_handle, PCONTEXT context_ptr, const DWORD control_flag) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); Status error; memset(context_ptr, 0, sizeof(::CONTEXT)); @@ -83,7 +83,7 @@ static Status GetThreadContextHelper(lldb::thread_t thread_handle, static Status SetThreadContextHelper(lldb::thread_t thread_handle, PCONTEXT context_ptr) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); Status error; // It's assumed that the thread has stopped. if (!::SetThreadContext(thread_handle, context_ptr)) { diff --git a/lldb/source/Plugins/Process/Windows/Common/ProcessDebugger.cpp b/lldb/source/Plugins/Process/Windows/Common/ProcessDebugger.cpp index 91b3311dc8575..555c19adcfa9a 100644 --- a/lldb/source/Plugins/Process/Windows/Common/ProcessDebugger.cpp +++ b/lldb/source/Plugins/Process/Windows/Common/ProcessDebugger.cpp @@ -72,7 +72,7 @@ lldb::pid_t ProcessDebugger::GetDebuggedProcessId() const { } Status ProcessDebugger::DetachProcess() { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); DebuggerThreadSP debugger_thread; { // Acquire the lock only long enough to get the DebuggerThread. @@ -108,7 +108,7 @@ Status ProcessDebugger::LaunchProcess(ProcessLaunchInfo &launch_info, // thread has been kicked off. So there's no race conditions, and it // shouldn't be necessary to acquire the mutex. - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); Status result; FileSpec working_dir = launch_info.GetWorkingDirectory(); @@ -171,7 +171,7 @@ Status ProcessDebugger::LaunchProcess(ProcessLaunchInfo &launch_info, Status ProcessDebugger::AttachProcess(lldb::pid_t pid, const ProcessAttachInfo &attach_info, DebugDelegateSP delegate) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); m_session_data.reset( new ProcessWindowsData(!attach_info.GetContinueOnceAttached())); DebuggerThreadSP debugger(new DebuggerThread(delegate)); @@ -209,7 +209,7 @@ Status ProcessDebugger::AttachProcess(lldb::pid_t pid, } Status ProcessDebugger::DestroyProcess(const lldb::StateType state) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); DebuggerThreadSP debugger_thread; { // Acquire this lock inside an inner scope, only long enough to get the @@ -245,7 +245,7 @@ Status ProcessDebugger::DestroyProcess(const lldb::StateType state) { } Status ProcessDebugger::HaltProcess(bool &caused_stop) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); Status error; llvm::sys::ScopedLock lock(m_mutex); caused_stop = ::DebugBreakProcess(m_session_data->m_debugger->GetProcess() @@ -263,7 +263,7 @@ Status ProcessDebugger::ReadMemory(lldb::addr_t vm_addr, void *buf, size_t size, size_t &bytes_read) { Status error; bytes_read = 0; - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_MEMORY); + Log *log = GetLog(WindowsLog::Memory); llvm::sys::ScopedLock lock(m_mutex); if (!m_session_data) { @@ -297,7 +297,7 @@ Status ProcessDebugger::WriteMemory(lldb::addr_t vm_addr, const void *buf, size_t size, size_t &bytes_written) { Status error; bytes_written = 0; - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_MEMORY); + Log *log = GetLog(WindowsLog::Memory); llvm::sys::ScopedLock lock(m_mutex); LLDB_LOG(log, "attempting to write {0} bytes into address {1:x}", size, vm_addr); @@ -327,7 +327,7 @@ Status ProcessDebugger::AllocateMemory(size_t size, uint32_t permissions, lldb::addr_t &addr) { Status error; addr = LLDB_INVALID_ADDRESS; - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_MEMORY); + Log *log = GetLog(WindowsLog::Memory); llvm::sys::ScopedLock lock(m_mutex); LLDB_LOG(log, "attempting to allocate {0} bytes with permissions {1}", size, permissions); @@ -355,7 +355,7 @@ Status ProcessDebugger::AllocateMemory(size_t size, uint32_t permissions, Status ProcessDebugger::DeallocateMemory(lldb::addr_t vm_addr) { Status result; - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_MEMORY); + Log *log = GetLog(WindowsLog::Memory); llvm::sys::ScopedLock lock(m_mutex); LLDB_LOG(log, "attempting to deallocate bytes at address {0}", vm_addr); @@ -379,7 +379,7 @@ Status ProcessDebugger::DeallocateMemory(lldb::addr_t vm_addr) { Status ProcessDebugger::GetMemoryRegionInfo(lldb::addr_t vm_addr, MemoryRegionInfo &info) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_MEMORY); + Log *log = GetLog(WindowsLog::Memory); Status error; llvm::sys::ScopedLock lock(m_mutex); info.Clear(); @@ -484,7 +484,7 @@ void ProcessDebugger::OnDebuggerConnected(lldb::addr_t image_base) {} ExceptionResult ProcessDebugger::OnDebugException(bool first_chance, const ExceptionRecord &record) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_EXCEPTION); + Log *log = GetLog(WindowsLog::Exception); llvm::sys::ScopedLock lock(m_mutex); // FIXME: Without this check, occasionally when running the test suite // there is an issue where m_session_data can be null. It's not clear how @@ -538,7 +538,7 @@ void ProcessDebugger::OnDebugString(const std::string &string) {} void ProcessDebugger::OnDebuggerError(const Status &error, uint32_t type) { llvm::sys::ScopedLock lock(m_mutex); - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); if (m_session_data->m_initial_stop_received) { // This happened while debugging. Do we shutdown the debugging session, @@ -564,8 +564,7 @@ void ProcessDebugger::OnDebuggerError(const Status &error, uint32_t type) { Status ProcessDebugger::WaitForDebuggerConnection(DebuggerThreadSP debugger, HostProcess &process) { Status result; - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS | - WINDOWS_LOG_BREAKPOINTS); + Log *log = GetLog(WindowsLog::Process | WindowsLog::Breakpoints); LLDB_LOG(log, "Waiting for loader breakpoint."); // Block this function until we receive the initial stop from the process. diff --git a/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp b/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp index 97ba1bdc9ee9e..5398d16777ac4 100644 --- a/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp +++ b/lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp @@ -141,7 +141,7 @@ Status ProcessWindows::EnableBreakpointSite(BreakpointSite *bp_site) { if (bp_site->HardwareRequired()) return Status("Hardware breakpoints are not supported."); - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_BREAKPOINTS); + Log *log = GetLog(WindowsLog::Breakpoints); LLDB_LOG(log, "bp_site = {0:x}, id={1}, addr={2:x}", bp_site, bp_site->GetID(), bp_site->GetLoadAddress()); @@ -152,7 +152,7 @@ Status ProcessWindows::EnableBreakpointSite(BreakpointSite *bp_site) { } Status ProcessWindows::DisableBreakpointSite(BreakpointSite *bp_site) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_BREAKPOINTS); + Log *log = GetLog(WindowsLog::Breakpoints); LLDB_LOG(log, "bp_site = {0:x}, id={1}, addr={2:x}", bp_site, bp_site->GetID(), bp_site->GetLoadAddress()); @@ -165,7 +165,7 @@ Status ProcessWindows::DisableBreakpointSite(BreakpointSite *bp_site) { Status ProcessWindows::DoDetach(bool keep_stopped) { Status error; - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); StateType private_state = GetPrivateState(); if (private_state != eStateExited && private_state != eStateDetached) { error = DetachProcess(); @@ -203,7 +203,7 @@ ProcessWindows::DoAttachToProcessWithID(lldb::pid_t pid, } Status ProcessWindows::DoResume() { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); llvm::sys::ScopedLock lock(m_mutex); Status error; @@ -349,7 +349,7 @@ DumpAdditionalExceptionInformation(llvm::raw_ostream &stream, } void ProcessWindows::RefreshStateAfterStop() { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_EXCEPTION); + Log *log = GetLog(WindowsLog::Exception); llvm::sys::ScopedLock lock(m_mutex); if (!m_session_data) { @@ -520,7 +520,7 @@ bool ProcessWindows::CanDebug(lldb::TargetSP target_sp, bool ProcessWindows::DoUpdateThreadList(ThreadList &old_thread_list, ThreadList &new_thread_list) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_THREAD); + Log *log = GetLog(WindowsLog::Thread); // Add all the threads that were previously running and for which we did not // detect a thread exited event. int new_size = 0; @@ -625,7 +625,7 @@ DynamicLoaderWindowsDYLD *ProcessWindows::GetDynamicLoader() { void ProcessWindows::OnExitProcess(uint32_t exit_code) { // No need to acquire the lock since m_session_data isn't accessed. - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); LLDB_LOG(log, "Process {0} exited with code {1}", GetID(), exit_code); TargetSP target = CalculateTarget(); @@ -644,7 +644,7 @@ void ProcessWindows::OnExitProcess(uint32_t exit_code) { void ProcessWindows::OnDebuggerConnected(lldb::addr_t image_base) { DebuggerThreadSP debugger = m_session_data->m_debugger; - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); LLDB_LOG(log, "Debugger connected to process {0}. Image base = {1:x}", debugger->GetProcess().GetProcessId(), image_base); @@ -692,7 +692,7 @@ void ProcessWindows::OnDebuggerConnected(lldb::addr_t image_base) { ExceptionResult ProcessWindows::OnDebugException(bool first_chance, const ExceptionRecord &record) { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_EXCEPTION); + Log *log = GetLog(WindowsLog::Exception); llvm::sys::ScopedLock lock(m_mutex); // FIXME: Without this check, occasionally when running the test suite there @@ -809,7 +809,7 @@ void ProcessWindows::OnDebugString(const std::string &string) {} void ProcessWindows::OnDebuggerError(const Status &error, uint32_t type) { llvm::sys::ScopedLock lock(m_mutex); - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_PROCESS); + Log *log = GetLog(WindowsLog::Process); if (m_session_data->m_initial_stop_received) { // This happened while debugging. Do we shutdown the debugging session, diff --git a/lldb/source/Plugins/Process/Windows/Common/ProcessWindowsLog.h b/lldb/source/Plugins/Process/Windows/Common/ProcessWindowsLog.h index 68a9d767c227d..976591abc54aa 100644 --- a/lldb/source/Plugins/Process/Windows/Common/ProcessWindowsLog.h +++ b/lldb/source/Plugins/Process/Windows/Common/ProcessWindowsLog.h @@ -25,21 +25,10 @@ enum class WindowsLog : Log::MaskType { LLVM_MARK_AS_BITMASK_ENUM(Thread) }; -#define WINDOWS_LOG_PROCESS ::lldb_private::WindowsLog::Process -#define WINDOWS_LOG_EXCEPTION ::lldb_private::WindowsLog::Exception -#define WINDOWS_LOG_THREAD ::lldb_private::WindowsLog::Thread -#define WINDOWS_LOG_MEMORY ::lldb_private::WindowsLog::Memory -#define WINDOWS_LOG_BREAKPOINTS ::lldb_private::WindowsLog::Breakpoints -#define WINDOWS_LOG_STEP ::lldb_private::WindowsLog::Step -#define WINDOWS_LOG_REGISTERS ::lldb_private::WindowsLog::Registers -#define WINDOWS_LOG_EVENT ::lldb_private::WindowsLog::Event - class ProcessWindowsLog { public: static void Initialize(); static void Terminate(); - - static Log *GetLogIfAny(WindowsLog mask) { return GetLog(mask); } }; template <> Log::Channel &LogChannelFor(); diff --git a/lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp b/lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp index 099bae6b0f619..b443df1e7cbd1 100644 --- a/lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp +++ b/lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp @@ -112,7 +112,7 @@ bool RegisterContextWindows::AddHardwareBreakpoint(uint32_t slot, return ApplyAllRegisterValues(); #else - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); LLDB_LOG(log, "hardware breakpoints not currently supported on this arch"); return false; #endif @@ -149,7 +149,7 @@ uint32_t RegisterContextWindows::GetTriggeredHardwareBreakpointSlotId() { } bool RegisterContextWindows::CacheAllRegisterValues() { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); if (!m_context_stale) return true; diff --git a/lldb/source/Plugins/Process/Windows/Common/x86/RegisterContextWindows_x86.cpp b/lldb/source/Plugins/Process/Windows/Common/x86/RegisterContextWindows_x86.cpp index e4f1806597517..7788e2a8d9f7d 100644 --- a/lldb/source/Plugins/Process/Windows/Common/x86/RegisterContextWindows_x86.cpp +++ b/lldb/source/Plugins/Process/Windows/Common/x86/RegisterContextWindows_x86.cpp @@ -192,7 +192,7 @@ bool RegisterContextWindows_x86::ReadRegister(const RegisterInfo *reg_info, return ReadRegisterHelper(CONTEXT_CONTROL, "EFLAGS", m_context.EFlags, reg_value); default: - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); LLDB_LOG(log, "Requested unknown register {0}", reg); break; } @@ -208,7 +208,7 @@ bool RegisterContextWindows_x86::WriteRegister(const RegisterInfo *reg_info, if (!CacheAllRegisterValues()) return false; - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); uint32_t reg = reg_info->kinds[eRegisterKindLLDB]; switch (reg) { case lldb_eax_i386: @@ -263,7 +263,7 @@ bool RegisterContextWindows_x86::WriteRegister(const RegisterInfo *reg_info, bool RegisterContextWindows_x86::ReadRegisterHelper( DWORD flags_required, const char *reg_name, DWORD value, RegisterValue ®_value) const { - Log *log = ProcessWindowsLog::GetLogIfAny(WINDOWS_LOG_REGISTERS); + Log *log = GetLog(WindowsLog::Registers); if ((m_context.ContextFlags & flags_required) != flags_required) { LLDB_LOG(log, "Thread context doesn't have {0}", reg_name); return false;