diff --git a/llvm/lib/Transforms/Scalar/ADCE.cpp b/llvm/lib/Transforms/Scalar/ADCE.cpp index 1c1f838252a99..92289bbcfb0a4 100644 --- a/llvm/lib/Transforms/Scalar/ADCE.cpp +++ b/llvm/lib/Transforms/Scalar/ADCE.cpp @@ -306,7 +306,7 @@ void AggressiveDeadCodeElimination::initialize() { } // This child is something else, like an infinite loop. - for (auto DFNode : depth_first(PDTChild)) + for (auto *DFNode : depth_first(PDTChild)) markLive(BlockInfo[DFNode->getBlock()].Terminator); } diff --git a/llvm/lib/Transforms/Scalar/ConstantHoisting.cpp b/llvm/lib/Transforms/Scalar/ConstantHoisting.cpp index 73e2407fa84e0..0eaeae4ee6ba3 100644 --- a/llvm/lib/Transforms/Scalar/ConstantHoisting.cpp +++ b/llvm/lib/Transforms/Scalar/ConstantHoisting.cpp @@ -258,7 +258,7 @@ static void findBestInsertionSet(DominatorTree &DT, BlockFrequencyInfo &BFI, Orders.push_back(Entry); while (Idx != Orders.size()) { BasicBlock *Node = Orders[Idx++]; - for (auto ChildDomNode : DT.getNode(Node)->children()) { + for (auto *ChildDomNode : DT.getNode(Node)->children()) { if (Candidates.count(ChildDomNode->getBlock())) Orders.push_back(ChildDomNode->getBlock()); } diff --git a/llvm/lib/Transforms/Scalar/GVNHoist.cpp b/llvm/lib/Transforms/Scalar/GVNHoist.cpp index 5960dffa65ec4..bbff497b7d92d 100644 --- a/llvm/lib/Transforms/Scalar/GVNHoist.cpp +++ b/llvm/lib/Transforms/Scalar/GVNHoist.cpp @@ -379,7 +379,7 @@ class GVNHoist { if (!Root) return; // Depth first walk on PDom tree to fill the CHIargs at each PDF. - for (auto Node : depth_first(Root)) { + for (auto *Node : depth_first(Root)) { BasicBlock *BB = Node->getBlock(); if (!BB) continue; @@ -842,7 +842,7 @@ void GVNHoist::fillRenameStack(BasicBlock *BB, InValuesType &ValueBBs, void GVNHoist::fillChiArgs(BasicBlock *BB, OutValuesType &CHIBBs, GVNHoist::RenameStackType &RenameStack) { // For each *predecessor* (because Post-DOM) of BB check if it has a CHI - for (auto Pred : predecessors(BB)) { + for (auto *Pred : predecessors(BB)) { auto P = CHIBBs.find(Pred); if (P == CHIBBs.end()) { continue; diff --git a/llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp b/llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp index 096ce9477c3e9..b907c37a23b71 100644 --- a/llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp +++ b/llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp @@ -1898,7 +1898,7 @@ bool InductiveRangeCheckElimination::run( LLVMContext &Context = Preheader->getContext(); SmallVector RangeChecks; - for (auto BBI : L->getBlocks()) + for (auto *BBI : L->getBlocks()) if (BranchInst *TBI = dyn_cast(BBI->getTerminator())) InductiveRangeCheck::extractRangeChecksFromBranch(TBI, L, SE, BPI, RangeChecks); diff --git a/llvm/lib/Transforms/Scalar/JumpThreading.cpp b/llvm/lib/Transforms/Scalar/JumpThreading.cpp index a23f5a96646be..cbf1eb25af6e2 100644 --- a/llvm/lib/Transforms/Scalar/JumpThreading.cpp +++ b/llvm/lib/Transforms/Scalar/JumpThreading.cpp @@ -2456,7 +2456,7 @@ BasicBlock *JumpThreadingPass::splitBlockPreds(BasicBlock *BB, for (auto *NewBB : NewBBs) { BlockFrequency NewBBFreq(0); Updates.push_back({DominatorTree::Insert, NewBB, BB}); - for (auto Pred : predecessors(NewBB)) { + for (auto *Pred : predecessors(NewBB)) { Updates.push_back({DominatorTree::Delete, Pred, BB}); Updates.push_back({DominatorTree::Insert, Pred, NewBB}); if (HasProfileData) // Update frequencies between Pred -> NewBB. diff --git a/llvm/lib/Transforms/Scalar/LICM.cpp b/llvm/lib/Transforms/Scalar/LICM.cpp index ef0dab301871f..46606cd942534 100644 --- a/llvm/lib/Transforms/Scalar/LICM.cpp +++ b/llvm/lib/Transforms/Scalar/LICM.cpp @@ -2145,7 +2145,7 @@ bool llvm::promoteLoopAccessesToScalars( // Look at all the loop uses, and try to merge their locations. std::vector LoopUsesLocs; - for (auto U : LoopUses) + for (auto *U : LoopUses) LoopUsesLocs.push_back(U->getDebugLoc().get()); auto DL = DebugLoc(DILocation::getMergedLocations(LoopUsesLocs)); diff --git a/llvm/lib/Transforms/Scalar/LoopDistribute.cpp b/llvm/lib/Transforms/Scalar/LoopDistribute.cpp index f7f74675b290f..3fa7c0485a981 100644 --- a/llvm/lib/Transforms/Scalar/LoopDistribute.cpp +++ b/llvm/lib/Transforms/Scalar/LoopDistribute.cpp @@ -397,7 +397,7 @@ class InstPartitionContainer { continue; auto PartI = I->getData(); - for (auto PartJ : make_range(std::next(ToBeMerged.member_begin(I)), + for (auto *PartJ : make_range(std::next(ToBeMerged.member_begin(I)), ToBeMerged.member_end())) { PartJ->moveTo(*PartI); } diff --git a/llvm/lib/Transforms/Scalar/LoopFuse.cpp b/llvm/lib/Transforms/Scalar/LoopFuse.cpp index 19cf0eba09851..bb99ef34f3bbc 100644 --- a/llvm/lib/Transforms/Scalar/LoopFuse.cpp +++ b/llvm/lib/Transforms/Scalar/LoopFuse.cpp @@ -529,7 +529,7 @@ struct LoopDepthTree { #ifndef NDEBUG static void printLoopVector(const LoopVector &LV) { dbgs() << "****************************\n"; - for (auto L : LV) + for (auto *L : LV) printLoop(*L, dbgs()); dbgs() << "****************************\n"; } diff --git a/llvm/lib/Transforms/Scalar/NewGVN.cpp b/llvm/lib/Transforms/Scalar/NewGVN.cpp index f20135245a51d..3dfd0eb799aef 100644 --- a/llvm/lib/Transforms/Scalar/NewGVN.cpp +++ b/llvm/lib/Transforms/Scalar/NewGVN.cpp @@ -2109,7 +2109,7 @@ void NewGVN::markMemoryLeaderChangeTouched(CongruenceClass *CC) { // Touch the instructions that need to be updated after a congruence class has a // leader change, and mark changed values. void NewGVN::markValueLeaderChangeTouched(CongruenceClass *CC) { - for (auto M : *CC) { + for (auto *M : *CC) { if (auto *I = dyn_cast(M)) TouchedInstructions.set(InstrToDFSNum(I)); LeaderChanges.insert(M); @@ -2798,7 +2798,7 @@ NewGVN::makePossiblePHIOfOps(Instruction *I, // We failed to find a leader for the current ValueOp, but this might // change in case of the translated operands change. if (SafeForPHIOfOps) - for (auto Dep : CurrentDeps) + for (auto *Dep : CurrentDeps) addAdditionalUsers(Dep, I); return nullptr; @@ -2816,7 +2816,7 @@ NewGVN::makePossiblePHIOfOps(Instruction *I, LLVM_DEBUG(dbgs() << "Found phi of ops operand " << *FoundVal << " in " << getBlockName(PredBB) << "\n"); } - for (auto Dep : Deps) + for (auto *Dep : Deps) addAdditionalUsers(Dep, I); sortPHIOps(PHIOps); auto *E = performSymbolicPHIEvaluation(PHIOps, I, PHIBlock); @@ -2883,7 +2883,7 @@ void NewGVN::initializeCongruenceClasses(Function &F) { MemoryAccessToClass[MSSA->getLiveOnEntryDef()] = createMemoryClass(MSSA->getLiveOnEntryDef()); - for (auto DTN : nodes(DT)) { + for (auto *DTN : nodes(DT)) { BasicBlock *BB = DTN->getBlock(); // All MemoryAccesses are equivalent to live on entry to start. They must // be initialized to something so that initial changes are noticed. For @@ -3456,7 +3456,7 @@ bool NewGVN::runGVN() { } // Now a standard depth first ordering of the domtree is equivalent to RPO. - for (auto DTN : depth_first(DT->getRootNode())) { + for (auto *DTN : depth_first(DT->getRootNode())) { BasicBlock *B = DTN->getBlock(); const auto &BlockRange = assignDFSNumbers(B, ICount); BlockInstRange.insert({B, BlockRange}); @@ -3576,7 +3576,7 @@ void NewGVN::convertClassToDFSOrdered( const CongruenceClass &Dense, SmallVectorImpl &DFSOrderedSet, DenseMap &UseCounts, SmallPtrSetImpl &ProbablyDead) const { - for (auto D : Dense) { + for (auto *D : Dense) { // First add the value. BasicBlock *BB = getBlockForValue(D); // Constants are handled prior to ever calling this function, so @@ -3666,7 +3666,7 @@ void NewGVN::convertClassToDFSOrdered( void NewGVN::convertClassToLoadsAndStores( const CongruenceClass &Dense, SmallVectorImpl &LoadsAndStores) const { - for (auto D : Dense) { + for (auto *D : Dense) { if (!isa(D) && !isa(D)) continue; @@ -3804,7 +3804,7 @@ Value *NewGVN::findPHIOfOpsLeader(const Expression *E, if (alwaysAvailable(CC->getLeader())) return CC->getLeader(); - for (auto Member : *CC) { + for (auto *Member : *CC) { auto *MemberInst = dyn_cast(Member); if (MemberInst == OrigInst) continue; @@ -3897,7 +3897,7 @@ bool NewGVN::eliminateInstructions(Function &F) { continue; // Everything still in the TOP class is unreachable or dead. if (CC == TOPClass) { - for (auto M : *CC) { + for (auto *M : *CC) { auto *VTE = ValueToExpression.lookup(M); if (VTE && isa(VTE)) markInstructionForDeletion(cast(M)); @@ -3918,7 +3918,7 @@ bool NewGVN::eliminateInstructions(Function &F) { CC->getStoredValue() ? CC->getStoredValue() : CC->getLeader(); if (alwaysAvailable(Leader)) { CongruenceClass::MemberSet MembersLeft; - for (auto M : *CC) { + for (auto *M : *CC) { Value *Member = M; // Void things have no uses we can replace. if (Member == Leader || !isa(Member) || diff --git a/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp b/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp index 393e7e04331f7..68cf9cc77cc48 100644 --- a/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp +++ b/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp @@ -2447,7 +2447,7 @@ static void rematerializeLiveValues(CallBase *Call, assert(LastValue); ClonedValue->replaceUsesOfWith(LastValue, LastClonedValue); #ifndef NDEBUG - for (auto OpValue : ClonedValue->operand_values()) { + for (auto *OpValue : ClonedValue->operand_values()) { // Assert that cloned instruction does not use any instructions from // this chain other than LastClonedValue assert(!is_contained(ChainToBase, OpValue) && @@ -2501,7 +2501,7 @@ static void rematerializeLiveValues(CallBase *Call, } // Remove rematerializaed values from the live set - for (auto LiveValue: LiveValuesToBeDeleted) { + for (auto *LiveValue: LiveValuesToBeDeleted) { Info.LiveSet.remove(LiveValue); } } @@ -3270,7 +3270,7 @@ static void recomputeLiveInValues(GCPtrLivenessData &RevisedLivenessData, // We may have base pointers which are now live that weren't before. We need // to update the PointerToBase structure to reflect this. - for (auto V : Updated) + for (auto *V : Updated) PointerToBase.insert({ V, V }); Info.LiveSet = Updated; diff --git a/llvm/lib/Transforms/Scalar/SCCP.cpp b/llvm/lib/Transforms/Scalar/SCCP.cpp index 6d98eb4c12d04..0eb970e2b6a27 100644 --- a/llvm/lib/Transforms/Scalar/SCCP.cpp +++ b/llvm/lib/Transforms/Scalar/SCCP.cpp @@ -671,7 +671,7 @@ bool llvm::runIPSCCP( findReturnsToZap(*F, ReturnsToZap, Solver); } - for (auto F : Solver.getMRVFunctionsTracked()) { + for (auto *F : Solver.getMRVFunctionsTracked()) { assert(F->getReturnType()->isStructTy() && "The return type should be a struct"); StructType *STy = cast(F->getReturnType()); diff --git a/llvm/lib/Transforms/Scalar/StructurizeCFG.cpp b/llvm/lib/Transforms/Scalar/StructurizeCFG.cpp index ee7fd0e402e38..7e6766b885e7c 100644 --- a/llvm/lib/Transforms/Scalar/StructurizeCFG.cpp +++ b/llvm/lib/Transforms/Scalar/StructurizeCFG.cpp @@ -974,7 +974,7 @@ static bool hasOnlyUniformBranches(Region *R, unsigned UniformMDKindID, // Count of how many direct children are conditional. unsigned ConditionalDirectChildren = 0; - for (auto E : R->elements()) { + for (auto *E : R->elements()) { if (!E->isSubRegion()) { auto Br = dyn_cast(E->getEntry()->getTerminator()); if (!Br || !Br->isConditional()) @@ -998,7 +998,7 @@ static bool hasOnlyUniformBranches(Region *R, unsigned UniformMDKindID, // their direct child basic blocks' terminators, regardless of whether // subregions are uniform or not. However, this requires a very careful // look at SIAnnotateControlFlow to make sure nothing breaks there. - for (auto BB : E->getNodeAs()->blocks()) { + for (auto *BB : E->getNodeAs()->blocks()) { auto Br = dyn_cast(BB->getTerminator()); if (!Br || !Br->isConditional()) continue;