From 6bca093976ef40f36a396b11a61a44dc0f4dcd13 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Thu, 4 May 2023 14:29:28 -0700 Subject: [PATCH] SymbolFile: invert condition, remove unnecessary `else` (NFC) Remove an unnecessary `else` condition and swap the condition to be positive rather than negative to make simpler to follow. NFC --- lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp index 674977cd7b59a..e40752b9ff21b 100644 --- a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp +++ b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp @@ -1636,10 +1636,9 @@ bool SymbolFileDWARF::GetFunction(const DWARFDIE &die, SymbolContext &sc) { lldb::ModuleSP SymbolFileDWARF::GetExternalModule(ConstString name) { UpdateExternalModuleListIfNeeded(); const auto &pos = m_external_type_modules.find(name); - if (pos != m_external_type_modules.end()) - return pos->second; - else + if (pos == m_external_type_modules.end()) return lldb::ModuleSP(); + return pos->second; } DWARFDIE