diff --git a/clang/include/clang/AST/DeclBase.h b/clang/include/clang/AST/DeclBase.h index f66c5d0f8cd7b..ba84f27617f5f 100644 --- a/clang/include/clang/AST/DeclBase.h +++ b/clang/include/clang/AST/DeclBase.h @@ -518,7 +518,7 @@ class alignas(8) Decl { if (!HasAttrs) return; AttrVec &Vec = getAttrs(); - Vec.erase(std::remove_if(Vec.begin(), Vec.end(), isa), Vec.end()); + llvm::erase_if(Vec, [](Attr *A) { return isa(A); }); if (Vec.empty()) HasAttrs = false; diff --git a/llvm/include/llvm/Support/Casting.h b/llvm/include/llvm/Support/Casting.h index 41f1b6740c6ff..d6f7793d5df01 100644 --- a/llvm/include/llvm/Support/Casting.h +++ b/llvm/include/llvm/Support/Casting.h @@ -132,24 +132,30 @@ struct isa_impl_wrap { } }; -// isa - Return true if the parameter to the template is an instance of the -// template type argument. Used like this: +// isa - Return true if the parameter to the template is an instance of one +// of the template type arguments. Used like this: // // if (isa(myVal)) { ... } +// if (isa(myVal)) { ... } // template LLVM_NODISCARD inline bool isa(const Y &Val) { return isa_impl_wrap::SimpleType>::doit(Val); } +template +LLVM_NODISCARD inline bool isa(const Y &Val) { + return isa(Val) || isa(Val); +} + // isa_and_nonnull - Functionally identical to isa, except that a null value // is accepted. // -template +template LLVM_NODISCARD inline bool isa_and_nonnull(const Y &Val) { if (!Val) return false; - return isa(Val); + return isa(Val); } //===----------------------------------------------------------------------===// diff --git a/llvm/lib/Analysis/ScalarEvolution.cpp b/llvm/lib/Analysis/ScalarEvolution.cpp index 85f9794aa8d8e..3625b5e4203fb 100644 --- a/llvm/lib/Analysis/ScalarEvolution.cpp +++ b/llvm/lib/Analysis/ScalarEvolution.cpp @@ -3860,7 +3860,8 @@ bool ScalarEvolution::containsAddRecurrence(const SCEV *S) { if (I != HasRecMap.end()) return I->second; - bool FoundAddRec = SCEVExprContains(S, isa); + bool FoundAddRec = + SCEVExprContains(S, [](const SCEV *S) { return isa(S); }); HasRecMap.insert({S, FoundAddRec}); return FoundAddRec; } @@ -11201,8 +11202,9 @@ static bool findArrayDimensionsRec(ScalarEvolution &SE, // Returns true when one of the SCEVs of Terms contains a SCEVUnknown parameter. static inline bool containsParameters(SmallVectorImpl &Terms) { for (const SCEV *T : Terms) - if (SCEVExprContains(T, isa)) + if (SCEVExprContains(T, [](const SCEV *S) { return isa(S); })) return true; + return false; } diff --git a/llvm/lib/Target/PowerPC/PPCBoolRetToInt.cpp b/llvm/lib/Target/PowerPC/PPCBoolRetToInt.cpp index 104cf2ba3c004..2259a29f838ab 100644 --- a/llvm/lib/Target/PowerPC/PPCBoolRetToInt.cpp +++ b/llvm/lib/Target/PowerPC/PPCBoolRetToInt.cpp @@ -220,7 +220,7 @@ class PPCBoolRetToInt : public FunctionPass { auto Defs = findAllDefs(U); // If the values are all Constants or Arguments, don't bother - if (llvm::none_of(Defs, isa)) + if (llvm::none_of(Defs, [](Value *V) { return isa(V); })) return false; // Presently, we only know how to handle PHINode, Constant, Arguments and