From 75a1f52c1a129b2c0e77f8c54fc5182c613c2837 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 21 Oct 2020 16:14:48 -0700 Subject: [PATCH] [compiler-rt] Don't include libc++ headers from the source tree in MSAN We shouldn't be including the libc++ headers from the source tree directly, since those headers are not configured (i.e. they don't use the __config_site) header like they should, which could mean up to ABI differences Reviewed By: vitalybuka, phosek, ldionne Differential Revision: https://reviews.llvm.org/D89915 --- compiler-rt/lib/msan/tests/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/compiler-rt/lib/msan/tests/CMakeLists.txt b/compiler-rt/lib/msan/tests/CMakeLists.txt index 541356fc68d8d..de3d950948485 100644 --- a/compiler-rt/lib/msan/tests/CMakeLists.txt +++ b/compiler-rt/lib/msan/tests/CMakeLists.txt @@ -26,7 +26,6 @@ set(MSAN_UNITTEST_HEADERS ) set(MSAN_UNITTEST_COMMON_CFLAGS -nostdinc++ - -isystem ${COMPILER_RT_LIBCXX_PATH}/include ${COMPILER_RT_UNITTEST_CFLAGS} ${COMPILER_RT_GTEST_CFLAGS} -I${COMPILER_RT_SOURCE_DIR}/include @@ -67,7 +66,8 @@ macro(msan_compile obj_list source arch kind cflags) KIND ${kind} COMPILE_DEPS ${MSAN_UNITTEST_HEADERS} DEPS gtest msan - CFLAGS ${MSAN_UNITTEST_INSTRUMENTED_CFLAGS} ${cflags} + CFLAGS -isystem ${CMAKE_CURRENT_BINARY_DIR}/../libcxx_msan_${arch}/include/c++/v1 + ${MSAN_UNITTEST_INSTRUMENTED_CFLAGS} ${cflags} ) endmacro()