diff --git a/clang-tools-extra/clangd/unittests/ParsedASTTests.cpp b/clang-tools-extra/clangd/unittests/ParsedASTTests.cpp index d7100980367dc..85b8f436dd057 100644 --- a/clang-tools-extra/clangd/unittests/ParsedASTTests.cpp +++ b/clang-tools-extra/clangd/unittests/ParsedASTTests.cpp @@ -56,7 +56,7 @@ MATCHER_P(WithTemplateArgs, ArgName, "") { LangOptions LO; PrintingPolicy Policy(LO); Policy.adjustForCPlusPlus(); - for (const auto Arg : Args->asArray()) { + for (const auto &Arg : Args->asArray()) { if (SpecializationArgs.size() > 0) SpecializationArgs += ","; SpecializationArgs += Arg.getAsType().getAsString(Policy); diff --git a/clang-tools-extra/clangd/unittests/RenameTests.cpp b/clang-tools-extra/clangd/unittests/RenameTests.cpp index be491546aca83..6ced22bf3515a 100644 --- a/clang-tools-extra/clangd/unittests/RenameTests.cpp +++ b/clang-tools-extra/clangd/unittests/RenameTests.cpp @@ -404,7 +404,7 @@ TEST(RenameTest, WithinFileRename) { template <> struct Bar<[[Foo]]> {}; )cpp", }; - for (const auto T : Tests) { + for (llvm::StringRef T : Tests) { Annotations Code(T); auto TU = TestTU::withCode(Code.code()); TU.ExtraArgs.push_back("-fno-delayed-template-parsing"); diff --git a/llvm/lib/Support/Windows/Program.inc b/llvm/lib/Support/Windows/Program.inc index a23ed95fc3904..a1482bf17c604 100644 --- a/llvm/lib/Support/Windows/Program.inc +++ b/llvm/lib/Support/Windows/Program.inc @@ -197,7 +197,7 @@ static bool Execute(ProcessInfo &PI, StringRef Program, // An environment block consists of a null-terminated block of // null-terminated strings. Convert the array of environment variables to // an environment block by concatenating them. - for (const auto E : *Env) { + for (StringRef E : *Env) { SmallVector EnvString; if (std::error_code ec = windows::UTF8ToUTF16(E, EnvString)) { SetLastError(ec.value());