From 7918dbda298871cd4f7f622c4d880e9251986ffd Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Tue, 21 Jan 2020 15:28:06 +0100 Subject: [PATCH] [clangd] Handle the missing injectedClassNameType in targetDecl. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D73102 (cherry picked from commit 5d4e89975714875a86cb8e62b60d93eebefa4029) --- clang-tools-extra/clangd/FindTarget.cpp | 5 +++++ clang-tools-extra/clangd/unittests/FindTargetTests.cpp | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/clang-tools-extra/clangd/FindTarget.cpp b/clang-tools-extra/clangd/FindTarget.cpp index 71bb9d3d5066c..5bdb1a63b87c4 100644 --- a/clang-tools-extra/clangd/FindTarget.cpp +++ b/clang-tools-extra/clangd/FindTarget.cpp @@ -373,6 +373,11 @@ struct TargetFinder { void VisitTagType(const TagType *TT) { Outer.add(TT->getAsTagDecl(), Flags); } + + void VisitInjectedClassNameType(const InjectedClassNameType *ICNT) { + Outer.add(ICNT->getDecl(), Flags); + } + void VisitDecltypeType(const DecltypeType *DTT) { Outer.add(DTT->getUnderlyingType(), Flags | Rel::Underlying); } diff --git a/clang-tools-extra/clangd/unittests/FindTargetTests.cpp b/clang-tools-extra/clangd/unittests/FindTargetTests.cpp index 408ebe24e7736..bbba007d242aa 100644 --- a/clang-tools-extra/clangd/unittests/FindTargetTests.cpp +++ b/clang-tools-extra/clangd/unittests/FindTargetTests.cpp @@ -286,6 +286,14 @@ TEST_F(TargetDeclTest, Types) { )cpp"; // FIXME: We don't do a good job printing TemplateTypeParmDecls, apparently! EXPECT_DECLS("SizeOfPackExpr", ""); + + Code = R"cpp( + template + class Foo { + void f([[Foo]] x); + }; + )cpp"; + EXPECT_DECLS("InjectedClassNameTypeLoc", "class Foo"); } TEST_F(TargetDeclTest, ClassTemplate) {