diff --git a/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp b/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp index 4b1bceef25d6a..779562768efb7 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp @@ -846,7 +846,6 @@ Instruction *InstCombinerImpl::foldIntrinsicIsFPClass(IntrinsicInst &II) { Value *Src1 = II.getArgOperand(1); const ConstantInt *CMask = cast(Src1); FPClassTest Mask = static_cast(CMask->getZExtValue()); - FPClassTest InvertedMask = ~Mask; const bool IsStrict = II.isStrictFP(); Value *FNegSrc; @@ -880,23 +879,29 @@ Instruction *InstCombinerImpl::foldIntrinsicIsFPClass(IntrinsicInst &II) { return replaceInstUsesWith(II, FCmp); } - if (!IsStrict && - fpclassTestIsFCmp0(static_cast(Mask), - *II.getParent()->getParent(), Src0->getType())) { - // Equivalent of == 0. - Value *FCmp = - Builder.CreateFCmpOEQ(Src0, ConstantFP::get(Src0->getType(), 0.0)); + const bool IsUnordered = (Mask & fcNan) == fcNan; + const bool IsOrdered = (Mask & fcNan) == fcNone; + const FPClassTest OrderedMask = Mask & ~fcNan; + const FPClassTest OrderedInvertedMask = ~OrderedMask & ~fcNan; + if (!IsStrict && (IsOrdered || IsUnordered) && + fpclassTestIsFCmp0(OrderedMask, *II.getFunction(), Src0->getType())) { + Constant *Zero = ConstantFP::getZero(Src0->getType()); + // Equivalent of == 0. + Value *FCmp = IsUnordered ? Builder.CreateFCmpUEQ(Src0, Zero) + : Builder.CreateFCmpOEQ(Src0, Zero); FCmp->takeName(&II); return replaceInstUsesWith(II, FCmp); } - if (!IsStrict && - fpclassTestIsFCmp0(static_cast(InvertedMask), - *II.getParent()->getParent(), Src0->getType())) { + if (!IsStrict && (IsOrdered || IsUnordered) && + fpclassTestIsFCmp0(OrderedInvertedMask, *II.getFunction(), + Src0->getType())) { + Constant *Zero = ConstantFP::getZero(Src0->getType()); + // Equivalent of !(x == 0). - Value *FCmp = - Builder.CreateFCmpUNE(Src0, ConstantFP::get(Src0->getType(), 0.0)); + Value *FCmp = IsUnordered ? Builder.CreateFCmpUNE(Src0, Zero) + : Builder.CreateFCmpONE(Src0, Zero); FCmp->takeName(&II); return replaceInstUsesWith(II, FCmp); diff --git a/llvm/test/Transforms/InstCombine/combine-is.fpclass-and-fcmp.ll b/llvm/test/Transforms/InstCombine/combine-is.fpclass-and-fcmp.ll index 9b53f17de9345..66ee31f57f961 100644 --- a/llvm/test/Transforms/InstCombine/combine-is.fpclass-and-fcmp.ll +++ b/llvm/test/Transforms/InstCombine/combine-is.fpclass-and-fcmp.ll @@ -307,7 +307,7 @@ define i1 @class_normal_or_fcmp_ueq_zero(half %x) { define i1 @fcmp_one_zero_or_class_normal(half %x) { ; CHECK-LABEL: @fcmp_one_zero_or_class_normal( -; CHECK-NEXT: [[CLASS:%.*]] = call i1 @llvm.is.fpclass.f16(half [[X:%.*]], i32 924) +; CHECK-NEXT: [[CLASS:%.*]] = fcmp one half [[X:%.*]], 0xH0000 ; CHECK-NEXT: ret i1 [[CLASS]] ; %one.inf = fcmp one half %x, 0.0 @@ -344,7 +344,7 @@ define i1 @fcmp_one_zero_or_class_normal_dynamic(half %x) #2 { define i1 @class_normal_or_fcmp_one_zero(half %x) { ; CHECK-LABEL: @class_normal_or_fcmp_one_zero( -; CHECK-NEXT: [[CLASS:%.*]] = call i1 @llvm.is.fpclass.f16(half [[X:%.*]], i32 924) +; CHECK-NEXT: [[CLASS:%.*]] = fcmp one half [[X:%.*]], 0xH0000 ; CHECK-NEXT: ret i1 [[CLASS]] ; %one.inf = fcmp one half %x, 0.0 diff --git a/llvm/test/Transforms/InstCombine/create-class-from-logic-fcmp.ll b/llvm/test/Transforms/InstCombine/create-class-from-logic-fcmp.ll index e7d21681ff56c..58db3797cd4f4 100644 --- a/llvm/test/Transforms/InstCombine/create-class-from-logic-fcmp.ll +++ b/llvm/test/Transforms/InstCombine/create-class-from-logic-fcmp.ll @@ -224,7 +224,7 @@ define i1 @not_isfinite_or_zero_f16_multi_use_cmp1(half %x, ptr %ptr) { ; Negative test define i1 @not_isfinite_or_zero_f16_neg_inf(half %x) { ; CHECK-LABEL: @not_isfinite_or_zero_f16_neg_inf( -; CHECK-NEXT: [[CLASS:%.*]] = call i1 @llvm.is.fpclass.f16(half [[X:%.*]], i32 99) +; CHECK-NEXT: [[CLASS:%.*]] = fcmp ueq half [[X:%.*]], 0xH0000 ; CHECK-NEXT: ret i1 [[CLASS]] ; %fabs = call half @llvm.fabs.f16(half %x) diff --git a/llvm/test/Transforms/InstCombine/is_fpclass.ll b/llvm/test/Transforms/InstCombine/is_fpclass.ll index fffd23b7edaa2..cee8a88022476 100644 --- a/llvm/test/Transforms/InstCombine/is_fpclass.ll +++ b/llvm/test/Transforms/InstCombine/is_fpclass.ll @@ -152,7 +152,7 @@ define <2 x i1> @test_class_is_p0_n0_v2f32_dynamic(<2 x float> %x) "denormal-fp- define i1 @test_class_is_p0_n0_or_nan_f32(float %x) { ; CHECK-LABEL: @test_class_is_p0_n0_or_nan_f32( -; CHECK-NEXT: [[VAL:%.*]] = call i1 @llvm.is.fpclass.f32(float [[X:%.*]], i32 99) +; CHECK-NEXT: [[VAL:%.*]] = fcmp ueq float [[X:%.*]], 0.000000e+00 ; CHECK-NEXT: ret i1 [[VAL]] ; %val = call i1 @llvm.is.fpclass.f32(float %x, i32 99) ; fcZero|fcNan @@ -161,7 +161,7 @@ define i1 @test_class_is_p0_n0_or_nan_f32(float %x) { define <2 x i1> @test_class_is_p0_n0_or_nan_v2f32(<2 x float> %x) { ; CHECK-LABEL: @test_class_is_p0_n0_or_nan_v2f32( -; CHECK-NEXT: [[VAL:%.*]] = call <2 x i1> @llvm.is.fpclass.v2f32(<2 x float> [[X:%.*]], i32 99) +; CHECK-NEXT: [[VAL:%.*]] = fcmp ueq <2 x float> [[X:%.*]], zeroinitializer ; CHECK-NEXT: ret <2 x i1> [[VAL]] ; %val = call <2 x i1> @llvm.is.fpclass.v2f32(<2 x float> %x, i32 99) ; fcZero|fcNan @@ -207,7 +207,7 @@ define <2 x i1> @test_class_is_p0_n0_or_sub_or_nan_v2f32(<2 x float> %x) { define i1 @test_class_is_p0_n0_or_sub_or_nan_f32_daz(float %x) "denormal-fp-math-f32"="ieee,preserve-sign" { ; CHECK-LABEL: @test_class_is_p0_n0_or_sub_or_nan_f32_daz( -; CHECK-NEXT: [[VAL:%.*]] = call i1 @llvm.is.fpclass.f32(float [[X:%.*]], i32 243) +; CHECK-NEXT: [[VAL:%.*]] = fcmp ueq float [[X:%.*]], 0.000000e+00 ; CHECK-NEXT: ret i1 [[VAL]] ; %val = call i1 @llvm.is.fpclass.f32(float %x, i32 243) ; fcZero|fcNan|fcSubnormal @@ -216,7 +216,7 @@ define i1 @test_class_is_p0_n0_or_sub_or_nan_f32_daz(float %x) "denormal-fp-math define <2 x i1> @test_class_is_p0_n0_or_sub_or_nan_v2f32_daz(<2 x float> %x) "denormal-fp-math-f32"="ieee,preserve-sign" { ; CHECK-LABEL: @test_class_is_p0_n0_or_sub_or_nan_v2f32_daz( -; CHECK-NEXT: [[VAL:%.*]] = call <2 x i1> @llvm.is.fpclass.v2f32(<2 x float> [[X:%.*]], i32 243) +; CHECK-NEXT: [[VAL:%.*]] = fcmp ueq <2 x float> [[X:%.*]], zeroinitializer ; CHECK-NEXT: ret <2 x i1> [[VAL]] ; %val = call <2 x i1> @llvm.is.fpclass.v2f32(<2 x float> %x, i32 243) ; fcZero|fcNan|fcSubnormal @@ -243,7 +243,7 @@ define i1 @test_class_is_p0_n0_or_sub_or_qnan_f32_daz(float %x) "denormal-fp-mat define i1 @test_class_is_not_p0_n0_or_nan_f32(float %x) { ; CHECK-LABEL: @test_class_is_not_p0_n0_or_nan_f32( -; CHECK-NEXT: [[VAL:%.*]] = call i1 @llvm.is.fpclass.f32(float [[X:%.*]], i32 924) +; CHECK-NEXT: [[VAL:%.*]] = fcmp one float [[X:%.*]], 0.000000e+00 ; CHECK-NEXT: ret i1 [[VAL]] ; %val = call i1 @llvm.is.fpclass.f32(float %x, i32 924) ; ~fcZero & ~fcNan & fcAllFlags @@ -306,7 +306,7 @@ define i1 @test_class_is_not_p0_n0_or_sub_and_not_nan_f32(float %x) { define i1 @test_class_is_not_p0_n0_or_sub_and_not_nan_f32_daz(float %x) "denormal-fp-math-f32"="ieee,preserve-sign" { ; CHECK-LABEL: @test_class_is_not_p0_n0_or_sub_and_not_nan_f32_daz( -; CHECK-NEXT: [[VAL:%.*]] = call i1 @llvm.is.fpclass.f32(float [[X:%.*]], i32 780) +; CHECK-NEXT: [[VAL:%.*]] = fcmp one float [[X:%.*]], 0.000000e+00 ; CHECK-NEXT: ret i1 [[VAL]] ; %val = call i1 @llvm.is.fpclass.f32(float %x, i32 780) ; ~(fcZero|fcSubonrmal) & ~fcNan & fcAllFlags