From 852db8e97ef79db451072c4e3261c3116a4f01b6 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Sat, 17 Dec 2022 02:08:24 +0000 Subject: [PATCH] clang/unittests/Basic/SarifTest.cpp: std::optional::value => operator* --- clang/unittests/Basic/SarifTest.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/clang/unittests/Basic/SarifTest.cpp b/clang/unittests/Basic/SarifTest.cpp index 9bbed582f50b6..06ad4e7a63091 100644 --- a/clang/unittests/Basic/SarifTest.cpp +++ b/clang/unittests/Basic/SarifTest.cpp @@ -120,9 +120,9 @@ TEST_F(SarifDocumentWriterTest, canCreateDocumentWithOneRun) { ASSERT_TRUE(Driver->getString("fullName").has_value()); ASSERT_TRUE(Driver->getString("language").has_value()); - EXPECT_EQ(Driver->getString("name").value(), ShortName); - EXPECT_EQ(Driver->getString("fullName").value(), LongName); - EXPECT_EQ(Driver->getString("language").value(), "en-US"); + EXPECT_EQ(*Driver->getString("name"), ShortName); + EXPECT_EQ(*Driver->getString("fullName"), LongName); + EXPECT_EQ(*Driver->getString("language"), "en-US"); } TEST_F(SarifDocumentWriterTest, addingResultsWillCrashIfThereIsNoRun) { @@ -229,8 +229,8 @@ TEST_F(SarifDocumentWriterTest, addingResultWithValidRuleAndRunIsOk) { ASSERT_TRUE(Driver->getString("name").has_value()); ASSERT_TRUE(Driver->getString("fullName").has_value()); - EXPECT_EQ(Driver->getString("name").value(), "sarif test"); - EXPECT_EQ(Driver->getString("fullName").value(), "sarif test runner"); + EXPECT_EQ(*Driver->getString("name"), "sarif test"); + EXPECT_EQ(*Driver->getString("fullName"), "sarif test runner"); // The results are as expected EXPECT_EQ(Results->size(), 1UL);