From 913a99c47439740531e03cc7d08fc04448c0752c Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Sat, 21 Nov 2020 20:05:47 +0100 Subject: [PATCH] [BasicAA] Remove stale FIXME (NFC) If aliasGEP returns MayAlias, the code does fall through to aliasPHI etc, so this FIXME is no longer applicable. --- llvm/lib/Analysis/BasicAliasAnalysis.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/llvm/lib/Analysis/BasicAliasAnalysis.cpp b/llvm/lib/Analysis/BasicAliasAnalysis.cpp index 944ff8e9917b5..c7736e758bd1c 100644 --- a/llvm/lib/Analysis/BasicAliasAnalysis.cpp +++ b/llvm/lib/Analysis/BasicAliasAnalysis.cpp @@ -1746,8 +1746,6 @@ AliasResult BasicAAResult::aliasCheck(const Value *V1, LocationSize V1Size, if (!Pair.second) return Pair.first->second; - // FIXME: This isn't aggressively handling alias(GEP, PHI) for example: if the - // GEP can't simplify, we don't even look at the PHI cases. if (const GEPOperator *GV1 = dyn_cast(V1)) { AliasResult Result = aliasGEP(GV1, V1Size, V1AAInfo, V2, V2Size, V2AAInfo, O1, O2, AAQI);