Skip to content
Browse files

[llvm] [test] Remove non-portable EISDIR test from macho-disassemble-…


Remove the test checking error message for 'is a directory'.  It does
not seem to serve any real purpose, and it relies on matching platform
error strings which are unpredictable and makes the test fragile.
Furthermore, it fails on NetBSD where read() works on directories,
and therefore does not return EISDIR at all.

Fixes r362141.

Differential Revision:

llvm-svn: 362404
  • Loading branch information...
mgorny committed Jun 3, 2019
1 parent 2b369f8 commit 9158d57d19c84cc117d7002b2dab466a60608df4
Showing with 0 additions and 5 deletions.
  1. +0 −5 llvm/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test
@@ -15,8 +15,3 @@ MACHO_DSYM: (__TEXT,__text) section
// RUN: llvm-objdump -m -d -g -dsym %p/../Inputs/libbogus11.a %p/../../dsymutil/Inputs/basic.macho.x86_64 2>&1 | FileCheck -check-prefix BAD_INPUT %s

BAD_INPUT: is not a Mach-O or Universal file type.

// RUN: not llvm-objdump -m -d -g -dsym %p/Inputs %p/Inputs/hello-macho-thin 2>&1 | FileCheck -check-prefix DIRECTORY %s

// Windows will emit "Is a directory", whereas others emit "is a directory"
DIRECTORY: {{[i|I]}}s a directory

0 comments on commit 9158d57

Please sign in to comment.
You can’t perform that action at this time.