diff --git a/clang/lib/Sema/SemaInit.cpp b/clang/lib/Sema/SemaInit.cpp index 7097b9deb8ed66..ee6fee0ac73242 100644 --- a/clang/lib/Sema/SemaInit.cpp +++ b/clang/lib/Sema/SemaInit.cpp @@ -695,10 +695,10 @@ void InitListChecker::FillInEmptyInitForField(unsigned Init, FieldDecl *Field, // member of reference type uninitialized, the program is // ill-formed. SemaRef.Diag(Loc, diag::err_init_reference_member_uninitialized) - << Field->getType() - << ILE->getSyntacticForm()->getSourceRange(); - SemaRef.Diag(Field->getLocation(), - diag::note_uninit_reference_member); + << Field->getType() + << (ILE->isSyntacticForm() ? ILE : ILE->getSyntacticForm()) + ->getSourceRange(); + SemaRef.Diag(Field->getLocation(), diag::note_uninit_reference_member); } hadError = true; return; diff --git a/clang/test/SemaCXX/specialization-diagnose-crash.cpp b/clang/test/SemaCXX/specialization-diagnose-crash.cpp new file mode 100644 index 00000000000000..5fd387cab19d97 --- /dev/null +++ b/clang/test/SemaCXX/specialization-diagnose-crash.cpp @@ -0,0 +1,24 @@ +// RUN: %clang_cc1 -fsyntax-only %s --std=c++17 -verify +// This is a reduction of GH57370 and GH58028, originally appearing +// in libstdc++'s variant code. + +struct V1 {}; +struct V2 : V1 { + int &a; +}; + +template using void_t = void; + +template struct X { T x; }; + +template struct Variant { + Variant() = delete; // expected-note {{deleted here}} +}; + +template +struct Variant{T1()})>> {}; + +void f() { + Variant(); + Variant(); // expected-error {{call to deleted constructor}} +}