diff --git a/flang/lib/Optimizer/Builder/HLFIRTools.cpp b/flang/lib/Optimizer/Builder/HLFIRTools.cpp index 40138db20aa80..3934609491164 100644 --- a/flang/lib/Optimizer/Builder/HLFIRTools.cpp +++ b/flang/lib/Optimizer/Builder/HLFIRTools.cpp @@ -612,8 +612,13 @@ void hlfir::genLengthParameters(mlir::Location loc, fir::FirOpBuilder &builder, return; } else if (auto apply = expr.getDefiningOp()) { result.append(apply.getTypeparams().begin(), apply.getTypeparams().end()); + return; + } + if (entity.isCharacter()) { + result.push_back(builder.create(loc, expr)); + return; } - TODO(loc, "inquire type parameters of hlfir.expr"); + TODO(loc, "inquire PDTs length parameters of hlfir.expr"); } if (entity.isCharacter()) { diff --git a/flang/test/Lower/HLFIR/elemental-array-ops.f90 b/flang/test/Lower/HLFIR/elemental-array-ops.f90 index c2f0e24c5f6bf..2a6abfc78ac18 100644 --- a/flang/test/Lower/HLFIR/elemental-array-ops.f90 +++ b/flang/test/Lower/HLFIR/elemental-array-ops.f90 @@ -141,3 +141,74 @@ subroutine lower_bounds(x) ! CHECK: } ! CHECK: fir.call ! CHECK: hlfir.destroy %[[VAL_6]] + +! Check that the character length for hlfir.associate is taken from +! hlfir.apply: +subroutine char_return(x,y) + interface + elemental character(3) function callee(x) + character(3), intent(in) :: x + end function callee + end interface + character(3), intent(in) :: x(:), y(:) + logical, allocatable :: l(:) + l = x==callee(y) +end subroutine char_return +! CHECK-LABEL: func.func @_QPchar_return( +! CHECK-SAME: %[[VAL_0:.*]]: !fir.box>> {fir.bindc_name = "x"}, +! CHECK-SAME: %[[VAL_1:.*]]: !fir.box>> {fir.bindc_name = "y"}) { +! CHECK: %[[VAL_2:.*]] = fir.alloca !fir.char<1,3> {bindc_name = ".result"} +! CHECK: %[[VAL_3:.*]] = fir.alloca !fir.box>>> {bindc_name = "l", uniq_name = "_QFchar_returnEl"} +! CHECK: %[[VAL_4:.*]] = fir.zero_bits !fir.heap>> +! CHECK: %[[VAL_5:.*]] = arith.constant 0 : index +! CHECK: %[[VAL_6:.*]] = fir.shape %[[VAL_5]] : (index) -> !fir.shape<1> +! CHECK: %[[VAL_7:.*]] = fir.embox %[[VAL_4]](%[[VAL_6]]) : (!fir.heap>>, !fir.shape<1>) -> !fir.box>>> +! CHECK: fir.store %[[VAL_7]] to %[[VAL_3]] : !fir.ref>>>> +! CHECK: %[[VAL_8:.*]]:2 = hlfir.declare %[[VAL_3]] {fortran_attrs = #fir.var_attrs, uniq_name = "_QFchar_returnEl"} : (!fir.ref>>>>) -> (!fir.ref>>>>, !fir.ref>>>>) +! CHECK: %[[VAL_9:.*]] = arith.constant 3 : index +! CHECK: %[[VAL_10:.*]]:2 = hlfir.declare %[[VAL_0]] typeparams %[[VAL_9]] {fortran_attrs = #fir.var_attrs, uniq_name = "_QFchar_returnEx"} : (!fir.box>>, index) -> (!fir.box>>, !fir.box>>) +! CHECK: %[[VAL_11:.*]] = arith.constant 3 : index +! CHECK: %[[VAL_12:.*]]:2 = hlfir.declare %[[VAL_1]] typeparams %[[VAL_11]] {fortran_attrs = #fir.var_attrs, uniq_name = "_QFchar_returnEy"} : (!fir.box>>, index) -> (!fir.box>>, !fir.box>>) +! CHECK: %[[VAL_13:.*]] = arith.constant 0 : index +! CHECK: %[[VAL_14:.*]]:3 = fir.box_dims %[[VAL_12]]#0, %[[VAL_13]] : (!fir.box>>, index) -> (index, index, index) +! CHECK: %[[VAL_15:.*]] = fir.shape %[[VAL_14]]#1 : (index) -> !fir.shape<1> +! CHECK: %[[VAL_16:.*]] = arith.constant 3 : index +! CHECK: %[[VAL_17:.*]] = hlfir.elemental %[[VAL_15]] typeparams %[[VAL_16]] unordered : (!fir.shape<1>, index) -> !hlfir.expr> { +! CHECK: ^bb0(%[[VAL_18:.*]]: index): +! CHECK: %[[VAL_19:.*]] = hlfir.designate %[[VAL_12]]#0 (%[[VAL_18]]) typeparams %[[VAL_11]] : (!fir.box>>, index, index) -> !fir.ref> +! CHECK: %[[VAL_20:.*]] = fir.emboxchar %[[VAL_19]], %[[VAL_11]] : (!fir.ref>, index) -> !fir.boxchar<1> +! CHECK: %[[VAL_21:.*]] = arith.constant 3 : i64 +! CHECK: %[[VAL_22:.*]] = fir.convert %[[VAL_21]] : (i64) -> index +! CHECK: %[[VAL_23:.*]] = arith.constant 0 : index +! CHECK: %[[VAL_24:.*]] = arith.cmpi sgt, %[[VAL_22]], %[[VAL_23]] : index +! CHECK: %[[VAL_25:.*]] = arith.select %[[VAL_24]], %[[VAL_22]], %[[VAL_23]] : index +! CHECK: %[[VAL_26:.*]] = fir.call @llvm.stacksave() fastmath : () -> !fir.ref +! CHECK: %[[VAL_27:.*]] = fir.call @_QPcallee(%[[VAL_2]], %[[VAL_25]], %[[VAL_20]]) fastmath : (!fir.ref>, index, !fir.boxchar<1>) -> !fir.boxchar<1> +! CHECK: %[[VAL_28:.*]]:2 = hlfir.declare %[[VAL_2]] typeparams %[[VAL_25]] {uniq_name = ".tmp.func_result"} : (!fir.ref>, index) -> (!fir.ref>, !fir.ref>) +! CHECK: fir.call @llvm.stackrestore(%[[VAL_26]]) fastmath : (!fir.ref) -> () +! CHECK: hlfir.yield_element %[[VAL_28]]#0 : !fir.ref> +! CHECK: } +! CHECK: %[[VAL_29:.*]] = arith.constant 0 : index +! CHECK: %[[VAL_30:.*]]:3 = fir.box_dims %[[VAL_10]]#0, %[[VAL_29]] : (!fir.box>>, index) -> (index, index, index) +! CHECK: %[[VAL_31:.*]] = fir.shape %[[VAL_30]]#1 : (index) -> !fir.shape<1> +! CHECK: %[[VAL_32:.*]] = hlfir.elemental %[[VAL_31]] unordered : (!fir.shape<1>) -> !hlfir.expr> { +! CHECK: ^bb0(%[[VAL_33:.*]]: index): +! CHECK: %[[VAL_34:.*]] = hlfir.designate %[[VAL_10]]#0 (%[[VAL_33]]) typeparams %[[VAL_9]] : (!fir.box>>, index, index) -> !fir.ref> +! CHECK: %[[VAL_35:.*]] = hlfir.apply %[[VAL_36:.*]], %[[VAL_33]] typeparams %[[VAL_16]] : (!hlfir.expr>, index, index) -> !hlfir.expr> +! CHECK: %[[VAL_37:.*]]:3 = hlfir.associate %[[VAL_35]] typeparams %[[VAL_16]] {uniq_name = "adapt.valuebyref"} : (!hlfir.expr>, index) -> (!fir.ref>, !fir.ref>, i1) +! CHECK: %[[VAL_38:.*]] = fir.convert %[[VAL_34]] : (!fir.ref>) -> !fir.ref +! CHECK: %[[VAL_39:.*]] = fir.convert %[[VAL_37]]#1 : (!fir.ref>) -> !fir.ref +! CHECK: %[[VAL_40:.*]] = fir.convert %[[VAL_9]] : (index) -> i64 +! CHECK: %[[VAL_41:.*]] = fir.convert %[[VAL_16]] : (index) -> i64 +! CHECK: %[[VAL_42:.*]] = fir.call @_FortranACharacterCompareScalar1(%[[VAL_38]], %[[VAL_39]], %[[VAL_40]], %[[VAL_41]]) fastmath : (!fir.ref, !fir.ref, i64, i64) -> i32 +! CHECK: %[[VAL_43:.*]] = arith.constant 0 : i32 +! CHECK: %[[VAL_44:.*]] = arith.cmpi eq, %[[VAL_42]], %[[VAL_43]] : i32 +! CHECK: hlfir.end_associate %[[VAL_37]]#1, %[[VAL_37]]#2 : !fir.ref>, i1 +! CHECK: %[[VAL_45:.*]] = fir.convert %[[VAL_44]] : (i1) -> !fir.logical<4> +! CHECK: hlfir.yield_element %[[VAL_45]] : !fir.logical<4> +! CHECK: } +! CHECK: hlfir.assign %[[VAL_46:.*]] to %[[VAL_8]]#0 realloc : !hlfir.expr>, !fir.ref>>>> +! CHECK: hlfir.destroy %[[VAL_46]] : !hlfir.expr> +! CHECK: hlfir.destroy %[[VAL_47:.*]] : !hlfir.expr> +! CHECK: return +! CHECK: } diff --git a/flang/test/Lower/HLFIR/user-defined-assignment.f90 b/flang/test/Lower/HLFIR/user-defined-assignment.f90 index 64ff2428d9e44..9cdfef3cf68bb 100644 --- a/flang/test/Lower/HLFIR/user-defined-assignment.f90 +++ b/flang/test/Lower/HLFIR/user-defined-assignment.f90 @@ -298,3 +298,38 @@ subroutine test_allocatable(a, x) ! CHECK: } end module + +subroutine test_char_get_length(ch) + integer :: x + interface assignment(=) + subroutine test_char_get_length_callee(a,b) + integer, intent(out) :: a + character, intent(in) :: b + end subroutine test_char_get_length_callee + end interface assignment(=) + character(*) :: ch + x = 'abc'//ch +end subroutine test_char_get_length +! CHECK-LABEL: func.func @_QPtest_char_get_length( +! CHECK-SAME: %[[VAL_0:.*]]: !fir.boxchar<1> {fir.bindc_name = "ch"}) { +! CHECK: %[[VAL_1:.*]]:2 = fir.unboxchar %[[VAL_0]] : (!fir.boxchar<1>) -> (!fir.ref>, index) +! CHECK: %[[VAL_2:.*]]:2 = hlfir.declare %[[VAL_1]]#0 typeparams %[[VAL_1]]#1 {uniq_name = "_QFtest_char_get_lengthEch"} : (!fir.ref>, index) -> (!fir.boxchar<1>, !fir.ref>) +! CHECK: %[[VAL_3:.*]] = fir.alloca i32 {bindc_name = "x", uniq_name = "_QFtest_char_get_lengthEx"} +! CHECK: %[[VAL_4:.*]]:2 = hlfir.declare %[[VAL_3]] {uniq_name = "_QFtest_char_get_lengthEx"} : (!fir.ref) -> (!fir.ref, !fir.ref) +! CHECK: hlfir.region_assign { +! CHECK: %[[VAL_5:.*]] = fir.address_of(@_QQcl.616263) : !fir.ref> +! CHECK: %[[VAL_6:.*]] = arith.constant 3 : index +! CHECK: %[[VAL_7:.*]]:2 = hlfir.declare %[[VAL_5]] typeparams %[[VAL_6]] {fortran_attrs = #fir.var_attrs, uniq_name = "_QQcl.616263"} : (!fir.ref>, index) -> (!fir.ref>, !fir.ref>) +! CHECK: %[[VAL_8:.*]] = arith.addi %[[VAL_6]], %[[VAL_1]]#1 : index +! CHECK: %[[VAL_9:.*]] = hlfir.concat %[[VAL_7]]#0, %[[VAL_2]]#0 len %[[VAL_8]] : (!fir.ref>, !fir.boxchar<1>, index) -> !hlfir.expr> +! CHECK: hlfir.yield %[[VAL_9]] : !hlfir.expr> +! CHECK: } to { +! CHECK: hlfir.yield %[[VAL_4]]#0 : !fir.ref +! CHECK: } user_defined_assign (%[[VAL_10:.*]]: !hlfir.expr>) to (%[[VAL_11:.*]]: !fir.ref) { +! CHECK: %[[VAL_12:.*]] = hlfir.get_length %[[VAL_10]] : (!hlfir.expr>) -> index +! CHECK: %[[VAL_13:.*]]:3 = hlfir.associate %[[VAL_10]] typeparams %[[VAL_12]] {uniq_name = "adapt.valuebyref"} : (!hlfir.expr>, index) -> (!fir.boxchar<1>, !fir.ref>, i1) +! CHECK: fir.call @_QPtest_char_get_length_callee(%[[VAL_11]], %[[VAL_13]]#0) fastmath : (!fir.ref, !fir.boxchar<1>) -> () +! CHECK: hlfir.end_associate %[[VAL_13]]#1, %[[VAL_13]]#2 : !fir.ref>, i1 +! CHECK: } +! CHECK: return +! CHECK: }