diff --git a/clang-tools-extra/include-cleaner/lib/WalkAST.cpp b/clang-tools-extra/include-cleaner/lib/WalkAST.cpp index febdf19e695cd..e3ba2d3b60407 100644 --- a/clang-tools-extra/include-cleaner/lib/WalkAST.cpp +++ b/clang-tools-extra/include-cleaner/lib/WalkAST.cpp @@ -126,13 +126,22 @@ class ASTWalker : public RecursiveASTVisitor { } bool VisitDeclRefExpr(DeclRefExpr *DRE) { - // Static class members are handled here, as they don't produce MemberExprs. - if (DRE->getFoundDecl()->isCXXClassMember()) { - if (auto *Qual = DRE->getQualifier()) - report(DRE->getLocation(), Qual->getAsRecordDecl(), RefType::Implicit); - } else { - report(DRE->getLocation(), DRE->getFoundDecl()); + auto *FD = DRE->getFoundDecl(); + // For refs to non-meber-like decls, use the found decl. + // For member-like decls, we should have a reference from the qualifier to + // the container decl instead, which is preferred as it'll handle + // aliases/exports properly. + if (!FD->isCXXClassMember() && !llvm::isa(FD)) { + report(DRE->getLocation(), FD); + return true; } + // If the ref is without a qualifier, and is a member, ignore it. As it is + // available in current context due to some other construct (e.g. base + // specifiers, using decls) that has to spell the name explicitly. + // If it's an enum constant, it must be due to prior decl. Report references + // to it instead. + if (llvm::isa(FD) && !DRE->hasQualifier()) + report(DRE->getLocation(), FD); return true; } diff --git a/clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp b/clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp index 3a86f36e3964f..67248d4eedb91 100644 --- a/clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp +++ b/clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp @@ -50,7 +50,7 @@ std::vector testWalk(llvm::StringRef TargetCode, Inputs.ExtraFiles["target.h"] = Target.code().str(); Inputs.ExtraArgs.push_back("-include"); Inputs.ExtraArgs.push_back("target.h"); - Inputs.ExtraArgs.push_back("-std=c++17"); + Inputs.ExtraArgs.push_back("-std=c++20"); TestAST AST(Inputs); const auto &SM = AST.sourceManager(); @@ -114,7 +114,7 @@ TEST(WalkAST, DeclRef) { testWalk("int $explicit^x;", "int y = ^x;"); testWalk("int $explicit^foo();", "int y = ^foo();"); testWalk("namespace ns { int $explicit^x; }", "int y = ns::^x;"); - testWalk("struct $implicit^S { static int x; };", "int y = S::^x;"); + testWalk("struct S { static int x; };", "int y = S::^x;"); // Canonical declaration only. testWalk("extern int $explicit^x; int x;", "int y = ^x;"); // Return type of `foo` isn't used. @@ -309,6 +309,14 @@ TEST(WalkAST, Alias) { namespace ns { using ::$explicit^Foo; } template<> struct ns::Foo {};)cpp", "ns::^Foo x;"); + testWalk(R"cpp( + namespace ns { enum class foo { bar }; } + using ns::foo;)cpp", + "auto x = foo::^bar;"); + testWalk(R"cpp( + namespace ns { enum foo { bar }; } + using ns::foo::$explicit^bar;)cpp", + "auto x = ^bar;"); } TEST(WalkAST, Using) { @@ -338,6 +346,8 @@ TEST(WalkAST, Using) { } using ns::$explicit^Y;)cpp", "^Y x;"); + testWalk("namespace ns { enum E {A}; } using enum ns::$explicit^E;", + "auto x = ^A;"); } TEST(WalkAST, Namespaces) { @@ -399,10 +409,10 @@ TEST(WalkAST, NestedTypes) { } TEST(WalkAST, MemberExprs) { - testWalk("struct $implicit^S { static int f; };", "void foo() { S::^f; }"); - testWalk("struct B { static int f; }; struct $implicit^S : B {};", + testWalk("struct S { static int f; };", "void foo() { S::^f; }"); + testWalk("struct B { static int f; }; struct S : B {};", "void foo() { S::^f; }"); - testWalk("struct B { static void f(); }; struct $implicit^S : B {};", + testWalk("struct B { static void f(); }; struct S : B {};", "void foo() { S::^f; }"); testWalk("struct B { static void f(); }; ", "struct S : B { void foo() { ^f(); } };");