diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst index 44ffca26f26a2..fdbe640f704f8 100644 --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -253,6 +253,8 @@ Bug Fixes in This Version to limit non-defined/non-member functions as well. Additionally, we now diagnose requires on lambdas when not allowed, which we previously missed. (`#61748 `_) +- Fix confusing diagnostic for incorrect use of qualified concepts names. + Bug Fixes to Compiler Builtins ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -300,7 +302,7 @@ AMDGPU Support undefined symbols in the created module to be a linker error. To prevent this, pass ``-Wl,--undefined`` if compiling directly, or ``-Xoffload-linker --undefined`` if using an offloading language. -- The deprecated ``-mcode-object-v3`` and ``-mno-code-object-v3`` command-line +- The deprecated ``-mcode-object-v3`` and ``-mno-code-object-v3`` command-line options have been removed. X86 Support diff --git a/clang/lib/Parse/ParseDecl.cpp b/clang/lib/Parse/ParseDecl.cpp index 2b5829ba0ef0e..91376cf6a34e4 100644 --- a/clang/lib/Parse/ParseDecl.cpp +++ b/clang/lib/Parse/ParseDecl.cpp @@ -3448,12 +3448,12 @@ void Parser::ParseDeclarationSpecifiers( continue; } - if (TemplateId && TemplateId->Kind == TNK_Concept_template && - GetLookAheadToken(2).isOneOf(tok::kw_auto, tok::kw_decltype)) { + if (TemplateId && TemplateId->Kind == TNK_Concept_template) { DS.getTypeSpecScope() = SS; - // This is a qualified placeholder-specifier, e.g., ::C auto ... - // Consume the scope annotation and continue to consume the template-id - // as a placeholder-specifier. + // This is probably a qualified placeholder-specifier, e.g., ::C + // auto ... Consume the scope annotation and continue to consume the + // template-id as a placeholder-specifier. Let the next iteration + // diagnose a missing auto. ConsumeAnnotationToken(); continue; } diff --git a/clang/lib/Parse/Parser.cpp b/clang/lib/Parse/Parser.cpp index e6b1d3fdf70bf..c0f4556d743b2 100644 --- a/clang/lib/Parse/Parser.cpp +++ b/clang/lib/Parse/Parser.cpp @@ -1883,31 +1883,25 @@ Parser::TryAnnotateName(CorrectionCandidateCallback *CCC, return ANK_TemplateName; } [[fallthrough]]; + case Sema::NC_Concept: case Sema::NC_VarTemplate: case Sema::NC_FunctionTemplate: case Sema::NC_UndeclaredTemplate: { - // We have a type, variable or function template followed by '<'. - ConsumeToken(); - UnqualifiedId Id; - Id.setIdentifier(Name, NameLoc); - if (AnnotateTemplateIdToken( - TemplateTy::make(Classification.getTemplateName()), - Classification.getTemplateNameKind(), SS, SourceLocation(), Id)) - return ANK_Error; - return ANK_Success; - } - case Sema::NC_Concept: { - UnqualifiedId Id; - Id.setIdentifier(Name, NameLoc); + bool IsConceptName = Classification.getKind() == Sema::NC_Concept; + // We have a template name followed by '<'. Consume the identifier token so + // we reach the '<' and annotate it. if (Next.is(tok::less)) - // We have a concept name followed by '<'. Consume the identifier token so - // we reach the '<' and annotate it. ConsumeToken(); + UnqualifiedId Id; + Id.setIdentifier(Name, NameLoc); if (AnnotateTemplateIdToken( TemplateTy::make(Classification.getTemplateName()), Classification.getTemplateNameKind(), SS, SourceLocation(), Id, - /*AllowTypeAnnotation=*/false, /*TypeConstraint=*/true)) + /*AllowTypeAnnotation=*/!IsConceptName, + /*TypeConstraint=*/IsConceptName)) return ANK_Error; + if (SS.isNotEmpty()) + AnnotateScopeToken(SS, !WasScopeAnnotation); return ANK_Success; } } diff --git a/clang/test/Parser/cxx-template-template-recovery.cpp b/clang/test/Parser/cxx-template-template-recovery.cpp new file mode 100644 index 0000000000000..1230c86d924ff --- /dev/null +++ b/clang/test/Parser/cxx-template-template-recovery.cpp @@ -0,0 +1,44 @@ +// RUN: %clang_cc1 -std=c++20 -verify -fsyntax-only %s + +namespace a { + template + concept C1 = true; // #C1 + + template + auto V1 = true; // #V1 + + namespace b { + template + concept C2 = true; // #C2 + template + auto V2 = true; // #V2 + } +} + +template +concept C3 = true; // #C3 +template +auto V3 = true; // #V3 +template