From ac8a51c701ebd332a44944f8ff8545c21bc438ce Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Tue, 29 Sep 2020 20:48:32 +0200 Subject: [PATCH] [ValueTracking] Early exit known non zero for phis After D88276 we no longer expect computeKnownBits() to prove non-zeroness for cases where isKnownNonZero() can't, so don't fall through to it. --- llvm/lib/Analysis/ValueTracking.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/llvm/lib/Analysis/ValueTracking.cpp b/llvm/lib/Analysis/ValueTracking.cpp index 11377c467bee7..11eb5f303c550 100644 --- a/llvm/lib/Analysis/ValueTracking.cpp +++ b/llvm/lib/Analysis/ValueTracking.cpp @@ -2564,14 +2564,12 @@ bool isKnownNonZero(const Value *V, const APInt &DemandedElts, unsigned Depth, // Check if all incoming values are non-zero using recursion. Query RecQ = Q; unsigned NewDepth = std::max(Depth, MaxAnalysisRecursionDepth - 1); - bool AllNonZero = llvm::all_of(PN->operands(), [&](const Use &U) { + return llvm::all_of(PN->operands(), [&](const Use &U) { if (U.get() == PN) return true; RecQ.CxtI = PN->getIncomingBlock(U)->getTerminator(); return isKnownNonZero(U.get(), DemandedElts, NewDepth, RecQ); }); - if (AllNonZero) - return true; } // ExtractElement else if (const auto *EEI = dyn_cast(V)) {