diff --git a/llvm/lib/CodeGen/TypePromotion.cpp b/llvm/lib/CodeGen/TypePromotion.cpp index 3b8a83d920ca65..2dd037d2ccb0d0 100644 --- a/llvm/lib/CodeGen/TypePromotion.cpp +++ b/llvm/lib/CodeGen/TypePromotion.cpp @@ -47,7 +47,7 @@ using namespace llvm; static cl::opt -DisablePromotion("disable-type-promotion", cl::Hidden, cl::init(false), +DisablePromotion("disable-type-promotion", cl::Hidden, cl::init(true), cl::desc("Disable type promotion pass")); // The goal of this pass is to enable more efficient code generation for @@ -903,34 +903,16 @@ bool TypePromotion::TryToPromote(Value *V, unsigned PromotedWidth) { for (auto *I : CurrentVisited) I->dump(); ); - - // Check that promoting this at the IR level is most likely beneficial. It's - // more likely if we're operating over multiple blocks and handling wrapping - // instructions. unsigned ToPromote = 0; - unsigned NonFreeArgs = 0; - SmallPtrSet Blocks; for (auto *V : CurrentVisited) { - if (auto *I = dyn_cast(V)) - Blocks.insert(I->getParent()); - - if (Sources.count(V)) { - if (auto *Arg = dyn_cast(V)) { - if (!Arg->hasZExtAttr() && !Arg->hasSExtAttr()) - ++NonFreeArgs; - } + if (Sources.count(V)) continue; - } - if (Sinks.count(cast(V))) continue; - ++ToPromote; } - // DAG optimisations should be able to handle these cases better, especially - // for function arguments. - if (ToPromote < 2 || (Blocks.size() == 1 && (NonFreeArgs > SafeWrap.size()))) + if (ToPromote < 2) return false; Promoter->Mutate(OrigTy, PromotedWidth, CurrentVisited, Sources, Sinks, diff --git a/llvm/test/Transforms/TypePromotion/ARM/calls.ll b/llvm/test/Transforms/TypePromotion/ARM/calls.ll index 8c14a3a076f1ef..cd273c06150f5e 100644 --- a/llvm/test/Transforms/TypePromotion/ARM/calls.ll +++ b/llvm/test/Transforms/TypePromotion/ARM/calls.ll @@ -1,5 +1,5 @@ ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt -mtriple=arm -type-promotion -verify -S %s -o - | FileCheck %s +; RUN: opt -mtriple=arm -type-promotion -verify -disable-type-promotion=false -S %s -o - | FileCheck %s define i8 @call_with_imms(i8* %arg) { ; CHECK-LABEL: @call_with_imms( diff --git a/llvm/test/Transforms/TypePromotion/ARM/casts.ll b/llvm/test/Transforms/TypePromotion/ARM/casts.ll index 66c713ce305886..70fa617115e865 100644 --- a/llvm/test/Transforms/TypePromotion/ARM/casts.ll +++ b/llvm/test/Transforms/TypePromotion/ARM/casts.ll @@ -1,5 +1,5 @@ ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt -mtriple=arm -type-promotion -verify -S %s -o - | FileCheck %s +; RUN: opt -mtriple=arm -type-promotion -verify -disable-type-promotion=false -S %s -o - | FileCheck %s define i16 @dsp_trunc(i32 %arg0, i32 %arg1, i16* %gep0, i16* %gep1) { ; CHECK-LABEL: @dsp_trunc( diff --git a/llvm/test/Transforms/TypePromotion/ARM/clear-structures.ll b/llvm/test/Transforms/TypePromotion/ARM/clear-structures.ll index aae729fcc92c53..117c4c0d5c8a4e 100644 --- a/llvm/test/Transforms/TypePromotion/ARM/clear-structures.ll +++ b/llvm/test/Transforms/TypePromotion/ARM/clear-structures.ll @@ -1,5 +1,5 @@ ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt -mtriple=arm -type-promotion -verify -S %s -o - | FileCheck %s +; RUN: opt -mtriple=arm -type-promotion -verify -disable-type-promotion=false -S %s -o - | FileCheck %s define i32 @clear_structures(i8* nocapture readonly %fmt, [1 x i32] %ap.coerce, i8* %out, void (i32, i8*)* nocapture %write) { ; CHECK-LABEL: @clear_structures( diff --git a/llvm/test/Transforms/TypePromotion/ARM/icmps.ll b/llvm/test/Transforms/TypePromotion/ARM/icmps.ll index 8d33c345c640ae..6dda15c309b4a9 100644 --- a/llvm/test/Transforms/TypePromotion/ARM/icmps.ll +++ b/llvm/test/Transforms/TypePromotion/ARM/icmps.ll @@ -1,5 +1,5 @@ ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt -mtriple=arm -type-promotion -verify -S %s -o - | FileCheck %s +; RUN: opt -mtriple=arm -type-promotion -verify -disable-type-promotion=false -S %s -o - | FileCheck %s define i32 @test_ult_254_inc_imm(i8 zeroext %x) { ; CHECK-LABEL: @test_ult_254_inc_imm( diff --git a/llvm/test/Transforms/TypePromotion/ARM/phis-ret.ll b/llvm/test/Transforms/TypePromotion/ARM/phis-ret.ll index 12001a40aa084c..e79e4ff1bdb2ea 100644 --- a/llvm/test/Transforms/TypePromotion/ARM/phis-ret.ll +++ b/llvm/test/Transforms/TypePromotion/ARM/phis-ret.ll @@ -1,5 +1,5 @@ ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt -mtriple=arm -type-promotion -verify -S %s -o - | FileCheck %s +; RUN: opt -mtriple=arm -type-promotion -verify -disable-type-promotion=false -S %s -o - | FileCheck %s ; Check that the arguments are extended but then nothing else is. ; This also ensures that the pass can handle loops. diff --git a/llvm/test/Transforms/TypePromotion/ARM/pointers.ll b/llvm/test/Transforms/TypePromotion/ARM/pointers.ll index 7369b18bbd6471..3c5f097b1b92b9 100644 --- a/llvm/test/Transforms/TypePromotion/ARM/pointers.ll +++ b/llvm/test/Transforms/TypePromotion/ARM/pointers.ll @@ -1,5 +1,5 @@ ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt -mtriple=arm -type-promotion -verify -S %s -o - | FileCheck %s +; RUN: opt -mtriple=arm -type-promotion -verify -disable-type-promotion=false -S %s -o - | FileCheck %s define void @phi_pointers(i16* %a, i16* %b, i8 zeroext %M, i8 zeroext %N) { ; CHECK-LABEL: @phi_pointers( diff --git a/llvm/test/Transforms/TypePromotion/ARM/signed-icmps.ll b/llvm/test/Transforms/TypePromotion/ARM/signed-icmps.ll index 3655ff0e7e63b5..dfdd4c10ae87a0 100644 --- a/llvm/test/Transforms/TypePromotion/ARM/signed-icmps.ll +++ b/llvm/test/Transforms/TypePromotion/ARM/signed-icmps.ll @@ -1,5 +1,5 @@ ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt -mtriple=arm -type-promotion -verify -S %s -o - | FileCheck %s +; RUN: opt -mtriple=arm -type-promotion -verify -disable-type-promotion=false -S %s -o - | FileCheck %s define i8 @eq_sgt(i8* %x, i8 *%y, i8 zeroext %z) { ; CHECK-LABEL: @eq_sgt( diff --git a/llvm/test/Transforms/TypePromotion/ARM/signed.ll b/llvm/test/Transforms/TypePromotion/ARM/signed.ll index e2fabb93fbd519..143220a53b5c27 100644 --- a/llvm/test/Transforms/TypePromotion/ARM/signed.ll +++ b/llvm/test/Transforms/TypePromotion/ARM/signed.ll @@ -1,5 +1,5 @@ ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt -mtriple=arm -type-promotion -verify -S %s -o - | FileCheck %s +; RUN: opt -mtriple=arm -type-promotion -verify -disable-type-promotion=false -S %s -o - | FileCheck %s ; Test to check that ARMCodeGenPrepare doesn't optimised away sign extends. define i16 @test_signed_load(i16* %ptr) { diff --git a/llvm/test/Transforms/TypePromotion/ARM/switch.ll b/llvm/test/Transforms/TypePromotion/ARM/switch.ll index 058101f3495157..6736ebeea4c435 100644 --- a/llvm/test/Transforms/TypePromotion/ARM/switch.ll +++ b/llvm/test/Transforms/TypePromotion/ARM/switch.ll @@ -1,5 +1,5 @@ ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt -mtriple=arm -type-promotion -verify -S %s -o - | FileCheck %s +; RUN: opt -mtriple=arm -type-promotion -verify -disable-type-promotion=false -S %s -o - | FileCheck %s define void @truncate_source_phi_switch(i8* %memblock, i8* %store, i16 %arg) { ; CHECK-LABEL: @truncate_source_phi_switch( diff --git a/llvm/test/Transforms/TypePromotion/ARM/wrapping.ll b/llvm/test/Transforms/TypePromotion/ARM/wrapping.ll index 346114aac3cd35..23e50dec0ca107 100644 --- a/llvm/test/Transforms/TypePromotion/ARM/wrapping.ll +++ b/llvm/test/Transforms/TypePromotion/ARM/wrapping.ll @@ -1,5 +1,5 @@ ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py -; RUN: opt -mtriple=arm -type-promotion -verify -S %s -o - | FileCheck %s +; RUN: opt -mtriple=arm -type-promotion -verify -disable-type-promotion=false -S %s -o - | FileCheck %s define zeroext i16 @overflow_add(i16 zeroext %a, i16 zeroext %b) { ; CHECK-LABEL: @overflow_add(