Skip to content
Permalink
Browse files

[Attributor][NFC] Invalid DerefState is at fixpoint

Summary:
If the DerefBytesState (and thereby the DerefState) is invalid, we
reached a fixpoint for the whole DerefState as we will not
manifest/provide information then.

Reviewers: uenoku, sstefan1

Subscribers: hiraditya, bollu, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65586

llvm-svn: 367789
  • Loading branch information
jdoerfert committed Aug 4, 2019
1 parent 5a4989e commit b6acee5c7b190de451f4f4e13a82238cb3e68f6e
Showing with 3 additions and 2 deletions.
  1. +3 −2 llvm/lib/Transforms/IPO/Attributor.cpp
@@ -1757,9 +1757,10 @@ struct DerefState : AbstractState {
/// See AbstractState::isValidState()
bool isValidState() const override { return DerefBytesState.isValidState(); }

// See AbstractState::isAtFixpoint()
/// See AbstractState::isAtFixpoint()
bool isAtFixpoint() const override {
return DerefBytesState.isAtFixpoint() && NonNullGlobalState.isAtFixpoint();
return !isValidState() || (DerefBytesState.isAtFixpoint() &&
NonNullGlobalState.isAtFixpoint());
}

/// See AbstractState::indicateOptimisticFixpoint(...)

0 comments on commit b6acee5

Please sign in to comment.
You can’t perform that action at this time.