Skip to content

Commit

Permalink
[Lex] Make sure to notify MultipleIncludeOpt for "read tokens" duri…
Browse files Browse the repository at this point in the history
…ng fast dependency directive lexing

Otherwise a header may be erroneously marked as having a header macro guard and won't get re-included.

Differential Revision: https://reviews.llvm.org/D128772
  • Loading branch information
akyrtzi committed Jun 29, 2022
1 parent 6fa65f8 commit c68b8c8
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 0 deletions.
4 changes: 4 additions & 0 deletions clang/lib/Lex/Lexer.cpp
Expand Up @@ -4248,6 +4248,10 @@ bool Lexer::LexDependencyDirectiveToken(Token &Result) {

const dependency_directives_scan::Token &DDTok =
DepDirectives.front().Tokens[NextDepDirectiveTokenIndex++];
if (NextDepDirectiveTokenIndex > 1 || DDTok.Kind != tok::hash) {
// Read something other than a preprocessor directive hash.
MIOpt.ReadToken();
}

const char *TokPtr = convertDependencyDirectiveToken(DDTok, Result);

Expand Down
47 changes: 47 additions & 0 deletions clang/test/ClangScanDeps/more-content-after-headerguard.c
@@ -0,0 +1,47 @@
// RUN: rm -rf %t
// RUN: split-file %s %t
// RUN: sed -e "s|DIR|%/t|g" %t/cdb.json.template > %t/cdb.json

// RUN: clang-scan-deps -compilation-database %t/cdb.json | FileCheck %s

// CHECK: t.c
// CHECK: top.h
// CHECK: n1.h
// CHECK: n2.h
// CHECK: n3.h

//--- cdb.json.template
[
{
"directory": "DIR",
"command": "clang -fsyntax-only DIR/t.c",
"file": "DIR/t.c"
}
]

//--- t.c

#include "top.h"
#define INCLUDE_N3
#include "top.h"

//--- top.h
#ifndef _TOP_H_
#define _TOP_H_

#include "n1.h"

#endif

// More stuff after following '#endif', should invalidate the macro guard optimization,
// and allow `top.h` to get re-included.
#include "n2.h"

//--- n1.h

//--- n2.h
#ifdef INCLUDE_N3
#include "n3.h"
#endif

//--- n3.h

0 comments on commit c68b8c8

Please sign in to comment.