diff --git a/clang/lib/Analysis/FlowSensitive/Transfer.cpp b/clang/lib/Analysis/FlowSensitive/Transfer.cpp index 5ad176dc1cdbe..d69e0f5a5e103 100644 --- a/clang/lib/Analysis/FlowSensitive/Transfer.cpp +++ b/clang/lib/Analysis/FlowSensitive/Transfer.cpp @@ -419,8 +419,7 @@ class TransferVisitor : public ConstStmtVisitor { // FIXME: Implement pointers to members. For now, don't associate a value // with this expression. break; - case CK_FunctionToPointerDecay: - case CK_BuiltinFnToFnPtr: { + case CK_FunctionToPointerDecay: { StorageLocation *PointeeLoc = Env.getStorageLocation(*SubExpr, SkipPast::Reference); if (PointeeLoc == nullptr) @@ -432,6 +431,12 @@ class TransferVisitor : public ConstStmtVisitor { Env.setValue(PointerLoc, PointerVal); break; } + case CK_BuiltinFnToFnPtr: + // Despite its name, the result type of `BuiltinFnToFnPtr` is a function, + // not a function pointer. In addition, builtin functions can only be + // called directly; it is not legal to take their address. We therefore + // don't need to create a value or storage location for them. + break; default: break; } diff --git a/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp b/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp index 3f99ff5652ce2..83ea176034c0d 100644 --- a/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp +++ b/clang/unittests/Analysis/FlowSensitive/TransferTest.cpp @@ -5480,8 +5480,8 @@ TEST(TransferTest, FunctionToPointerDecayHasValue) { }); } -// Check that the pointer that a builtin function decays to is associated with -// a value. +// Check that a builtin function is not associated with a value. (It's only +// possible to call builtin functions directly, not take their address.) TEST(TransferTest, BuiltinFunctionModeled) { std::string Code = R"( void target() { @@ -5509,7 +5509,7 @@ TEST(TransferTest, BuiltinFunctionModeled) { ASTCtx)); ASSERT_THAT(ImplicitCast, NotNull()); - EXPECT_THAT(Env.getValueStrict(*ImplicitCast), NotNull()); + EXPECT_THAT(Env.getValueStrict(*ImplicitCast), IsNull()); }); }