Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[clang] Fix delayed template parsing
Commit 98390cc fixed late template instantiation by clearing FP pragma stack before instantiation. This solution was based on the assumptions: - FP pragma stack is not used anymore and it is safe to clear it, - Default FP options are determined by command line options. Both the assumptions are wrong. When compilation produces precompiled header file, state of the stack is serialized and then restored when the precompiled header is used. Delayed template parsing occurs at the end of translation unit but before serialization, so clearing FP pragma stack effects serialized representation. When the precompiled file is loaded, some conditions can be broken and clang crashed, it was described in #63704. The crash was observed only in few cases, on most buildbots it was absent. The violation of expected conditions was caused by violation of the second assumption. FPEvalMethod can be modified by target, so it is not possible to deduce it from LangOptions only. So default FP state read from precompiled header was different from the state in the initialized Sema, and this was the crash reason. Only two targets do such modification of default FP options, these are i386 and AIX. so the problem was hard to reproduce. Delayed template parsing should occur with empty pragma stack, so it must be cleared before the instantiation, but the stack now is saved and restored after the instantiation is done. This change should fix #63704. Differential Revision: https://reviews.llvm.org/D155380
- Loading branch information