Skip to content

Commit

Permalink
AMDGPU: Remove IsSourceOfDivergence check
Browse files Browse the repository at this point in the history
This bit is not set/reserved in td file. Let's remove it for now,
we can always add it back if we need it.

Reviewed by: foad

Differential Revision: https://reviews.llvm.org/D141223
  • Loading branch information
ruiling committed Jan 11, 2023
1 parent 5d0ff92 commit cce24b6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
7 changes: 0 additions & 7 deletions llvm/lib/Target/AMDGPU/SIDefines.h
Expand Up @@ -130,13 +130,6 @@ enum : uint64_t {

// Is a WMMA instruction.
IsWMMA = UINT64_C(1) << 59,

// Is source of divergence.
//
// Note: There is no corresponding SIInstrInfo::IsSourceOfDivergence method
// by design, since this flag only covers opcodes that are _always_ divergent.
// Use SIInstrInfo::getInstructionUniformity for a more complete analysis.
IsSourceOfDivergence = UINT64_C(1) << 60
};

// v_cmp_class_* etc. use a 10-bit mask for what operation is checked.
Expand Down
3 changes: 0 additions & 3 deletions llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
Expand Up @@ -8404,9 +8404,6 @@ SIInstrInfo::getGenericInstructionUniformity(const MachineInstr &MI) const {

InstructionUniformity
SIInstrInfo::getInstructionUniformity(const MachineInstr &MI) const {
if (MI.getDesc().TSFlags & SIInstrFlags::IsSourceOfDivergence)
return InstructionUniformity::NeverUniform;

// Atomics are divergent because they are executed sequentially: when an
// atomic operation refers to the same address in each thread, then each
// thread after the first sees the value written by the previous thread as
Expand Down

0 comments on commit cce24b6

Please sign in to comment.