diff --git a/flang/lib/Optimizer/CodeGen/CMakeLists.txt b/flang/lib/Optimizer/CodeGen/CMakeLists.txt index 016544ef870a5..1d65e1de6df4c 100644 --- a/flang/lib/Optimizer/CodeGen/CMakeLists.txt +++ b/flang/lib/Optimizer/CodeGen/CMakeLists.txt @@ -23,6 +23,7 @@ add_flang_library(FIRCodeGen MLIRMathToFuncs MLIRMathToLLVM MLIRMathToLibm + MLIROpenACCToLLVM MLIROpenMPToLLVM MLIRBuiltinToLLVMIRTranslation MLIRLLVMToLLVMIRTranslation diff --git a/flang/lib/Optimizer/CodeGen/CodeGen.cpp b/flang/lib/Optimizer/CodeGen/CodeGen.cpp index a9efba4708639..d294fb4d676fa 100644 --- a/flang/lib/Optimizer/CodeGen/CodeGen.cpp +++ b/flang/lib/Optimizer/CodeGen/CodeGen.cpp @@ -31,8 +31,11 @@ #include "mlir/Conversion/MathToFuncs/MathToFuncs.h" #include "mlir/Conversion/MathToLLVM/MathToLLVM.h" #include "mlir/Conversion/MathToLibm/MathToLibm.h" +#include "mlir/Conversion/OpenACCToLLVM/ConvertOpenACCToLLVM.h" #include "mlir/Conversion/OpenMPToLLVM/ConvertOpenMPToLLVM.h" +#include "mlir/Conversion/ReconcileUnrealizedCasts/ReconcileUnrealizedCasts.h" #include "mlir/Dialect/LLVMIR/LLVMDialect.h" +#include "mlir/Dialect/OpenACC/OpenACC.h" #include "mlir/Dialect/OpenMP/OpenMPDialect.h" #include "mlir/IR/BuiltinTypes.h" #include "mlir/IR/Matchers.h" @@ -3640,6 +3643,29 @@ struct MustBeDeadConversion : public FIROpConversion { } }; +struct UnrealizedConversionCastOpConversion + : public FIROpConversion { + using FIROpConversion::FIROpConversion; + + mlir::LogicalResult + matchAndRewrite(mlir::UnrealizedConversionCastOp op, OpAdaptor adaptor, + mlir::ConversionPatternRewriter &rewriter) const override { + assert(op.getOutputs().getTypes().size() == 1 && "expect a single type"); + mlir::Type convertedType = convertType(op.getOutputs().getTypes()[0]); + if (convertedType == adaptor.getInputs().getTypes()[0]) { + rewriter.replaceOp(op, adaptor.getInputs()); + return mlir::success(); + } + + convertedType = adaptor.getInputs().getTypes()[0]; + if (convertedType == op.getOutputs().getType()[0]) { + rewriter.replaceOp(op, adaptor.getInputs()); + return mlir::success(); + } + return mlir::failure(); + } +}; + struct ShapeOpConversion : public MustBeDeadConversion { using MustBeDeadConversion::MustBeDeadConversion; }; @@ -3762,9 +3788,11 @@ class FIRToLLVMLowering SliceOpConversion, StoreOpConversion, StringLitOpConversion, SubcOpConversion, TypeDescOpConversion, UnboxCharOpConversion, UnboxProcOpConversion, UndefOpConversion, UnreachableOpConversion, - XArrayCoorOpConversion, XEmboxOpConversion, XReboxOpConversion, - ZeroOpConversion>(typeConverter, options); + UnrealizedConversionCastOpConversion, XArrayCoorOpConversion, + XEmboxOpConversion, XReboxOpConversion, ZeroOpConversion>(typeConverter, + options); mlir::populateFuncToLLVMConversionPatterns(typeConverter, pattern); + mlir::populateOpenACCToLLVMConversionPatterns(typeConverter, pattern); mlir::populateOpenMPToLLVMConversionPatterns(typeConverter, pattern); mlir::arith::populateArithToLLVMConversionPatterns(typeConverter, pattern); mlir::cf::populateControlFlowToLLVMConversionPatterns(typeConverter, @@ -3781,6 +3809,7 @@ class FIRToLLVMLowering // legalize conversion of OpenMP operations without regions. mlir::configureOpenMPToLLVMConversionLegality(target, typeConverter); target.addLegalDialect(); + target.addLegalDialect(); // required NOPs for applying a full conversion target.addLegalOp(); diff --git a/flang/lib/Optimizer/Support/CMakeLists.txt b/flang/lib/Optimizer/Support/CMakeLists.txt index 2d0e4dd4c9f43..348ef24774021 100644 --- a/flang/lib/Optimizer/Support/CMakeLists.txt +++ b/flang/lib/Optimizer/Support/CMakeLists.txt @@ -13,6 +13,7 @@ add_flang_library(FIRSupport LINK_LIBS ${dialect_libs} MLIRBuiltinToLLVMIRTranslation + MLIROpenACCToLLVMIRTranslation MLIROpenMPToLLVMIRTranslation MLIRLLVMToLLVMIRTranslation MLIRTargetLLVMIRExport diff --git a/flang/lib/Optimizer/Support/InitFIR.cpp b/flang/lib/Optimizer/Support/InitFIR.cpp index 09852b1add372..0753c4511d9c6 100644 --- a/flang/lib/Optimizer/Support/InitFIR.cpp +++ b/flang/lib/Optimizer/Support/InitFIR.cpp @@ -9,10 +9,13 @@ #include "flang/Optimizer/Support/InitFIR.h" #include "mlir/Target/LLVMIR/Dialect/Builtin/BuiltinToLLVMIRTranslation.h" #include "mlir/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.h" +#include "mlir/Target/LLVMIR/Dialect/OpenACC/OpenACCToLLVMIRTranslation.h" #include "mlir/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.h" void fir::support::registerLLVMTranslation(mlir::MLIRContext &context) { mlir::DialectRegistry registry; + // Register OpenACC dialect interface here as well. + registerOpenACCDialectTranslation(registry); // Register OpenMP dialect interface here as well. registerOpenMPDialectTranslation(registry); // Register LLVM-IR dialect interface. diff --git a/flang/lib/Optimizer/Transforms/OpenACC/OpenACCDataOperandConversion.cpp b/flang/lib/Optimizer/Transforms/OpenACC/OpenACCDataOperandConversion.cpp index f6d6524da548f..1f3a71ea1d7ec 100644 --- a/flang/lib/Optimizer/Transforms/OpenACC/OpenACCDataOperandConversion.cpp +++ b/flang/lib/Optimizer/Transforms/OpenACC/OpenACCDataOperandConversion.cpp @@ -111,7 +111,7 @@ void OpenACCDataOperandConversion::runOnOperation() { ConversionTarget target(*context); target.addLegalDialect(); target.addLegalDialect(); - target.addLegalOp(); + target.addLegalOp(); auto allDataOperandsAreConverted = [](ValueRange operands) { for (Value operand : operands) { diff --git a/flang/test/Transforms/OpenACC/convert-data-operands-to-llvmir.fir b/flang/test/Transforms/OpenACC/convert-data-operands-to-llvmir.fir index 12c4c7737a1a0..df78e938da9e6 100644 --- a/flang/test/Transforms/OpenACC/convert-data-operands-to-llvmir.fir +++ b/flang/test/Transforms/OpenACC/convert-data-operands-to-llvmir.fir @@ -1,4 +1,10 @@ // RUN: fir-opt -fir-openacc-data-operand-conversion='use-opaque-pointers=1' -split-input-file %s | FileCheck %s +// RUN: fir-opt -fir-openacc-data-operand-conversion='use-opaque-pointers=1' -split-input-file %s | fir-opt --fir-to-llvm-ir | FileCheck %s --check-prefix=LLVMIR + +fir.global internal @_QFEa : !fir.array<10xf32> { + %0 = fir.undefined !fir.array<10xf32> + fir.has_value %0 : !fir.array<10xf32> +} func.func @_QQsub1() attributes {fir.bindc_name = "arr"} { %0 = fir.address_of(@_QFEa) : !fir.ref> @@ -13,8 +19,17 @@ func.func @_QQsub1() attributes {fir.bindc_name = "arr"} { // CHECK: %[[CAST:.*]] = builtin.unrealized_conversion_cast %[[ADDR]] : !fir.ref> to !llvm.ptr> // CHECK: acc.data copy(%[[CAST]] : !llvm.ptr>) +// LLVMIR-LABEL: llvm.func @_QQsub1() attributes {fir.bindc_name = "arr"} { +// LLVMIR: %[[ADDR:.*]] = llvm.mlir.addressof @_QFEa : !llvm.ptr> +// LLVMIR: acc.data copy(%[[ADDR]] : !llvm.ptr>) { + // ----- +fir.global internal @_QFEa : !fir.array<10xf32> { + %0 = fir.undefined !fir.array<10xf32> + fir.has_value %0 : !fir.array<10xf32> +} + func.func @_QQsub_enter_exit() attributes {fir.bindc_name = "a"} { %0 = fir.address_of(@_QFEa) : !fir.ref> acc.enter_data copyin(%0 : !fir.ref>) @@ -29,8 +44,18 @@ func.func @_QQsub_enter_exit() attributes {fir.bindc_name = "a"} { // CHECK: %[[CAST1:.*]] = builtin.unrealized_conversion_cast %[[ADDR]] : !fir.ref> to !llvm.ptr> // CHECK: acc.exit_data copyout(%[[CAST1]] : !llvm.ptr>) +// LLVMIR-LABEL: llvm.func @_QQsub_enter_exit() attributes {fir.bindc_name = "a"} { +// LLVMIR: %[[ADDR:.*]] = llvm.mlir.addressof @_QFEa : !llvm.ptr> +// LLVMIR: acc.enter_data copyin(%[[ADDR]] : !llvm.ptr>) +// LLVMIR: acc.exit_data copyout(%[[ADDR]] : !llvm.ptr>) + // ----- +fir.global internal @_QFEa : !fir.array<10xf32> { + %0 = fir.undefined !fir.array<10xf32> + fir.has_value %0 : !fir.array<10xf32> +} + func.func @_QQsub_update() attributes {fir.bindc_name = "a"} { %0 = fir.address_of(@_QFEa) : !fir.ref> acc.update device(%0 : !fir.ref>) @@ -42,8 +67,17 @@ func.func @_QQsub_update() attributes {fir.bindc_name = "a"} { // CHECK: %[[CAST:.*]] = builtin.unrealized_conversion_cast %[[ADDR]] : !fir.ref> to !llvm.ptr> // CHECK: acc.update device(%[[CAST]] : !llvm.ptr>) +// LLVMIR-LABEL: llvm.func @_QQsub_update() attributes {fir.bindc_name = "a"} { +// LLVMIR: %[[ADDR:.*]] = llvm.mlir.addressof @_QFEa : !llvm.ptr> +// LLVMIR: acc.update device(%[[ADDR]] : !llvm.ptr>) + // ----- +fir.global internal @_QFEa : !fir.array<10xf32> { + %0 = fir.undefined !fir.array<10xf32> + fir.has_value %0 : !fir.array<10xf32> +} + func.func @_QQsub_parallel() attributes {fir.bindc_name = "test"} { %0 = fir.address_of(@_QFEa) : !fir.ref> %1 = fir.alloca i32 {bindc_name = "i", uniq_name = "_QFEi"} @@ -82,3 +116,7 @@ func.func @_QQsub_parallel() attributes {fir.bindc_name = "test"} { // CHECK: %[[ADDR:.*]] = fir.address_of(@_QFEa) : !fir.ref> // CHECK: %[[CAST:.*]] = builtin.unrealized_conversion_cast %[[ADDR]] : !fir.ref> to !llvm.ptr> // CHECK: acc.parallel copyin(%[[CAST]]: !llvm.ptr>) { + +// LLVMIR-LABEL: llvm.func @_QQsub_parallel() attributes {fir.bindc_name = "test"} { +// LLVMIR: %[[ADDR:.*]] = llvm.mlir.addressof @_QFEa : !llvm.ptr> +// LLVMIR: acc.parallel copyin(%[[ADDR]]: !llvm.ptr>) {