diff --git a/lld/test/wasm/Inputs/.gitattributes b/lld/test/wasm/Inputs/.gitattributes new file mode 100644 index 0000000000000..6622904075b27 --- /dev/null +++ b/lld/test/wasm/Inputs/.gitattributes @@ -0,0 +1,3 @@ +# ensures that we test parsing of stub libraries that contain +# windows line endings +libstub.so text eol=crlf diff --git a/lld/wasm/Driver.cpp b/lld/wasm/Driver.cpp index 7ce221e1f6634..3867b9cb3c37d 100644 --- a/lld/wasm/Driver.cpp +++ b/lld/wasm/Driver.cpp @@ -280,7 +280,7 @@ void LinkerDriver::addFile(StringRef path) { files.push_back(createObjectFile(mbref)); break; case file_magic::unknown: - if (mbref.getBuffer().starts_with("#STUB\n")) { + if (mbref.getBuffer().starts_with("#STUB")) { files.push_back(make(mbref)); break; } diff --git a/lld/wasm/InputFiles.cpp b/lld/wasm/InputFiles.cpp index 2d9768c768f29..fef5604572178 100644 --- a/lld/wasm/InputFiles.cpp +++ b/lld/wasm/InputFiles.cpp @@ -691,12 +691,16 @@ StringRef strip(StringRef s) { } void StubFile::parse() { - bool first = false; + bool first = true; + + SmallVector lines; + mb.getBuffer().split(lines, '\n'); + for (StringRef line : lines) { + line = line.trim(); - for (StringRef line : args::getLines(mb)) { // File must begin with #STUB if (first) { - assert(line == "#STUB\n"); + assert(line == "#STUB"); first = false; } @@ -713,10 +717,10 @@ void StubFile::parse() { symbolDependencies[sym] = {}; while (rest.size()) { - StringRef first; - std::tie(first, rest) = rest.split(','); - first = strip(first); - symbolDependencies[sym].push_back(first); + StringRef dep; + std::tie(dep, rest) = rest.split(','); + dep = strip(dep); + symbolDependencies[sym].push_back(dep); } } }