From e028de43cd5fcad19736cd9b3352ef8530419ba9 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Thu, 4 Apr 2019 20:08:04 +0000 Subject: [PATCH] check-clang-tools: Actually build and run XPC test The CMake variable controlling if XPC code is built is called CLANGD_BUILD_XPC but three places unintentionally checked the non-existent variable CLANGD_BUILD_XPC_SUPPORT instead, which (due to being nonexistent, and due to cmake) always silently evaluated to false. Luckily the test still seems to pass, despite never running after being added almost 3 months ago in r351280. Differential Revision: https://reviews.llvm.org/D60120 llvm-svn: 357719 --- clang-tools-extra/test/CMakeLists.txt | 4 ++-- clang-tools-extra/test/lit.site.cfg.py.in | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/clang-tools-extra/test/CMakeLists.txt b/clang-tools-extra/test/CMakeLists.txt index dc6d28efc1c85..f296fc74c347d 100644 --- a/clang-tools-extra/test/CMakeLists.txt +++ b/clang-tools-extra/test/CMakeLists.txt @@ -17,7 +17,7 @@ string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} CLANG_TOOLS_DIR ${LLVM_RUN llvm_canonicalize_cmake_booleans( CLANG_ENABLE_STATIC_ANALYZER - CLANGD_BUILD_XPC_SUPPORT) + CLANGD_BUILD_XPC) configure_lit_site_cfg( ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in @@ -70,7 +70,7 @@ set(CLANG_TOOLS_TEST_DEPS clang ) -if(CLANGD_BUILD_XPC_SUPPORT) +if(CLANGD_BUILD_XPC) list(APPEND CLANG_TOOLS_TEST_DEPS clangd-xpc-test-client) endif() diff --git a/clang-tools-extra/test/lit.site.cfg.py.in b/clang-tools-extra/test/lit.site.cfg.py.in index bfa283dba9d62..7664b7e5cd446 100644 --- a/clang-tools-extra/test/lit.site.cfg.py.in +++ b/clang-tools-extra/test/lit.site.cfg.py.in @@ -11,7 +11,7 @@ config.clang_libs_dir = "@SHLIBDIR@" config.python_executable = "@PYTHON_EXECUTABLE@" config.target_triple = "@TARGET_TRIPLE@" config.clang_staticanalyzer = @CLANG_ENABLE_STATIC_ANALYZER@ -config.clangd_xpc_support = @CLANGD_BUILD_XPC_SUPPORT@ +config.clangd_xpc_support = @CLANGD_BUILD_XPC@ # Support substitution of the tools and libs dirs with user parameters. This is # used when we can't determine the tool dir at configuration time.