diff --git a/llvm/lib/CodeGen/TailDuplicator.cpp b/llvm/lib/CodeGen/TailDuplicator.cpp index b82eaa5c5f3f38..26f6fc6b4be4c3 100644 --- a/llvm/lib/CodeGen/TailDuplicator.cpp +++ b/llvm/lib/CodeGen/TailDuplicator.cpp @@ -100,12 +100,11 @@ void TailDuplicator::initMF(MachineFunction &MFin, bool PreRegAlloc, } static void VerifyPHIs(MachineFunction &MF, bool CheckExtra) { - for (MachineFunction::iterator I = ++MF.begin(), E = MF.end(); I != E; ++I) { - MachineBasicBlock *MBB = &*I; - SmallSetVector Preds(MBB->pred_begin(), - MBB->pred_end()); - MachineBasicBlock::iterator MI = MBB->begin(); - while (MI != MBB->end()) { + for (MachineBasicBlock &MBB : llvm::drop_begin(MF)) { + SmallSetVector Preds(MBB.pred_begin(), + MBB.pred_end()); + MachineBasicBlock::iterator MI = MBB.begin(); + while (MI != MBB.end()) { if (!MI->isPHI()) break; for (MachineBasicBlock *PredBB : Preds) { @@ -118,7 +117,7 @@ static void VerifyPHIs(MachineFunction &MF, bool CheckExtra) { } } if (!Found) { - dbgs() << "Malformed PHI in " << printMBBReference(*MBB) << ": " + dbgs() << "Malformed PHI in " << printMBBReference(MBB) << ": " << *MI; dbgs() << " missing input from predecessor " << printMBBReference(*PredBB) << '\n'; @@ -129,14 +128,14 @@ static void VerifyPHIs(MachineFunction &MF, bool CheckExtra) { for (unsigned i = 1, e = MI->getNumOperands(); i != e; i += 2) { MachineBasicBlock *PHIBB = MI->getOperand(i + 1).getMBB(); if (CheckExtra && !Preds.count(PHIBB)) { - dbgs() << "Warning: malformed PHI in " << printMBBReference(*MBB) + dbgs() << "Warning: malformed PHI in " << printMBBReference(MBB) << ": " << *MI; dbgs() << " extra input from predecessor " << printMBBReference(*PHIBB) << '\n'; llvm_unreachable(nullptr); } if (PHIBB->getNumber() < 0) { - dbgs() << "Malformed PHI in " << printMBBReference(*MBB) << ": " + dbgs() << "Malformed PHI in " << printMBBReference(MBB) << ": " << *MI; dbgs() << " non-existing " << printMBBReference(*PHIBB) << '\n'; llvm_unreachable(nullptr); diff --git a/llvm/lib/Transforms/Scalar/MergeICmps.cpp b/llvm/lib/Transforms/Scalar/MergeICmps.cpp index f7083f8404f8a7..8c2cd8e924d01a 100644 --- a/llvm/lib/Transforms/Scalar/MergeICmps.cpp +++ b/llvm/lib/Transforms/Scalar/MergeICmps.cpp @@ -856,9 +856,9 @@ static bool runImpl(Function &F, const TargetLibraryInfo &TLI, bool MadeChange = false; - for (auto BBIt = ++F.begin(); BBIt != F.end(); ++BBIt) { + for (BasicBlock &BB : llvm::drop_begin(F)) { // A Phi operation is always first in a basic block. - if (auto *const Phi = dyn_cast(&*BBIt->begin())) + if (auto *const Phi = dyn_cast(&*BB.begin())) MadeChange |= processPhi(*Phi, TLI, AA, DTU); }