diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst index a52af53bbd28bc..5fae7ce3077a75 100644 --- a/clang/docs/ReleaseNotes.rst +++ b/clang/docs/ReleaseNotes.rst @@ -197,6 +197,8 @@ Bug Fixes in This Version be reached despite being reachable. This fixes `#61177 `_ in anticipation of `CWG2699 _` being accepted by WG21. +- Fix crash when parsing fold expression containing a delayed typo correction. + (`#61326 `_) Bug Fixes to Compiler Builtins ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ diff --git a/clang/lib/Sema/SemaTemplateVariadic.cpp b/clang/lib/Sema/SemaTemplateVariadic.cpp index 86268b504cbb3d..dfcc78dafdc4c3 100644 --- a/clang/lib/Sema/SemaTemplateVariadic.cpp +++ b/clang/lib/Sema/SemaTemplateVariadic.cpp @@ -1220,10 +1220,11 @@ ExprResult Sema::ActOnCXXFoldExpr(Scope *S, SourceLocation LParenLoc, Expr *LHS, if (!LHS || !RHS) { Expr *Pack = LHS ? LHS : RHS; assert(Pack && "fold expression with neither LHS nor RHS"); - DiscardOperands(); - if (!Pack->containsUnexpandedParameterPack()) + if (!Pack->containsUnexpandedParameterPack()) { + DiscardOperands(); return Diag(EllipsisLoc, diag::err_pack_expansion_without_parameter_packs) << Pack->getSourceRange(); + } } BinaryOperatorKind Opc = ConvertTokenKindToBinaryOpcode(Operator); diff --git a/clang/test/SemaCXX/fold_expr_typo.cpp b/clang/test/SemaCXX/fold_expr_typo.cpp new file mode 100644 index 00000000000000..0ef9c15b594766 --- /dev/null +++ b/clang/test/SemaCXX/fold_expr_typo.cpp @@ -0,0 +1,14 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++17 %s + +template +void foo(T &&...Params) { + foo(Unknown); // expected-error {{expression contains unexpanded parameter pack 'T'}}\ + expected-error {{use of undeclared identifier 'Unknown'}} + ((foo(Unknown)), ...); // expected-error {{use of undeclared identifier 'Unknown'}} +} + +template struct A { + template void foo(T &&...Params) { + foo((... + static_cast(1))); // expected-error {{expression contains unexpanded parameter pack 'T'}} + } +};