diff --git a/llvm/include/llvm/Analysis/IRSimilarityIdentifier.h b/llvm/include/llvm/Analysis/IRSimilarityIdentifier.h index c7759e0bbf0f84..966bf02d128ec7 100644 --- a/llvm/include/llvm/Analysis/IRSimilarityIdentifier.h +++ b/llvm/include/llvm/Analysis/IRSimilarityIdentifier.h @@ -214,16 +214,6 @@ struct IRInstructionData /// function name as a differentiating parameter. void setCalleeName(bool MatchByName = true); - /// For an IRInstructionData containing a PHINode, finds the - /// relative distances from the incoming basic block to the current block by - /// taking the difference of the number assigned to the current basic block - /// and the incoming basic block of the branch. - /// - /// \param BasicBlockToInteger - The mapping of basic blocks to their location - /// in the module. - void - setPHIPredecessors(DenseMap &BasicBlockToInteger); - /// Hashes \p Value based on its opcode, types, and operand types. /// Two IRInstructionData instances produce the same hash when they perform /// the same operation. @@ -507,11 +497,8 @@ struct IRInstructionMapper { return Legal; return Illegal; } - InstrType visitPHINode(PHINode &PN) { - if (EnableBranches) - return Legal; - return Illegal; - } + // TODO: Determine a scheme to resolve when the labels are similar enough. + InstrType visitPHINode(PHINode &PN) { return Illegal; } // TODO: Handle allocas. InstrType visitAllocaInst(AllocaInst &AI) { return Illegal; } // We exclude variable argument instructions since variable arguments diff --git a/llvm/include/llvm/Transforms/IPO/IROutliner.h b/llvm/include/llvm/Transforms/IPO/IROutliner.h index ed74c8ed0e96cc..9799737a529e39 100644 --- a/llvm/include/llvm/Transforms/IPO/IROutliner.h +++ b/llvm/include/llvm/Transforms/IPO/IROutliner.h @@ -342,7 +342,8 @@ class IROutliner { bool visitBranchInst(BranchInst &BI) { return EnableBranches; } - bool visitPHINode(PHINode &PN) { return EnableBranches; } + // TODO: Determine a scheme to resolve when the labels are similar enough. + bool visitPHINode(PHINode &PN) { return false; } // TODO: Handle allocas. bool visitAllocaInst(AllocaInst &AI) { return false; } // VAArg instructions are not allowed since this could cause difficulty when diff --git a/llvm/lib/Analysis/IRSimilarityIdentifier.cpp b/llvm/lib/Analysis/IRSimilarityIdentifier.cpp index 0ce3d218eb33ad..8c3c0400d60153 100644 --- a/llvm/lib/Analysis/IRSimilarityIdentifier.cpp +++ b/llvm/lib/Analysis/IRSimilarityIdentifier.cpp @@ -70,12 +70,6 @@ void IRInstructionData::initializeInstruction() { OperVals.push_back(OI.get()); } - - // We capture the incoming BasicBlocks as values as well as the incoming - // Values in order to check for structural similarity. - if (PHINode *PN = dyn_cast(Inst)) - for (BasicBlock *BB : PN->blocks()) - OperVals.push_back(BB); } IRInstructionData::IRInstructionData(IRInstructionDataList &IDList) @@ -114,34 +108,6 @@ void IRInstructionData::setCalleeName(bool MatchByName) { CalleeName = CI->getCalledFunction()->getName().str(); } -void IRInstructionData::setPHIPredecessors( - DenseMap &BasicBlockToInteger) { - assert(isa(Inst) && "Instruction must be phi node"); - - PHINode *PN = cast(Inst); - DenseMap::iterator BBNumIt; - - BBNumIt = BasicBlockToInteger.find(PN->getParent()); - assert(BBNumIt != BasicBlockToInteger.end() && - "Could not find location for BasicBlock!"); - - int CurrentBlockNumber = static_cast(BBNumIt->second); - - // Convert the incoming blocks of the PHINode to an integer value, based on - // the relative distances between the current block and the incoming block. - for (unsigned Idx = 0; Idx < PN->getNumIncomingValues(); Idx++) { - BasicBlock *Incoming = PN->getIncomingBlock(Idx); - BBNumIt = BasicBlockToInteger.find(Incoming); - assert(BBNumIt != BasicBlockToInteger.end() && - "Could not find number for BasicBlock!"); - int OtherBlockNumber = static_cast(BBNumIt->second); - - int Relative = OtherBlockNumber - CurrentBlockNumber; - RelativeBlockLocations.push_back(Relative); - RelativeBlockLocations.push_back(Relative); - } -} - CmpInst::Predicate IRInstructionData::predicateForConsistency(CmpInst *CI) { switch (CI->getPredicate()) { case CmpInst::FCMP_OGT: @@ -304,9 +270,6 @@ unsigned IRInstructionMapper::mapToLegalUnsigned( if (isa(*It)) ID->setCalleeName(EnableMatchCallsByName); - if (isa(*It)) - ID->setPHIPredecessors(BasicBlockToInteger); - // Add to the instruction list bool WasInserted; DenseMap::iterator diff --git a/llvm/lib/Transforms/IPO/IROutliner.cpp b/llvm/lib/Transforms/IPO/IROutliner.cpp index fd19b669c3c04d..9c79972443fe6b 100644 --- a/llvm/lib/Transforms/IPO/IROutliner.cpp +++ b/llvm/lib/Transforms/IPO/IROutliner.cpp @@ -185,44 +185,6 @@ Value *OutlinableRegion::findCorrespondingValueIn(const OutlinableRegion &Other, return FoundValueOpt.getValueOr(nullptr); } -/// Rewrite the BranchInsts in the incoming blocks to \p PHIBlock that are found -/// in \p Included to branch to BasicBlock \p Replace if they currently branch -/// to the BasicBlock \p Find. This is used to fix up the incoming basic blocks -/// when PHINodes are included in outlined regions. -/// -/// \param PHIBlock - The BasicBlock containing the PHINodes that need to be -/// checked. -/// \param Find - The successor block to be replaced. -/// \param Replace - The new succesor block to branch to. -/// \param Included - The set of blocks about to be outlined. -static void replaceTargetsFromPHINode(BasicBlock *PHIBlock, BasicBlock *Find, - BasicBlock *Replace, - DenseSet &Included) { - for (PHINode &PN : PHIBlock->phis()) { - for (unsigned Idx = 0, PNEnd = PN.getNumIncomingValues(); Idx != PNEnd; - ++Idx) { - // Check if the incoming block is included in the set of blocks being - // outlined. - BasicBlock *Incoming = PN.getIncomingBlock(Idx); - if (!Included.contains(Incoming)) - continue; - - BranchInst *BI = dyn_cast(Incoming->getTerminator()); - assert(BI && "Not a branch instruction?"); - // Look over the branching instructions into this block to see if we - // used to branch to Find in this outlined block. - for (unsigned Succ = 0, End = BI->getNumSuccessors(); Succ != End; - Succ++) { - // If we have found the block to replace, we do so here. - if (BI->getSuccessor(Succ) != Find) - continue; - BI->setSuccessor(Succ, Replace); - } - } - } -} - - void OutlinableRegion::splitCandidate() { assert(!CandidateSplit && "Candidate already split!"); @@ -253,39 +215,6 @@ void OutlinableRegion::splitCandidate() { StartBB = StartInst->getParent(); PrevBB = StartBB; - DenseSet BBSet; - Candidate->getBasicBlocks(BBSet); - - // We iterate over the instructions in the region, if we find a PHINode, we - // check if there are predecessors outside of the region, if there are, - // we ignore this region since we are unable to handle the severing of the - // phi node right now. - BasicBlock::iterator It = StartInst->getIterator(); - while (PHINode *PN = dyn_cast(&*It)) { - unsigned NumPredsOutsideRegion = 0; - for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) - if (!BBSet.contains(PN->getIncomingBlock(i))) - ++NumPredsOutsideRegion; - - if (NumPredsOutsideRegion > 1) - return; - - It++; - } - - // If the region starts with a PHINode, but is not the initial instruction of - // the BasicBlock, we ignore this region for now. - if (isa(StartInst) && StartInst != &*StartBB->begin()) - return; - - // If the region ends with a PHINode, but does not contain all of the phi node - // instructions of the region, we ignore it for now. - if (isa(BackInst)) { - EndBB = BackInst->getParent(); - if (BackInst != &*std::prev(EndBB->getFirstInsertionPt())) - return; - } - // The basic block gets split like so: // block: block: // inst1 inst1 @@ -312,20 +241,12 @@ void OutlinableRegion::splitCandidate() { FollowBB = EndBB->splitBasicBlock(EndInst, OriginalName + "_after_outline"); EndBB->replaceSuccessorsPhiUsesWith(EndBB, FollowBB); FollowBB->replaceSuccessorsPhiUsesWith(PrevBB, FollowBB); - } else { - EndBB = BackInst->getParent(); - EndsInBranch = true; - FollowBB = nullptr; + return; } - // Refind the basic block set. - BBSet.clear(); - Candidate->getBasicBlocks(BBSet); - // For the phi nodes in the new starting basic block of the region, we - // reassign the targets of the basic blocks branching instructions. - replaceTargetsFromPHINode(StartBB, PrevBB, StartBB, BBSet); - if (FollowBB) - replaceTargetsFromPHINode(FollowBB, EndBB, FollowBB, BBSet); + EndBB = BackInst->getParent(); + EndsInBranch = true; + FollowBB = nullptr; } void OutlinableRegion::reattachCandidate() { @@ -347,21 +268,15 @@ void OutlinableRegion::reattachCandidate() { // inst4 assert(StartBB != nullptr && "StartBB for Candidate is not defined!"); + // StartBB should only have one predecessor since we put an unconditional + // branch at the end of PrevBB when we split the BasicBlock. + PrevBB = StartBB->getSinglePredecessor(); + assert(PrevBB != nullptr && + "No Predecessor for the region start basic block!"); + assert(PrevBB->getTerminator() && "Terminator removed from PrevBB!"); PrevBB->getTerminator()->eraseFromParent(); - // If we reattaching after outlining, we iterate over the phi nodes to - // the initial block, and reassign the branch instructions of the incoming - // blocks to the block we are remerging into. - if (!ExtractedFunction) { - DenseSet BBSet; - Candidate->getBasicBlocks(BBSet); - - replaceTargetsFromPHINode(StartBB, StartBB, PrevBB, BBSet); - if (!EndsInBranch) - replaceTargetsFromPHINode(FollowBB, FollowBB, EndBB, BBSet); - } - moveBBContents(*StartBB, *PrevBB); BasicBlock *PlacementBB = PrevBB; @@ -1707,8 +1622,7 @@ replaceArgumentUses(OutlinableRegion &Region, // If this is storing a PHINode, we must make sure it is included in the // overall function. - if (!isa(ValueOperand) || - Region.Candidate->getGVN(ValueOperand).hasValue()) { + if (!isa(ValueOperand)) { if (FirstFunction) continue; Value *CorrVal = @@ -2247,7 +2161,7 @@ void IROutliner::pruneIncompatibleRegions( if (FirstCandidate.getLength() == 2) { if (isa(FirstCandidate.front()->Inst) && isa(FirstCandidate.back()->Inst)) - return; + return; } unsigned CurrentEndIdx = 0; diff --git a/llvm/test/Transforms/IROutliner/included-phi-nodes-begin.ll b/llvm/test/Transforms/IROutliner/included-phi-nodes-begin.ll deleted file mode 100644 index e519fb318ba871..00000000000000 --- a/llvm/test/Transforms/IROutliner/included-phi-nodes-begin.ll +++ /dev/null @@ -1,93 +0,0 @@ -; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --include-generated-funcs -; RUN: opt -S -verify -iroutliner -ir-outlining-no-cost < %s | FileCheck %s - -; Show that we are able to outline when all of the phi nodes in the starting -; block are included in the region and there is no more than one predecessor -; into those phi nodes from outside of the region. - -define void @function1(i32* %a, i32* %b) { -entry: - %0 = alloca i32, align 4 - %c = load i32, i32* %0, align 4 - %y = add i32 %c, %c - br label %test1 -dummy: - ret void -test1: - %1 = phi i32 [ %e, %test1 ], [ %y, %entry ] - %2 = phi i32 [ %e, %test1 ], [ %y, %entry ] - %e = load i32, i32* %0, align 4 - %3 = add i32 %c, %c - br i1 true, label %test, label %test1 -test: - %d = load i32, i32* %0, align 4 - br label %first -first: - ret void -} - -define void @function2(i32* %a, i32* %b) { -entry: - %0 = alloca i32, align 4 - %c = load i32, i32* %0, align 4 - %y = mul i32 %c, %c - br label %test1 -dummy: - ret void -test1: - %1 = phi i32 [ %e, %test1 ], [ %y, %entry ] - %2 = phi i32 [ %e, %test1 ], [ %y, %entry ] - %e = load i32, i32* %0, align 4 - %3 = add i32 %c, %c - br i1 true, label %test, label %test1 -test: - %d = load i32, i32* %0, align 4 - br label %first -first: - ret void -} -; CHECK-LABEL: @function1( -; CHECK-NEXT: entry: -; CHECK-NEXT: [[TMP0:%.*]] = alloca i32, align 4 -; CHECK-NEXT: [[C:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: [[Y:%.*]] = add i32 [[C]], [[C]] -; CHECK-NEXT: br label [[TEST1:%.*]] -; CHECK: dummy: -; CHECK-NEXT: ret void -; CHECK: test1: -; CHECK-NEXT: call void @outlined_ir_func_0(i32 [[Y]], i32* [[TMP0]], i32 [[C]]) -; CHECK-NEXT: br label [[FIRST:%.*]] -; CHECK: first: -; CHECK-NEXT: ret void -; -; -; CHECK-LABEL: @function2( -; CHECK-NEXT: entry: -; CHECK-NEXT: [[TMP0:%.*]] = alloca i32, align 4 -; CHECK-NEXT: [[C:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: [[Y:%.*]] = mul i32 [[C]], [[C]] -; CHECK-NEXT: br label [[TEST1:%.*]] -; CHECK: dummy: -; CHECK-NEXT: ret void -; CHECK: test1: -; CHECK-NEXT: call void @outlined_ir_func_0(i32 [[Y]], i32* [[TMP0]], i32 [[C]]) -; CHECK-NEXT: br label [[FIRST:%.*]] -; CHECK: first: -; CHECK-NEXT: ret void -; -; -; CHECK: define internal void @outlined_ir_func_0( -; CHECK-NEXT: newFuncRoot: -; CHECK-NEXT: br label [[TEST1_TO_OUTLINE:%.*]] -; CHECK: test1_to_outline: -; CHECK-NEXT: [[TMP3:%.*]] = phi i32 [ [[E:%.*]], [[TEST1_TO_OUTLINE]] ], [ [[TMP0:%.*]], [[NEWFUNCROOT:%.*]] ] -; CHECK-NEXT: [[TMP4:%.*]] = phi i32 [ [[E]], [[TEST1_TO_OUTLINE]] ], [ [[TMP0]], [[NEWFUNCROOT]] ] -; CHECK-NEXT: [[E]] = load i32, i32* [[TMP1:%.*]], align 4 -; CHECK-NEXT: [[TMP5:%.*]] = add i32 [[TMP2:%.*]], [[TMP2]] -; CHECK-NEXT: br i1 true, label [[TEST:%.*]], label [[TEST1_TO_OUTLINE]] -; CHECK: test: -; CHECK-NEXT: [[D:%.*]] = load i32, i32* [[TMP1]], align 4 -; CHECK-NEXT: br label [[FIRST_EXITSTUB:%.*]] -; CHECK: first.exitStub: -; CHECK-NEXT: ret void -; diff --git a/llvm/test/Transforms/IROutliner/included-phi-nodes-end.ll b/llvm/test/Transforms/IROutliner/included-phi-nodes-end.ll deleted file mode 100644 index 0f9750576139a6..00000000000000 --- a/llvm/test/Transforms/IROutliner/included-phi-nodes-end.ll +++ /dev/null @@ -1,94 +0,0 @@ -; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --include-generated-funcs -; RUN: opt -S -verify -iroutliner -ir-outlining-no-cost < %s | FileCheck %s - -; Show that we are able to propogate inputs to the region into the split PHINode -; outside of the region if necessary. - -define void @function1(i32* %a, i32* %b) { -entry: - %0 = alloca i32, align 4 - %c = load i32, i32* %0, align 4 - %z = add i32 %c, %c - br i1 true, label %test1, label %first -test1: - %e = load i32, i32* %0, align 4 - %1 = add i32 %c, %c - br i1 true, label %first, label %test -test: - %d = load i32, i32* %0, align 4 - br i1 true, label %first, label %next -first: - %2 = phi i32 [ %d, %test ], [ %e, %test1 ], [ %c, %entry ] - %3 = phi i32 [ %d, %test ], [ %e, %test1 ], [ %c, %entry ] - ret void -next: - ret void -} - -define void @function2(i32* %a, i32* %b) { -entry: - %0 = alloca i32, align 4 - %c = load i32, i32* %0, align 4 - %z = mul i32 %c, %c - br i1 true, label %test1, label %first -test1: - %e = load i32, i32* %0, align 4 - %1 = add i32 %c, %c - br i1 true, label %first, label %test -test: - %d = load i32, i32* %0, align 4 - br i1 true, label %first, label %next -first: - %2 = phi i32 [ %d, %test ], [ %e, %test1 ], [ %c, %entry ] - %3 = phi i32 [ %d, %test ], [ %e, %test1 ], [ %c, %entry ] - ret void -next: - ret void -} -; CHECK-LABEL: @function1( -; CHECK-NEXT: entry: -; CHECK-NEXT: [[TMP0:%.*]] = alloca i32, align 4 -; CHECK-NEXT: [[C:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: [[Z:%.*]] = add i32 [[C]], [[C]] -; CHECK-NEXT: [[TARGETBLOCK:%.*]] = call i1 @outlined_ir_func_0(i32* [[TMP0]], i32 [[C]]) -; CHECK-NEXT: br i1 [[TARGETBLOCK]], label [[NEXT:%.*]], label [[ENTRY_AFTER_OUTLINE:%.*]] -; CHECK: entry_after_outline: -; CHECK-NEXT: ret void -; CHECK: next: -; CHECK-NEXT: ret void -; -; -; CHECK-LABEL: @function2( -; CHECK-NEXT: entry: -; CHECK-NEXT: [[TMP0:%.*]] = alloca i32, align 4 -; CHECK-NEXT: [[C:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: [[Z:%.*]] = mul i32 [[C]], [[C]] -; CHECK-NEXT: [[TARGETBLOCK:%.*]] = call i1 @outlined_ir_func_0(i32* [[TMP0]], i32 [[C]]) -; CHECK-NEXT: br i1 [[TARGETBLOCK]], label [[NEXT:%.*]], label [[ENTRY_AFTER_OUTLINE:%.*]] -; CHECK: entry_after_outline: -; CHECK-NEXT: ret void -; CHECK: next: -; CHECK-NEXT: ret void -; -; -; CHECK: define internal i1 @outlined_ir_func_0( -; CHECK-NEXT: newFuncRoot: -; CHECK-NEXT: br label [[ENTRY_TO_OUTLINE:%.*]] -; CHECK: entry_to_outline: -; CHECK-NEXT: br i1 true, label [[TEST1:%.*]], label [[FIRST:%.*]] -; CHECK: test1: -; CHECK-NEXT: [[E:%.*]] = load i32, i32* [[TMP0:%.*]], align 4 -; CHECK-NEXT: [[TMP2:%.*]] = add i32 [[TMP1:%.*]], [[TMP1]] -; CHECK-NEXT: br i1 true, label [[FIRST]], label [[TEST:%.*]] -; CHECK: test: -; CHECK-NEXT: [[D:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: br i1 true, label [[FIRST]], label [[NEXT_EXITSTUB:%.*]] -; CHECK: first: -; CHECK-NEXT: [[TMP3:%.*]] = phi i32 [ [[D]], [[TEST]] ], [ [[E]], [[TEST1]] ], [ [[TMP1]], [[ENTRY_TO_OUTLINE]] ] -; CHECK-NEXT: [[TMP4:%.*]] = phi i32 [ [[D]], [[TEST]] ], [ [[E]], [[TEST1]] ], [ [[TMP1]], [[ENTRY_TO_OUTLINE]] ] -; CHECK-NEXT: br label [[ENTRY_AFTER_OUTLINE_EXITSTUB:%.*]] -; CHECK: next.exitStub: -; CHECK-NEXT: ret i1 true -; CHECK: entry_after_outline.exitStub: -; CHECK-NEXT: ret i1 false -; diff --git a/llvm/test/Transforms/IROutliner/must-capture-all-phi-nodes-begin.ll b/llvm/test/Transforms/IROutliner/must-capture-all-phi-nodes-begin.ll deleted file mode 100644 index debaef12687b74..00000000000000 --- a/llvm/test/Transforms/IROutliner/must-capture-all-phi-nodes-begin.ll +++ /dev/null @@ -1,108 +0,0 @@ -; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --include-generated-funcs -; RUN: opt -S -verify -iroutliner -ir-outlining-no-cost < %s | FileCheck %s - -; Show that we do not outline when all of the phi nodes in the beginning -; block are included not in the region. - -define void @function1(i32* %a, i32* %b) { -entry: - %0 = alloca i32, align 4 - %c = load i32, i32* %0, align 4 - %y = add i32 %c, %c - br label %test1 -dummy: - ret void -test1: - %1 = phi i32 [ %e, %test1 ], [ %y, %entry ] - %2 = phi i32 [ %e, %test1 ], [ %y, %entry ] - %e = load i32, i32* %0, align 4 - %3 = add i32 %c, %c - br i1 true, label %test, label %test1 -test: - %d = load i32, i32* %0, align 4 - br label %first -first: - ret void -} - -define void @function2(i32* %a, i32* %b) { -entry: - %0 = alloca i32, align 4 - %c = load i32, i32* %0, align 4 - %y = mul i32 %c, %c - br label %test1 -dummy: - ret void -test1: - %1 = phi i32 [ %e, %test1 ], [ %y, %entry ] - %2 = phi i32 [ %y, %entry ], [ %e, %test1 ] - %e = load i32, i32* %0, align 4 - %3 = add i32 %c, %c - br i1 true, label %test, label %test1 -test: - %d = load i32, i32* %0, align 4 - br label %first -first: - ret void -} -; CHECK-LABEL: @function1( -; CHECK-NEXT: entry: -; CHECK-NEXT: [[E_LOC:%.*]] = alloca i32, align 4 -; CHECK-NEXT: [[TMP0:%.*]] = alloca i32, align 4 -; CHECK-NEXT: [[C:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: [[Y:%.*]] = add i32 [[C]], [[C]] -; CHECK-NEXT: br label [[TEST1:%.*]] -; CHECK: dummy: -; CHECK-NEXT: ret void -; CHECK: test1: -; CHECK-NEXT: [[TMP1:%.*]] = phi i32 [ [[E_RELOAD:%.*]], [[TEST1]] ], [ [[Y]], [[ENTRY:%.*]] ] -; CHECK-NEXT: [[TMP2:%.*]] = phi i32 [ [[E_RELOAD]], [[TEST1]] ], [ [[Y]], [[ENTRY]] ] -; CHECK-NEXT: [[LT_CAST:%.*]] = bitcast i32* [[E_LOC]] to i8* -; CHECK-NEXT: call void @llvm.lifetime.start.p0i8(i64 -1, i8* [[LT_CAST]]) -; CHECK-NEXT: [[TARGETBLOCK:%.*]] = call i1 @outlined_ir_func_0(i32* [[TMP0]], i32 [[C]], i32* [[E_LOC]]) -; CHECK-NEXT: [[E_RELOAD]] = load i32, i32* [[E_LOC]], align 4 -; CHECK-NEXT: call void @llvm.lifetime.end.p0i8(i64 -1, i8* [[LT_CAST]]) -; CHECK-NEXT: br i1 [[TARGETBLOCK]], label [[TEST1]], label [[FIRST:%.*]] -; CHECK: first: -; CHECK-NEXT: ret void -; -; -; CHECK-LABEL: @function2( -; CHECK-NEXT: entry: -; CHECK-NEXT: [[E_LOC:%.*]] = alloca i32, align 4 -; CHECK-NEXT: [[TMP0:%.*]] = alloca i32, align 4 -; CHECK-NEXT: [[C:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: [[Y:%.*]] = mul i32 [[C]], [[C]] -; CHECK-NEXT: br label [[TEST1:%.*]] -; CHECK: dummy: -; CHECK-NEXT: ret void -; CHECK: test1: -; CHECK-NEXT: [[TMP1:%.*]] = phi i32 [ [[E_RELOAD:%.*]], [[TEST1]] ], [ [[Y]], [[ENTRY:%.*]] ] -; CHECK-NEXT: [[TMP2:%.*]] = phi i32 [ [[Y]], [[ENTRY]] ], [ [[E_RELOAD]], [[TEST1]] ] -; CHECK-NEXT: [[LT_CAST:%.*]] = bitcast i32* [[E_LOC]] to i8* -; CHECK-NEXT: call void @llvm.lifetime.start.p0i8(i64 -1, i8* [[LT_CAST]]) -; CHECK-NEXT: [[TARGETBLOCK:%.*]] = call i1 @outlined_ir_func_0(i32* [[TMP0]], i32 [[C]], i32* [[E_LOC]]) -; CHECK-NEXT: [[E_RELOAD]] = load i32, i32* [[E_LOC]], align 4 -; CHECK-NEXT: call void @llvm.lifetime.end.p0i8(i64 -1, i8* [[LT_CAST]]) -; CHECK-NEXT: br i1 [[TARGETBLOCK]], label [[TEST1]], label [[FIRST:%.*]] -; CHECK: first: -; CHECK-NEXT: ret void -; -; -; CHECK: define internal i1 @outlined_ir_func_0( -; CHECK-NEXT: newFuncRoot: -; CHECK-NEXT: br label [[TEST1_TO_OUTLINE:%.*]] -; CHECK: test1_to_outline: -; CHECK-NEXT: [[E:%.*]] = load i32, i32* [[TMP0:%.*]], align 4 -; CHECK-NEXT: [[TMP3:%.*]] = add i32 [[TMP1:%.*]], [[TMP1]] -; CHECK-NEXT: br i1 true, label [[TEST:%.*]], label [[TEST1_EXITSTUB:%.*]] -; CHECK: test: -; CHECK-NEXT: [[D:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: br label [[FIRST_EXITSTUB:%.*]] -; CHECK: test1.exitStub: -; CHECK-NEXT: store i32 [[E]], i32* [[TMP2:%.*]], align 4 -; CHECK-NEXT: ret i1 true -; CHECK: first.exitStub: -; CHECK-NEXT: store i32 [[E]], i32* [[TMP2]], align 4 -; CHECK-NEXT: ret i1 false -; diff --git a/llvm/test/Transforms/IROutliner/must-capture-all-phi-nodes-end.ll b/llvm/test/Transforms/IROutliner/must-capture-all-phi-nodes-end.ll deleted file mode 100644 index a5d0314f21359d..00000000000000 --- a/llvm/test/Transforms/IROutliner/must-capture-all-phi-nodes-end.ll +++ /dev/null @@ -1,88 +0,0 @@ -; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --include-generated-funcs -; RUN: opt -S -verify -iroutliner -ir-outlining-no-cost < %s | FileCheck %s - -; Show that we do not outline when all of the phi nodes in the end -; block are not included in the region. - -define void @function1(i32* %a, i32* %b) { -entry: - %0 = alloca i32, align 4 - %c = load i32, i32* %0, align 4 - %z = add i32 %c, %c - br i1 true, label %test1, label %first -test1: - %e = load i32, i32* %0, align 4 - %1 = add i32 %c, %c - br i1 true, label %first, label %test -test: - %d = load i32, i32* %0, align 4 - br i1 true, label %first, label %next -first: - %2 = phi i32 [ %d, %test ], [ %e, %test1 ], [ %c, %entry ] - %3 = phi i32 [ %d, %test ], [ %e, %test1 ], [ %c, %entry ] - ret void -next: - ret void -} - -define void @function2(i32* %a, i32* %b) { -entry: - %0 = alloca i32, align 4 - %c = load i32, i32* %0, align 4 - %z = mul i32 %c, %c - br i1 true, label %test1, label %first -test1: - %e = load i32, i32* %0, align 4 - %1 = add i32 %c, %c - br i1 true, label %first, label %test -test: - %d = load i32, i32* %0, align 4 - br i1 true, label %first, label %next -first: - %2 = phi i32 [ %d, %test ], [ %e, %test1 ], [ %c, %entry ] - %3 = phi i32 [ %d, %test ], [ %c, %entry ], [ %e, %test1 ] - ret void -next: - ret void -} -; CHECK-LABEL: @function1( -; CHECK-NEXT: entry: -; CHECK-NEXT: [[TMP0:%.*]] = alloca i32, align 4 -; CHECK-NEXT: [[C:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: [[Z:%.*]] = add i32 [[C]], [[C]] -; CHECK-NEXT: br i1 true, label [[TEST1:%.*]], label [[FIRST:%.*]] -; CHECK: test1: -; CHECK-NEXT: [[E:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: [[TMP1:%.*]] = add i32 [[C]], [[C]] -; CHECK-NEXT: br i1 true, label [[FIRST]], label [[TEST:%.*]] -; CHECK: test: -; CHECK-NEXT: [[D:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: br i1 true, label [[FIRST]], label [[NEXT:%.*]] -; CHECK: first: -; CHECK-NEXT: [[TMP2:%.*]] = phi i32 [ [[D]], [[TEST]] ], [ [[E]], [[TEST1]] ], [ [[C]], [[ENTRY:%.*]] ] -; CHECK-NEXT: [[TMP3:%.*]] = phi i32 [ [[D]], [[TEST]] ], [ [[E]], [[TEST1]] ], [ [[C]], [[ENTRY]] ] -; CHECK-NEXT: ret void -; CHECK: next: -; CHECK-NEXT: ret void -; -; -; CHECK-LABEL: @function2( -; CHECK-NEXT: entry: -; CHECK-NEXT: [[TMP0:%.*]] = alloca i32, align 4 -; CHECK-NEXT: [[C:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: [[Z:%.*]] = mul i32 [[C]], [[C]] -; CHECK-NEXT: br i1 true, label [[TEST1:%.*]], label [[FIRST:%.*]] -; CHECK: test1: -; CHECK-NEXT: [[E:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: [[TMP1:%.*]] = add i32 [[C]], [[C]] -; CHECK-NEXT: br i1 true, label [[FIRST]], label [[TEST:%.*]] -; CHECK: test: -; CHECK-NEXT: [[D:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: br i1 true, label [[FIRST]], label [[NEXT:%.*]] -; CHECK: first: -; CHECK-NEXT: [[TMP2:%.*]] = phi i32 [ [[D]], [[TEST]] ], [ [[E]], [[TEST1]] ], [ [[C]], [[ENTRY:%.*]] ] -; CHECK-NEXT: [[TMP3:%.*]] = phi i32 [ [[D]], [[TEST]] ], [ [[C]], [[ENTRY]] ], [ [[E]], [[TEST1]] ] -; CHECK-NEXT: ret void -; CHECK: next: -; CHECK-NEXT: ret void -; diff --git a/llvm/test/Transforms/IROutliner/outlining-branches-phi-nodes.ll b/llvm/test/Transforms/IROutliner/outlining-branches-phi-nodes.ll index 59b08422cec3a2..4e777e862543ec 100644 --- a/llvm/test/Transforms/IROutliner/outlining-branches-phi-nodes.ll +++ b/llvm/test/Transforms/IROutliner/outlining-branches-phi-nodes.ll @@ -38,8 +38,6 @@ block_5: store i32 %add2, i32* %output, align 4 store i32 %mul2, i32* %result, align 4 br label %block_6 -dummy: - ret void block_6: %diff = phi i32 [%aval, %block_4], [%a2val, %block_5] ret void @@ -78,8 +76,6 @@ block_5: store i32 %add2, i32* %output, align 4 store i32 %mul2, i32* %result, align 4 br label %block_6 -dummy: - ret void block_6: %diff = phi i32 [%aval, %block_4], [%a2val, %block_5] ret void @@ -106,8 +102,6 @@ block_6: ; CHECK-NEXT: [[DIFF_CE_RELOAD:%.*]] = load i32, i32* [[DIFF_CE_LOC]], align 4 ; CHECK-NEXT: call void @llvm.lifetime.end.p0i8(i64 -1, i8* [[LT_CAST]]) ; CHECK-NEXT: br label [[BLOCK_6:%.*]] -; CHECK: dummy: -; CHECK-NEXT: ret void ; CHECK: block_6: ; CHECK-NEXT: [[DIFF:%.*]] = phi i32 [ [[DIFF_CE_RELOAD]], [[BLOCK_2]] ] ; CHECK-NEXT: ret void @@ -134,8 +128,6 @@ block_6: ; CHECK-NEXT: [[DIFF_CE_RELOAD:%.*]] = load i32, i32* [[DIFF_CE_LOC]], align 4 ; CHECK-NEXT: call void @llvm.lifetime.end.p0i8(i64 -1, i8* [[LT_CAST]]) ; CHECK-NEXT: br label [[BLOCK_6:%.*]] -; CHECK: dummy: -; CHECK-NEXT: ret void ; CHECK: block_6: ; CHECK-NEXT: [[DIFF:%.*]] = phi i32 [ [[DIFF_CE_RELOAD]], [[BLOCK_2]] ] ; CHECK-NEXT: ret void diff --git a/llvm/test/Transforms/IROutliner/outlining-exits-to-phi-node.ll b/llvm/test/Transforms/IROutliner/outlining-exits-to-phi-node.ll index 397121f000cd9b..77cb4a5bc476fc 100644 --- a/llvm/test/Transforms/IROutliner/outlining-exits-to-phi-node.ll +++ b/llvm/test/Transforms/IROutliner/outlining-exits-to-phi-node.ll @@ -15,8 +15,6 @@ test1: test: %d = load i32, i32* %0, align 4 br label %first -dummy: - ret void first: %1 = phi i32 [ %c, %test ], [ %e, %test1 ] ret void @@ -33,8 +31,6 @@ test1: test: %d = load i32, i32* %0, align 4 br label %first -dummy: - ret void first: %1 = phi i32 [ %c, %test ], [ %e, %test1 ] ret void @@ -49,8 +45,6 @@ first: ; CHECK-NEXT: [[DOTCE_RELOAD:%.*]] = load i32, i32* [[DOTCE_LOC]], align 4 ; CHECK-NEXT: call void @llvm.lifetime.end.p0i8(i64 -1, i8* [[LT_CAST]]) ; CHECK-NEXT: br label [[FIRST:%.*]] -; CHECK: dummy: -; CHECK-NEXT: ret void ; CHECK: first: ; CHECK-NEXT: [[TMP1:%.*]] = phi i32 [ [[DOTCE_RELOAD]], [[ENTRY:%.*]] ] ; CHECK-NEXT: ret void @@ -66,8 +60,6 @@ first: ; CHECK-NEXT: [[DOTCE_RELOAD:%.*]] = load i32, i32* [[DOTCE_LOC]], align 4 ; CHECK-NEXT: call void @llvm.lifetime.end.p0i8(i64 -1, i8* [[LT_CAST]]) ; CHECK-NEXT: br label [[FIRST:%.*]] -; CHECK: dummy: -; CHECK-NEXT: ret void ; CHECK: first: ; CHECK-NEXT: [[TMP1:%.*]] = phi i32 [ [[DOTCE_RELOAD]], [[ENTRY:%.*]] ] ; CHECK-NEXT: ret void diff --git a/llvm/test/Transforms/IROutliner/phi-nodes-non-constant.ll b/llvm/test/Transforms/IROutliner/phi-nodes-non-constant.ll deleted file mode 100644 index d56ffa57305527..00000000000000 --- a/llvm/test/Transforms/IROutliner/phi-nodes-non-constant.ll +++ /dev/null @@ -1,74 +0,0 @@ -; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --include-generated-funcs -; RUN: opt -S -verify -iroutliner -ir-outlining-no-cost < %s | FileCheck %s - -; Show that we do extract phi nodes from the regions. - -define void @function1(i32* %a, i32* %b) { -entry: - %0 = alloca i32, align 4 - %c = load i32, i32* %0, align 4 - br label %test1 -test1: - %e = load i32, i32* %0, align 4 - br label %first -test: - %d = load i32, i32* %0, align 4 - br label %first -first: - %1 = phi i32 [ %c, %test ], [ %e, %test1 ] - store i32 2, i32* %a, align 4 - store i32 3, i32* %b, align 4 - ret void -} - -define void @function2(i32* %a, i32* %b) { -entry: - %0 = alloca i32, align 4 - %c = load i32, i32* %0, align 4 - br label %test1 -test1: - %e = load i32, i32* %0, align 4 - br label %first -test: - %d = load i32, i32* %0, align 4 - br label %first -first: - %1 = phi i32 [ %c, %test ], [ %e, %test1 ] - store i32 2, i32* %a, align 4 - store i32 3, i32* %b, align 4 - ret void -} -; CHECK-LABEL: @function1( -; CHECK-NEXT: entry: -; CHECK-NEXT: [[TMP0:%.*]] = alloca i32, align 4 -; CHECK-NEXT: call void @outlined_ir_func_0(i32* [[TMP0]], i32* [[A:%.*]], i32* [[B:%.*]]) -; CHECK-NEXT: ret void -; -; -; CHECK-LABEL: @function2( -; CHECK-NEXT: entry: -; CHECK-NEXT: [[TMP0:%.*]] = alloca i32, align 4 -; CHECK-NEXT: call void @outlined_ir_func_0(i32* [[TMP0]], i32* [[A:%.*]], i32* [[B:%.*]]) -; CHECK-NEXT: ret void -; -; -; CHECK: define internal void @outlined_ir_func_0( -; CHECK-NEXT: newFuncRoot: -; CHECK-NEXT: br label [[ENTRY_TO_OUTLINE:%.*]] -; CHECK: entry_to_outline: -; CHECK-NEXT: [[C:%.*]] = load i32, i32* [[TMP0:%.*]], align 4 -; CHECK-NEXT: br label [[TEST1:%.*]] -; CHECK: test1: -; CHECK-NEXT: [[E:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: br label [[FIRST:%.*]] -; CHECK: test: -; CHECK-NEXT: [[D:%.*]] = load i32, i32* [[TMP0]], align 4 -; CHECK-NEXT: br label [[FIRST]] -; CHECK: first: -; CHECK-NEXT: [[TMP3:%.*]] = phi i32 [ [[C]], [[TEST:%.*]] ], [ [[E]], [[TEST1]] ] -; CHECK-NEXT: store i32 2, i32* [[TMP1:%.*]], align 4 -; CHECK-NEXT: store i32 3, i32* [[TMP2:%.*]], align 4 -; CHECK-NEXT: br label [[ENTRY_AFTER_OUTLINE_EXITSTUB:%.*]] -; CHECK: entry_after_outline.exitStub: -; CHECK-NEXT: ret void -; diff --git a/llvm/test/Transforms/IROutliner/phi-nodes-simple.ll b/llvm/test/Transforms/IROutliner/phi-nodes-simple.ll deleted file mode 100644 index e5afb89a261381..00000000000000 --- a/llvm/test/Transforms/IROutliner/phi-nodes-simple.ll +++ /dev/null @@ -1,58 +0,0 @@ -; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --include-generated-funcs -; RUN: opt -S -verify -iroutliner -ir-outlining-no-cost < %s | FileCheck %s - -; Show that we are able to outline the simple phi node case of constants when -; the corresponding labels match. - -define void @function1(i32* %a, i32* %b) { -entry: - br label %test -test: - br label %first -first: - %0 = phi i32 [ 0, %test ] - store i32 2, i32* %a, align 4 - store i32 3, i32* %b, align 4 - ret void -} - -define void @function2(i32* %a, i32* %b) { -entry: - br label %test -test: - br label %first -first: - %0 = phi i32 [ 0, %test ] - store i32 2, i32* %a, align 4 - store i32 3, i32* %b, align 4 - ret void -} -; CHECK-LABEL: @function1( -; CHECK-NEXT: entry: -; CHECK-NEXT: br label [[TEST:%.*]] -; CHECK: test: -; CHECK-NEXT: call void @outlined_ir_func_0(i32* [[A:%.*]], i32* [[B:%.*]]) -; CHECK-NEXT: ret void -; -; -; CHECK-LABEL: @function2( -; CHECK-NEXT: entry: -; CHECK-NEXT: br label [[TEST:%.*]] -; CHECK: test: -; CHECK-NEXT: call void @outlined_ir_func_0(i32* [[A:%.*]], i32* [[B:%.*]]) -; CHECK-NEXT: ret void -; -; -; CHECK: define internal void @outlined_ir_func_0( -; CHECK-NEXT: newFuncRoot: -; CHECK-NEXT: br label [[TEST_TO_OUTLINE:%.*]] -; CHECK: test_to_outline: -; CHECK-NEXT: br label [[FIRST:%.*]] -; CHECK: first: -; CHECK-NEXT: [[TMP2:%.*]] = phi i32 [ 0, [[TEST_TO_OUTLINE]] ] -; CHECK-NEXT: store i32 2, i32* [[TMP0:%.*]], align 4 -; CHECK-NEXT: store i32 3, i32* [[TMP1:%.*]], align 4 -; CHECK-NEXT: br label [[TEST_AFTER_OUTLINE_EXITSTUB:%.*]] -; CHECK: test_after_outline.exitStub: -; CHECK-NEXT: ret void -; diff --git a/llvm/test/Transforms/IROutliner/region-inputs-in-phi-nodes.ll b/llvm/test/Transforms/IROutliner/region-inputs-in-phi-nodes.ll index 62d936d68ff2f3..258bbfe131e3e1 100644 --- a/llvm/test/Transforms/IROutliner/region-inputs-in-phi-nodes.ll +++ b/llvm/test/Transforms/IROutliner/region-inputs-in-phi-nodes.ll @@ -17,8 +17,6 @@ test1: test: %d = load i32, i32* %0, align 4 br i1 true, label %first, label %next -dummy: - ret void first: %2 = phi i32 [ %d, %test ], [ %e, %test1 ], [ %c, %entry ] ret void @@ -39,8 +37,6 @@ test1: test: %d = load i32, i32* %0, align 4 br i1 true, label %first, label %next -dummy: - ret void first: %2 = phi i32 [ %d, %test ], [ %e, %test1 ], [ %c, %entry ] ret void @@ -59,8 +55,6 @@ next: ; CHECK-NEXT: [[DOTCE_RELOAD:%.*]] = load i32, i32* [[DOTCE_LOC]], align 4 ; CHECK-NEXT: call void @llvm.lifetime.end.p0i8(i64 -1, i8* [[LT_CAST]]) ; CHECK-NEXT: br i1 [[TARGETBLOCK]], label [[FIRST:%.*]], label [[NEXT:%.*]] -; CHECK: dummy: -; CHECK-NEXT: ret void ; CHECK: first: ; CHECK-NEXT: [[TMP1:%.*]] = phi i32 [ [[DOTCE_RELOAD]], [[ENTRY:%.*]] ] ; CHECK-NEXT: ret void @@ -80,8 +74,6 @@ next: ; CHECK-NEXT: [[DOTCE_RELOAD:%.*]] = load i32, i32* [[DOTCE_LOC]], align 4 ; CHECK-NEXT: call void @llvm.lifetime.end.p0i8(i64 -1, i8* [[LT_CAST]]) ; CHECK-NEXT: br i1 [[TARGETBLOCK]], label [[FIRST:%.*]], label [[NEXT:%.*]] -; CHECK: dummy: -; CHECK-NEXT: ret void ; CHECK: first: ; CHECK-NEXT: [[TMP1:%.*]] = phi i32 [ [[DOTCE_RELOAD]], [[ENTRY:%.*]] ] ; CHECK-NEXT: ret void diff --git a/llvm/unittests/Analysis/IRSimilarityIdentifierTest.cpp b/llvm/unittests/Analysis/IRSimilarityIdentifierTest.cpp index 97d9be3d8985a0..a8781e8f78af72 100644 --- a/llvm/unittests/Analysis/IRSimilarityIdentifierTest.cpp +++ b/llvm/unittests/Analysis/IRSimilarityIdentifierTest.cpp @@ -757,41 +757,26 @@ TEST(IRInstructionMapper, BranchLegal) { ASSERT_TRUE(UnsignedVec[1] < UnsignedVec[2]); } -// Checks that a PHINode is mapped to be legal. -TEST(IRInstructionMapper, PhiLegal) { - StringRef ModuleString = R"( - define i32 @f(i32 %a, i32 %b) { - bb0: - %0 = phi i1 [ 0, %bb0 ], [ %0, %bb1 ] - %1 = add i32 %a, %b - ret i32 0 - bb1: - ret i32 1 - })"; - LLVMContext Context; - std::unique_ptr M = makeLLVMModule(Context, ModuleString); - - std::vector InstrList; - std::vector UnsignedVec; - - SpecificBumpPtrAllocator InstDataAllocator; - SpecificBumpPtrAllocator IDLAllocator; - IRInstructionMapper Mapper(&InstDataAllocator, &IDLAllocator); - Mapper.InstClassifier.EnableBranches = true; - Mapper.initializeForBBs(*M); - getVectors(*M, Mapper, InstrList, UnsignedVec); +// In most cases, the illegal instructions we are collecting don't require any +// sort of setup. In these cases, we can just only have illegal instructions, +// and the mapper will create 0 length vectors, and we can check that. - ASSERT_EQ(InstrList.size(), UnsignedVec.size()); - ASSERT_EQ(UnsignedVec.size(), static_cast(3)); -} +// In cases where we have legal instructions needed to set up the illegal +// instruction, to check illegal instructions are assigned unsigned integers +// from the maximum value decreasing to 0, it will be greater than a legal +// instruction that comes after. So to check that we have an illegal +// instruction, we place a legal instruction after an illegal instruction, and +// check that the illegal unsigned integer is greater than the unsigned integer +// of the legal instruction. -// Checks that a PHINode is mapped to be legal. +// Checks that a PHINode is mapped to be illegal since there is extra checking +// needed to ensure that a branch in one region is bin an isomorphic +// location in a different region. TEST(IRInstructionMapper, PhiIllegal) { StringRef ModuleString = R"( define i32 @f(i32 %a, i32 %b) { bb0: %0 = phi i1 [ 0, %bb0 ], [ %0, %bb1 ] - %1 = add i32 %a, %b ret i32 0 bb1: ret i32 1 @@ -805,25 +790,12 @@ TEST(IRInstructionMapper, PhiIllegal) { SpecificBumpPtrAllocator InstDataAllocator; SpecificBumpPtrAllocator IDLAllocator; IRInstructionMapper Mapper(&InstDataAllocator, &IDLAllocator); - Mapper.initializeForBBs(*M); getVectors(*M, Mapper, InstrList, UnsignedVec); ASSERT_EQ(InstrList.size(), UnsignedVec.size()); ASSERT_EQ(UnsignedVec.size(), static_cast(0)); } -// In most cases, the illegal instructions we are collecting don't require any -// sort of setup. In these cases, we can just only have illegal instructions, -// and the mapper will create 0 length vectors, and we can check that. - -// In cases where we have legal instructions needed to set up the illegal -// instruction, to check illegal instructions are assigned unsigned integers -// from the maximum value decreasing to 0, it will be greater than a legal -// instruction that comes after. So to check that we have an illegal -// instruction, we place a legal instruction after an illegal instruction, and -// check that the illegal unsigned integer is greater than the unsigned integer -// of the legal instruction. - // Checks that an alloca instruction is mapped to be illegal. TEST(IRInstructionMapper, AllocaIllegal) { StringRef ModuleString = R"( @@ -2374,108 +2346,6 @@ TEST(IRSimilarityCandidate, DifferentBranchStructureOutside) { ASSERT_TRUE(longSimCandCompare(InstrList, true, 3, 0, 6)); } -// Checks that the same structure is recognized between two candidates, -// when the phi predecessor are other blocks inside the same region, -// the relative distance between the blocks must be the same. -TEST(IRSimilarityCandidate, SamePHIStructureInternal) { - StringRef ModuleString = R"( - define i32 @f(i32 %a, i32 %b) { - bb0: - br label %bb2 - bb1: - br label %bb2 - bb2: - %0 = phi i32 [ %a, %bb0 ], [ %b, %bb1 ] - %1 = add i32 %b, %a - %2 = add i32 %a, %b - ret i32 0 - } - - define i32 @f2(i32 %a, i32 %b) { - bb0: - br label %bb2 - bb1: - br label %bb2 - bb2: - %0 = phi i32 [ %a, %bb0 ], [ %b, %bb1 ] - %1 = add i32 %b, %a - %2 = add i32 %a, %b - ret i32 0 - })"; - LLVMContext Context; - std::unique_ptr M = makeLLVMModule(Context, ModuleString); - - std::vector InstrList; - std::vector UnsignedVec; - - SpecificBumpPtrAllocator InstDataAllocator; - SpecificBumpPtrAllocator IDLAllocator; - IRInstructionMapper Mapper(&InstDataAllocator, &IDLAllocator); - Mapper.InstClassifier.EnableBranches = true; - Mapper.initializeForBBs(*M); - getVectors(*M, Mapper, InstrList, UnsignedVec); - - // Check to make sure that we have a long enough region. - ASSERT_EQ(InstrList.size(), static_cast(11)); - // Check that the instructions were added correctly to both vectors. - ASSERT_TRUE(InstrList.size() == UnsignedVec.size()); - - ASSERT_TRUE(longSimCandCompare(InstrList, true, 4, 0, 6)); -} - -// Checks that the different structure is recognized between two candidates, -// when the phi predecessor are other blocks inside the same region, -// the relative distance between the blocks must be the same. -TEST(IRSimilarityCandidate, DifferentPHIStructureInternal) { - StringRef ModuleString = R"( - define i32 @f(i32 %a, i32 %b) { - bb0: - br label %bb2 - bb1: - br label %bb2 - bb3: - br label %bb2 - bb2: - %0 = phi i32 [ %a, %bb0 ], [ %b, %bb1 ] - %1 = add i32 %b, %a - %2 = add i32 %a, %b - ret i32 0 - } - - define i32 @f2(i32 %a, i32 %b) { - bb0: - br label %bb2 - bb1: - br label %bb2 - bb3: - br label %bb2 - bb2: - %0 = phi i32 [ %a, %bb0 ], [ %b, %bb3 ] - %1 = add i32 %b, %a - %2 = add i32 %a, %b - ret i32 0 - })"; - LLVMContext Context; - std::unique_ptr M = makeLLVMModule(Context, ModuleString); - - std::vector InstrList; - std::vector UnsignedVec; - - SpecificBumpPtrAllocator InstDataAllocator; - SpecificBumpPtrAllocator IDLAllocator; - IRInstructionMapper Mapper(&InstDataAllocator, &IDLAllocator); - Mapper.InstClassifier.EnableBranches = true; - Mapper.initializeForBBs(*M); - getVectors(*M, Mapper, InstrList, UnsignedVec); - - // Check to make sure that we have a long enough region. - ASSERT_EQ(InstrList.size(), static_cast(13)); - // Check that the instructions were added correctly to both vectors. - ASSERT_TRUE(InstrList.size() == UnsignedVec.size()); - - ASSERT_FALSE(longSimCandCompare(InstrList, true, 5, 0, 7)); -} - // Checks that two sets of identical instructions are found to be the same. // Both sequences of adds have the same operand ordering, and the same // instructions, making them strcturally equivalent.