From e78223e79efc886ef6f0ea5413deab3737d6d63b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Tue, 9 Aug 2022 11:36:51 +0300 Subject: [PATCH] [libcxx] [test] Remove --env PATH from the static clangcl config The PATH is set in order to be able to find the tested DLL at runtime. When linking statically, it's not necessary to set the PATH. Setting PATH in the executor has the downside that it clears the existing path (it's not prepended/appended to it), which means that the executed tools can't find other tools - which sets the executor-has-no-bash flag. By removing the unnecessary setting of PATH, we have a properly working bash even when wrapped by the executor, which gets rid of the executor-has-no-bash flag in this test configuration, which makes 9 more testcases be executed. Differential Revision: https://reviews.llvm.org/D131481 --- libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in b/libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in index 2f408a09bf9e..460f7d6d50d4 100644 --- a/libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in +++ b/libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in @@ -11,7 +11,7 @@ config.substitutions.append(('%{link_flags}', '-nostdlib -L %{lib} -llibc++ -lmsvcrt -lmsvcprt -loldnames' )) config.substitutions.append(('%{exec}', - '%{executor} --execdir %T --env PATH=%{lib} -- ' + '%{executor} --execdir %T -- ' )) import os, site