diff --git a/llvm/unittests/ADT/OptionalTest.cpp b/llvm/unittests/ADT/OptionalTest.cpp index 7506453c4d9029..17a764041c8cf3 100644 --- a/llvm/unittests/ADT/OptionalTest.cpp +++ b/llvm/unittests/ADT/OptionalTest.cpp @@ -69,16 +69,12 @@ static_assert( !std::is_trivially_copyable>::value, "not trivially copyable"); -// Test fixture -class OptionalTest : public testing::Test { -}; - -TEST_F(OptionalTest, NonDefaultConstructibleTest) { +TEST(OptionalTest, NonDefaultConstructibleTest) { Optional O; EXPECT_FALSE(O); } -TEST_F(OptionalTest, ResetTest) { +TEST(OptionalTest, ResetTest) { NonDefaultConstructible::ResetCounts(); Optional O(NonDefaultConstructible(3)); EXPECT_EQ(1u, NonDefaultConstructible::CopyConstructions); @@ -91,7 +87,7 @@ TEST_F(OptionalTest, ResetTest) { EXPECT_EQ(1u, NonDefaultConstructible::Destructions); } -TEST_F(OptionalTest, InitializationLeakTest) { +TEST(OptionalTest, InitializationLeakTest) { NonDefaultConstructible::ResetCounts(); Optional(NonDefaultConstructible(3)); EXPECT_EQ(1u, NonDefaultConstructible::CopyConstructions); @@ -99,7 +95,7 @@ TEST_F(OptionalTest, InitializationLeakTest) { EXPECT_EQ(2u, NonDefaultConstructible::Destructions); } -TEST_F(OptionalTest, CopyConstructionTest) { +TEST(OptionalTest, CopyConstructionTest) { NonDefaultConstructible::ResetCounts(); { Optional A(NonDefaultConstructible(3)); @@ -118,7 +114,7 @@ TEST_F(OptionalTest, CopyConstructionTest) { EXPECT_EQ(2u, NonDefaultConstructible::Destructions); } -TEST_F(OptionalTest, ConstructingCopyAssignmentTest) { +TEST(OptionalTest, ConstructingCopyAssignmentTest) { NonDefaultConstructible::ResetCounts(); { Optional A(NonDefaultConstructible(3)); @@ -138,7 +134,7 @@ TEST_F(OptionalTest, ConstructingCopyAssignmentTest) { EXPECT_EQ(2u, NonDefaultConstructible::Destructions); } -TEST_F(OptionalTest, CopyingCopyAssignmentTest) { +TEST(OptionalTest, CopyingCopyAssignmentTest) { NonDefaultConstructible::ResetCounts(); { Optional A(NonDefaultConstructible(3)); @@ -158,7 +154,7 @@ TEST_F(OptionalTest, CopyingCopyAssignmentTest) { EXPECT_EQ(2u, NonDefaultConstructible::Destructions); } -TEST_F(OptionalTest, DeletingCopyAssignmentTest) { +TEST(OptionalTest, DeletingCopyAssignmentTest) { NonDefaultConstructible::ResetCounts(); { Optional A; @@ -178,7 +174,7 @@ TEST_F(OptionalTest, DeletingCopyAssignmentTest) { EXPECT_EQ(0u, NonDefaultConstructible::Destructions); } -TEST_F(OptionalTest, NullCopyConstructionTest) { +TEST(OptionalTest, NullCopyConstructionTest) { NonDefaultConstructible::ResetCounts(); { Optional A; @@ -198,7 +194,7 @@ TEST_F(OptionalTest, NullCopyConstructionTest) { EXPECT_EQ(0u, NonDefaultConstructible::Destructions); } -TEST_F(OptionalTest, GetValueOr) { +TEST(OptionalTest, GetValueOr) { Optional A; EXPECT_EQ(42, A.getValueOr(42)); @@ -230,7 +226,7 @@ unsigned MultiArgConstructor::Destructions = 0; static_assert(!std::is_trivially_copyable>::value, "not trivially copyable"); -TEST_F(OptionalTest, Emplace) { +TEST(OptionalTest, Emplace) { MultiArgConstructor::ResetCounts(); Optional A; @@ -280,7 +276,7 @@ unsigned MoveOnly::MoveAssignments = 0; static_assert(!std::is_trivially_copyable>::value, "not trivially copyable"); -TEST_F(OptionalTest, MoveOnlyNull) { +TEST(OptionalTest, MoveOnlyNull) { MoveOnly::ResetCounts(); Optional O; EXPECT_EQ(0u, MoveOnly::MoveConstructions); @@ -288,7 +284,7 @@ TEST_F(OptionalTest, MoveOnlyNull) { EXPECT_EQ(0u, MoveOnly::Destructions); } -TEST_F(OptionalTest, MoveOnlyConstruction) { +TEST(OptionalTest, MoveOnlyConstruction) { MoveOnly::ResetCounts(); Optional O(MoveOnly(3)); EXPECT_TRUE((bool)O); @@ -298,7 +294,7 @@ TEST_F(OptionalTest, MoveOnlyConstruction) { EXPECT_EQ(1u, MoveOnly::Destructions); } -TEST_F(OptionalTest, MoveOnlyMoveConstruction) { +TEST(OptionalTest, MoveOnlyMoveConstruction) { Optional A(MoveOnly(3)); MoveOnly::ResetCounts(); Optional B(std::move(A)); @@ -310,7 +306,7 @@ TEST_F(OptionalTest, MoveOnlyMoveConstruction) { EXPECT_EQ(0u, MoveOnly::Destructions); } -TEST_F(OptionalTest, MoveOnlyAssignment) { +TEST(OptionalTest, MoveOnlyAssignment) { MoveOnly::ResetCounts(); Optional O; O = MoveOnly(3); @@ -321,7 +317,7 @@ TEST_F(OptionalTest, MoveOnlyAssignment) { EXPECT_EQ(1u, MoveOnly::Destructions); } -TEST_F(OptionalTest, MoveOnlyInitializingAssignment) { +TEST(OptionalTest, MoveOnlyInitializingAssignment) { Optional A(MoveOnly(3)); Optional B; MoveOnly::ResetCounts(); @@ -334,7 +330,7 @@ TEST_F(OptionalTest, MoveOnlyInitializingAssignment) { EXPECT_EQ(0u, MoveOnly::Destructions); } -TEST_F(OptionalTest, MoveOnlyNullingAssignment) { +TEST(OptionalTest, MoveOnlyNullingAssignment) { Optional A; Optional B(MoveOnly(3)); MoveOnly::ResetCounts(); @@ -346,7 +342,7 @@ TEST_F(OptionalTest, MoveOnlyNullingAssignment) { EXPECT_EQ(1u, MoveOnly::Destructions); } -TEST_F(OptionalTest, MoveOnlyAssigningAssignment) { +TEST(OptionalTest, MoveOnlyAssigningAssignment) { Optional A(MoveOnly(3)); Optional B(MoveOnly(4)); MoveOnly::ResetCounts(); @@ -384,7 +380,7 @@ unsigned Immovable::Destructions = 0; static_assert(!std::is_trivially_copyable>::value, "not trivially copyable"); -TEST_F(OptionalTest, ImmovableEmplace) { +TEST(OptionalTest, ImmovableEmplace) { Optional A; Immovable::ResetCounts(); A.emplace(4); @@ -396,7 +392,7 @@ TEST_F(OptionalTest, ImmovableEmplace) { #if LLVM_HAS_RVALUE_REFERENCE_THIS -TEST_F(OptionalTest, MoveGetValueOr) { +TEST(OptionalTest, MoveGetValueOr) { Optional A; MoveOnly::ResetCounts(); @@ -478,7 +474,7 @@ bool operator==(const EqualityMock &Lhs, const EqualityMock &Rhs) { return IsEqual; } -TEST_F(OptionalTest, OperatorEqual) { +TEST(OptionalTest, OperatorEqual) { CheckRelation(NoneEq, NoneEq, true); CheckRelation(NoneEq, EqualityRhs, false); CheckRelation(EqualityLhs, NoneEq, false); @@ -489,7 +485,7 @@ TEST_F(OptionalTest, OperatorEqual) { CheckRelation(EqualityLhs, EqualityRhs, IsEqual); } -TEST_F(OptionalTest, OperatorNotEqual) { +TEST(OptionalTest, OperatorNotEqual) { CheckRelation(NoneEq, NoneEq, false); CheckRelation(NoneEq, EqualityRhs, true); CheckRelation(EqualityLhs, NoneEq, true); @@ -511,7 +507,7 @@ bool operator<(const InequalityMock &Lhs, const InequalityMock &Rhs) { return IsLess; } -TEST_F(OptionalTest, OperatorLess) { +TEST(OptionalTest, OperatorLess) { CheckRelation(NoneIneq, NoneIneq, false); CheckRelation(NoneIneq, InequalityRhs, true); CheckRelation(InequalityLhs, NoneIneq, false); @@ -522,7 +518,7 @@ TEST_F(OptionalTest, OperatorLess) { CheckRelation(InequalityLhs, InequalityRhs, IsLess); } -TEST_F(OptionalTest, OperatorGreater) { +TEST(OptionalTest, OperatorGreater) { CheckRelation(NoneIneq, NoneIneq, false); CheckRelation(NoneIneq, InequalityRhs, false); CheckRelation(InequalityLhs, NoneIneq, true); @@ -533,7 +529,7 @@ TEST_F(OptionalTest, OperatorGreater) { CheckRelation(InequalityRhs, InequalityLhs, IsLess); } -TEST_F(OptionalTest, OperatorLessEqual) { +TEST(OptionalTest, OperatorLessEqual) { CheckRelation(NoneIneq, NoneIneq, true); CheckRelation(NoneIneq, InequalityRhs, true); CheckRelation(InequalityLhs, NoneIneq, false); @@ -544,7 +540,7 @@ TEST_F(OptionalTest, OperatorLessEqual) { CheckRelation(InequalityRhs, InequalityLhs, !IsLess); } -TEST_F(OptionalTest, OperatorGreaterEqual) { +TEST(OptionalTest, OperatorGreaterEqual) { CheckRelation(NoneIneq, NoneIneq, true); CheckRelation(NoneIneq, InequalityRhs, false); CheckRelation(InequalityLhs, NoneIneq, true); @@ -570,7 +566,7 @@ struct ComparableAndStreamable { } }; -TEST_F(OptionalTest, StreamOperator) { +TEST(OptionalTest, StreamOperator) { auto to_string = [](Optional O) { SmallString<16> S; raw_svector_ostream OS(S); @@ -589,7 +585,7 @@ struct Comparable { static Optional get() { return Comparable(); } }; -TEST_F(OptionalTest, UseInUnitTests) { +TEST(OptionalTest, UseInUnitTests) { // Test that we invoke the streaming operators when pretty-printing values in // EXPECT macros. EXPECT_NONFATAL_FAILURE(EXPECT_EQ(llvm::None, ComparableAndStreamable::get()),