diff --git a/mlir/lib/Conversion/VectorToSCF/VectorToSCF.cpp b/mlir/lib/Conversion/VectorToSCF/VectorToSCF.cpp index 329b0086364f0..f7bdd53233ae2 100644 --- a/mlir/lib/Conversion/VectorToSCF/VectorToSCF.cpp +++ b/mlir/lib/Conversion/VectorToSCF/VectorToSCF.cpp @@ -651,7 +651,6 @@ namespace { struct ConvertVectorToSCFPass : public ConvertVectorToSCFBase { ConvertVectorToSCFPass() = default; - ConvertVectorToSCFPass(const ConvertVectorToSCFPass &pass) {} ConvertVectorToSCFPass(const VectorTransferToSCFOptions &options) { this->fullUnroll = options.unroll; } diff --git a/mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp b/mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp index f46d08f099ab4..402200f6b1cab 100644 --- a/mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp +++ b/mlir/lib/Dialect/Linalg/Transforms/Transforms.cpp @@ -101,7 +101,7 @@ mlir::linalg::LinalgTilingOptions::setTileSizes(ArrayRef ts) { })); }; return *this; -}; +} /// Linalg base tiling pattern. mlir::linalg::LinalgBaseTilingPattern::LinalgBaseTilingPattern( diff --git a/mlir/lib/Dialect/Shape/IR/Shape.cpp b/mlir/lib/Dialect/Shape/IR/Shape.cpp index 07913273b810c..4a876e16bcece 100644 --- a/mlir/lib/Dialect/Shape/IR/Shape.cpp +++ b/mlir/lib/Dialect/Shape/IR/Shape.cpp @@ -187,7 +187,7 @@ struct AssumingWithTrue : public OpRewritePattern { return success(); } }; -}; // namespace +} // namespace void AssumingOp::getCanonicalizationPatterns(OwningRewritePatternList &patterns, MLIRContext *context) { diff --git a/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp b/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp index d2dd1f5d9738f..c417995e67ec4 100644 --- a/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp +++ b/mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp @@ -846,9 +846,8 @@ struct Expression { }; explicit Expression(Kind k = Kind::Uninitialized) : kind(k) {} - virtual ~Expression() = 0; + virtual ~Expression() = default; - bool operator==(const Expression &e) const; operator bool() const { return kind != Kind::Uninitialized; } Kind kind; @@ -930,20 +929,6 @@ struct TensorExpr : public Expression { SetVector reductionDimensions; }; -Expression::~Expression() {} - -bool Expression::operator==(const Expression &e) const { - if (this->kind != e.kind) - return false; - if (e.kind == Expression::Kind::TensorUse) - return static_cast(*this) == - static_cast(e); - if (e.kind == Expression::Kind::TensorExpr) - return static_cast(*this) == - static_cast(e); - llvm_unreachable("Unexpected case"); -} - /// This is a specialized parser for a TCDef. /// This maintains the dims it finds in an eager fashion. class TCParser {