diff --git a/clang-tools-extra/clangd/ClangdLSPServer.cpp b/clang-tools-extra/clangd/ClangdLSPServer.cpp index c01a4286884b87..6c000d3290fda0 100644 --- a/clang-tools-extra/clangd/ClangdLSPServer.cpp +++ b/clang-tools-extra/clangd/ClangdLSPServer.cpp @@ -929,8 +929,7 @@ void ClangdLSPServer::onDocumentSymbol(const DocumentSymbolParams &Params, adjustSymbolKinds(*Items, SupportedSymbolKinds); if (SupportsHierarchicalDocumentSymbol) return Reply(std::move(*Items)); - else - return Reply(flattenSymbolHierarchy(*Items, FileURI)); + return Reply(flattenSymbolHierarchy(*Items, FileURI)); }); } diff --git a/clang-tools-extra/clangd/FuzzyMatch.cpp b/clang-tools-extra/clangd/FuzzyMatch.cpp index 57f9554a7d0cfd..2a908fd684da3e 100644 --- a/clang-tools-extra/clangd/FuzzyMatch.cpp +++ b/clang-tools-extra/clangd/FuzzyMatch.cpp @@ -320,8 +320,9 @@ llvm::SmallString<256> FuzzyMatcher::dumpLast(llvm::raw_ostream &OS) const { if (!WordContainsPattern) { OS << "Substring check failed.\n"; return Result; - } else if (isAwful(std::max(Scores[PatN][WordN][Match].Score, - Scores[PatN][WordN][Miss].Score))) { + } + if (isAwful(std::max(Scores[PatN][WordN][Match].Score, + Scores[PatN][WordN][Miss].Score))) { OS << "Substring check passed, but all matches are forbidden\n"; } if (!(PatTypeSet & 1 << Upper)) diff --git a/clang-tools-extra/clangd/Hover.cpp b/clang-tools-extra/clangd/Hover.cpp index 4285b3595059fb..faea812712ab22 100644 --- a/clang-tools-extra/clangd/Hover.cpp +++ b/clang-tools-extra/clangd/Hover.cpp @@ -74,7 +74,7 @@ std::string getLocalScope(const Decl *D) { // - Classes, categories, and protocols: "MyClass(Category)" if (const ObjCMethodDecl *MD = dyn_cast(DC)) return printObjCMethod(*MD); - else if (const ObjCContainerDecl *CD = dyn_cast(DC)) + if (const ObjCContainerDecl *CD = dyn_cast(DC)) return printObjCContainer(*CD); auto GetName = [](const TypeDecl *D) { diff --git a/clang-tools-extra/clangd/JSONTransport.cpp b/clang-tools-extra/clangd/JSONTransport.cpp index fd405c192591bb..ecf6c67d8ae4a9 100644 --- a/clang-tools-extra/clangd/JSONTransport.cpp +++ b/clang-tools-extra/clangd/JSONTransport.cpp @@ -194,8 +194,7 @@ bool JSONTransport::handleMessage(llvm::json::Value Message, if (ID) return Handler.onCall(*Method, std::move(Params), std::move(*ID)); - else - return Handler.onNotify(*Method, std::move(Params)); + return Handler.onNotify(*Method, std::move(Params)); } // Tries to read a line up to and including \n. @@ -254,14 +253,14 @@ bool JSONTransport::readStandardMessage(std::string &JSON) { } llvm::getAsUnsignedInteger(LineRef.trim(), 0, ContentLength); continue; - } else if (!LineRef.trim().empty()) { - // It's another header, ignore it. - continue; - } else { - // An empty line indicates the end of headers. - // Go ahead and read the JSON. - break; } + + // An empty line indicates the end of headers. + // Go ahead and read the JSON. + if (LineRef.trim().empty()) + break; + + // It's another header, ignore it. } // The fuzzer likes crashing us by sending "Content-Length: 9999999999999999" diff --git a/clang-tools-extra/clangd/PathMapping.cpp b/clang-tools-extra/clangd/PathMapping.cpp index cc980253938410..882e3fba50810b 100644 --- a/clang-tools-extra/clangd/PathMapping.cpp +++ b/clang-tools-extra/clangd/PathMapping.cpp @@ -151,7 +151,8 @@ llvm::Expected parsePath(llvm::StringRef Path) { namespace path = llvm::sys::path; if (path::is_absolute(Path, path::Style::posix)) { return std::string(Path); - } else if (path::is_absolute(Path, path::Style::windows)) { + } + if (path::is_absolute(Path, path::Style::windows)) { std::string Converted = path::convert_to_slash(Path, path::Style::windows); if (Converted.front() != '/') Converted = "/" + Converted; diff --git a/clang-tools-extra/clangd/Protocol.cpp b/clang-tools-extra/clangd/Protocol.cpp index 5fa2d21f5df718..0cfc7ff5bfb78d 100644 --- a/clang-tools-extra/clangd/Protocol.cpp +++ b/clang-tools-extra/clangd/Protocol.cpp @@ -695,7 +695,8 @@ bool fromJSON(const llvm::json::Value &Params, ExecuteCommandParams &R, if (ArgsArray->size() > 1) { P.field("arguments").report("Command should have 0 or 1 argument"); return false; - } else if (ArgsArray->size() == 1) { + } + if (ArgsArray->size() == 1) { R.argument = ArgsArray->front(); } return true; diff --git a/clang-tools-extra/clangd/Selection.cpp b/clang-tools-extra/clangd/Selection.cpp index 88ab1c5d058eec..e945f5d79b2c80 100644 --- a/clang-tools-extra/clangd/Selection.cpp +++ b/clang-tools-extra/clangd/Selection.cpp @@ -346,7 +346,7 @@ class SelectionTester { SM.getTopMacroCallerLoc(Batch.back().location()); return testTokenRange(SM.getFileOffset(ArgStart), SM.getFileOffset(ArgEnd)); - } else { + } else { // NOLINT(llvm-else-after-return) /* fall through and treat as part of the macro body */ } } @@ -357,8 +357,7 @@ class SelectionTester { if (Expansion.first == SelFile) // FIXME: also check ( and ) for function-like macros? return testToken(Expansion.second); - else - return NoTokens; + return NoTokens; } // Is the closed token range [Begin, End] selected? diff --git a/clang-tools-extra/clangd/TUScheduler.cpp b/clang-tools-extra/clangd/TUScheduler.cpp index afaf6ed780b0c3..e75867322cdc19 100644 --- a/clang-tools-extra/clangd/TUScheduler.cpp +++ b/clang-tools-extra/clangd/TUScheduler.cpp @@ -1282,8 +1282,8 @@ void ASTWorker::run() { if (Done) { if (Requests.empty()) return; - else // Even though Done is set, finish pending requests. - break; // However, skip delays to shutdown fast. + // Even though Done is set, finish pending requests. + break; // However, skip delays to shutdown fast. } // Tracing: we have a next request, attribute this sleep to it. diff --git a/clang-tools-extra/clangd/XRefs.cpp b/clang-tools-extra/clangd/XRefs.cpp index b29d29e5104ee9..452067a90a9cc0 100644 --- a/clang-tools-extra/clangd/XRefs.cpp +++ b/clang-tools-extra/clangd/XRefs.cpp @@ -826,10 +826,9 @@ std::vector locateSymbolAt(ParsedAST &AST, Position Pos, log("Found definition heuristically using nearby identifier {0}", NearbyIdent->text(SM)); return ASTResults; - } else { - vlog("No definition found using nearby identifier {0} at {1}", - Word->Text, Word->Location.printToString(SM)); } + vlog("No definition found using nearby identifier {0} at {1}", Word->Text, + Word->Location.printToString(SM)); } // No nearby word, or it didn't refer to anything either. Try the index. auto TextualResults = diff --git a/clang-tools-extra/clangd/index/Serialization.cpp b/clang-tools-extra/clangd/index/Serialization.cpp index 3f29cb80820619..f488220ff92f01 100644 --- a/clang-tools-extra/clangd/index/Serialization.cpp +++ b/clang-tools-extra/clangd/index/Serialization.cpp @@ -687,7 +687,8 @@ llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, const IndexFileOut &O) { llvm::Expected readIndexFile(llvm::StringRef Data) { if (Data.startswith("RIFF")) { return readRIFF(Data); - } else if (auto YAMLContents = readYAML(Data)) { + } + if (auto YAMLContents = readYAML(Data)) { return std::move(*YAMLContents); } else { return error("Not a RIFF file and failed to parse as YAML: {0}", diff --git a/clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp b/clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp index c87b8864d6e6d5..eee64d84fda635 100644 --- a/clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp +++ b/clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp @@ -250,7 +250,8 @@ bool AddUsing::prepare(const Selection &Inputs) { for (; Node->Parent; Node = Node->Parent) { if (Node->ASTNode.get()) { continue; - } else if (auto *T = Node->ASTNode.get()) { + } + if (auto *T = Node->ASTNode.get()) { if (T->getAs()) { break; } else if (Node->Parent->ASTNode.get() || diff --git a/clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp b/clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp index da67c7ee27c2e1..a3e20d66b80bfa 100644 --- a/clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp +++ b/clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp @@ -223,8 +223,7 @@ bool alwaysReturns(const ExtractionZone &EZ) { while (const auto *CS = llvm::dyn_cast(Last)) { if (CS->body_empty()) return false; - else - Last = CS->body_back(); + Last = CS->body_back(); } return llvm::isa(Last); }